From patchwork Fri Nov 11 13:01:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 693661 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tFg5r1nVyz9t1h for ; Sat, 12 Nov 2016 00:01:20 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="csWztcTW"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 1770DB7C; Fri, 11 Nov 2016 13:01:17 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 4D296B75 for ; Fri, 11 Nov 2016 13:01:15 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1BF081B4 for ; Fri, 11 Nov 2016 13:01:13 +0000 (UTC) Received: by mail-wm0-f53.google.com with SMTP id a197so424308732wmd.0 for ; Fri, 11 Nov 2016 05:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=spuXpIZ2zW5UFtV0+Wcd3e77ZK3ufKmX2tx5GD5AzBI=; b=csWztcTWdLxWYUwddnr0KweMVVWAAGHXG10rDG99pp7UI/PXifc2H7lo9eHXMmtZtS BDvJhWGXjgoadTxJ1XGtlGAOJef68ORwPILNr9oW6PVwU2H1+QdlLXYPG9wBwVTwqEVy gkTviaR+jsphUsfgqSsfJQlMDvrwWUOe57qrbPk1PC+H+4JjuvH5I2e0G7BvE3H8AoKp 4Dm1o40V9C6lLbN6noZT99MM0DbWlnBpsdhKHbGP6t31fr3Z7sxmCxt1AaiAwn/GZZYm EO5GZ+LBKfDVipHi0PgCMsgGPysvShDTMzKrmo4O2SpHQEHArVWHEHkPd8LJL1pdxrpq UfvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=spuXpIZ2zW5UFtV0+Wcd3e77ZK3ufKmX2tx5GD5AzBI=; b=TuKaUr58GMqBcXYYHtvVHRt/fXWQTjwEeUATvJZVYHXdVRajC7E88F0zEku5HPtJFO 7aVrqAmppreU6QtZBOhw58yBFoWOQwnQFfZ7KOPHVRNJealXoqoavzPE9IwWCDJn/zzt PE2bw8zGXOeVxPUaxBl3I7boe/5ou2+QhBHh5+s6hf3p9zJLBHSJzULj/s6NBnTJsYBk F1ZbDR9R+q2v0rx28XBcvwzvLFmUo16R1g2nrAvk3DPhZKw2OL2btQSzClyujPUBRCmd NTh1Io2gLSB9D9P3WtKlpXx8Xw4IfkUnHTESbNKH60fwzxzIWk5UuBFTAkHU146qoAVj PVTQ== X-Gm-Message-State: ABUngvc4sE8aaP3i+WdDHgR/Jn1xkbuzKf0ThHOCaoAngqunCEPZAzfBW76DaQdcs5VKjA2T X-Received: by 10.194.126.38 with SMTP id mv6mr8981938wjb.142.1478869272648; Fri, 11 Nov 2016 05:01:12 -0800 (PST) Received: from penelope.isobedori.kobe.vergenet.net (penelope.horms.nl. [2001:470:7eb3:403:201:8eff:fe22:8fea]) by smtp.gmail.com with ESMTPSA id j6sm11343561wjk.25.2016.11.11.05.01.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Nov 2016 05:01:11 -0800 (PST) Date: Fri, 11 Nov 2016 14:01:11 +0100 From: Simon Horman To: Joe Stringer Message-ID: <20161111130109.GC31511@penelope.isobedori.kobe.vergenet.net> References: <20161110010022.18731-1-joe@ovn.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161110010022.18731-1-joe@ovn.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/3] lib: Use nl_attr_get_odp_port(). X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Hi Joe, On Wed, Nov 09, 2016 at 05:00:20PM -0800, Joe Stringer wrote: > This helper is a little tidier than the alternative. Use it treewide. > > Signed-off-by: Joe Stringer > --- > lib/dpif-netdev.c | 2 +- > lib/odp-util.c | 2 +- > ofproto/ofproto-dpif-sflow.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) This looks good to me but I think you forgot one place where this change seems appropriate: diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 66ba2c02b3f8..ab95952611d1 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4425,7 +4425,7 @@ dp_execute_cb(void *aux_, struct dp_packet_batch *packets_, case OVS_ACTION_ATTR_TUNNEL_POP: if (*depth < MAX_RECIRC_DEPTH) { struct dp_packet_batch *orig_packets_ = packets_; - odp_port_t portno = u32_to_odp(nl_attr_get_u32(a)); + odp_port_t portno = nl_attr_get_odp_port(a); p = pmd_tx_port_cache_lookup(pmd, portno); if (p) {