From patchwork Wed Apr 6 12:52:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Panu Matilainen X-Patchwork-Id: 607004 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3qg5H569C5z9t3h for ; Wed, 6 Apr 2016 22:52:49 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 2B9CD10247; Wed, 6 Apr 2016 05:52:47 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id ADB0310244 for ; Wed, 6 Apr 2016 05:52:45 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id 01BA616185C for ; Wed, 6 Apr 2016 06:52:45 -0600 (MDT) X-ASG-Debug-ID: 1459947163-0b32373537780990001-byXFYA Received: from mx1-pf2.cudamail.com ([192.168.24.2]) by bar6.cudamail.com with ESMTP id XtyQSTq2qKczxmZh (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 06 Apr 2016 06:52:43 -0600 (MDT) X-Barracuda-Envelope-From: pmatilai@redhat.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.2 Received: from unknown (HELO mx1.redhat.com) (209.132.183.28) by mx1-pf2.cudamail.com with ESMTPS (DHE-RSA-AES256-SHA encrypted); 6 Apr 2016 12:52:43 -0000 Received-SPF: pass (mx1-pf2.cudamail.com: SPF record at _spf1.redhat.com designates 209.132.183.28 as permitted sender) X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-Barracuda-RBL-IP: 209.132.183.28 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5F837F340 for ; Wed, 6 Apr 2016 12:52:41 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org.com (vpn1-7-68.ams2.redhat.com [10.36.7.68]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u36Cqe6x003283 for ; Wed, 6 Apr 2016 08:52:41 -0400 X-CudaMail-Envelope-Sender: pmatilai@redhat.com From: Panu Matilainen To: dev@openvswitch.org X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-E2-405015017 X-CudaMail-DTE: 040616 X-CudaMail-Originating-IP: 209.132.183.28 Date: Wed, 6 Apr 2016 15:52:30 +0300 X-ASG-Orig-Subj: [##CM-E2-405015017##][PATCH] dpif-netdev: report numa node number on pmd thread create failure Message-Id: <18eb783f51738d032d91c088a547794ac5dfdc89.1459947150.git.pmatilai@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Barracuda-Connect: UNKNOWN[192.168.24.2] X-Barracuda-Start-Time: 1459947163 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Subject: [ovs-dev] [PATCH] dpif-netdev: report numa node number on pmd thread create failure X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" Since PMD threads are placed on the NUMA node of the port regardless of a possible pmd-cpu-mask setting, this can lead to a somewhat confusing "out of unpinned cores" message - there might be plenty of available cores in the mask but they cannot be used if the port is on different NUMA node than the cores. Report the NUMA node number to help diagnosing the issue. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1295952 Signed-off-by: Panu Matilainen --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 119dc2d..d7d9704 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -3145,7 +3145,7 @@ dp_netdev_set_pmds_on_numa(struct dp_netdev *dp, int numa_id) n_unpinned = ovs_numa_get_n_unpinned_cores_on_numa(numa_id); if (!n_unpinned) { VLOG_ERR("Cannot create pmd threads due to out of unpinned " - "cores on numa node"); + "cores on numa node %d", numa_id); return; }