From patchwork Wed Feb 17 03:39:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1441166 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Xal+tiul; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DgNrt1Pjrz9sRf for ; Wed, 17 Feb 2021 14:40:13 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1D87585124; Wed, 17 Feb 2021 03:40:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wTZ5Wh0zpHwF; Wed, 17 Feb 2021 03:40:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9DF0685F52; Wed, 17 Feb 2021 03:40:10 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 779AEC0893; Wed, 17 Feb 2021 03:40:10 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id A858AC013A for ; Wed, 17 Feb 2021 03:40:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9C06585F52 for ; Wed, 17 Feb 2021 03:40:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rSmy2Vf323Vw for ; Wed, 17 Feb 2021 03:40:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 08F7F849B7 for ; Wed, 17 Feb 2021 03:40:09 +0000 (UTC) Received: by mail-qk1-f178.google.com with SMTP id v206so11651293qkb.3 for ; Tue, 16 Feb 2021 19:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=qYObSjP1JiP4mv4qusKJ4hFsNgOVxd5VKIlbp+HNgVk=; b=Xal+tiulxb0f66bW3THW2S0WrEr63SMX7x78OiCZFNQYqVtiLlEfOduY4DoU6ZGuvF cX57o0LGP7soh3dKBBf6XTvFwgIXnZ39GVJCS552xmbByOZcFwfp0Q61XIxlk/nrIGAh QL3C2JAmaTIYRU/FQ0isKTjmILBg5JZR+wkinfVzTDm0qZSIx9sIMtzPwSY0iDdL4NS3 xVpDPEDsIJQLxcC+poSR4AqZade3kxve/heWYNR48xBWgLdr3FTikm3GhCO5W/aBkZJi GY3rmIfP+778NTkTJSWTZC6vvJYiDEtU1AVNDGqLWi5/PDQ4OLfqVlCdy/Y2wXT88JiU ZGVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qYObSjP1JiP4mv4qusKJ4hFsNgOVxd5VKIlbp+HNgVk=; b=PR7GjmVV654oZkTzgjzx7hFF66AWmbLM27+dsA1GZgt6sF74K9gUQpBP8CKKnMhpNj 5fMyQngv0mDwGYuIgkomroec4UYOYILo1Cilnc8i2esTp3VHBxhJ3fNll68LSRYlrRAq c+0cQbY2H5Unfu4/okILA1TgoPHpwV67lrVNsM1e4Ai9ftLanbrcujxS1habdZvuWBCX DCCcnjtMNGEotF8EXApbNMMG7AVb4wYmdzNmAuXdh92TmzE8/Us2OAZ21ASXZATBT0HE 5wpANjars2vHAmKdsD+oFhYHAIdIjvalvkFpcHkc05n6sNwoLvyL3d7HBK5KpDnDP0tW jIjw== X-Gm-Message-State: AOAM5323Hc891NYc5x8/8kKKA1uRcR9AMcaKxHLtYfDIkbw3awuOYGrv V4TPWIIT3/ZvYcxj4leTKSEBBCspzDw= X-Google-Smtp-Source: ABdhPJzeM+L5QAsJVW3CZdMS1IgNlWytgNaNWZPMZXPY22/hXsvsieZPaQhYzPgS1dRqR0q3cmAfMQ== X-Received: by 2002:a37:9a84:: with SMTP id c126mr22578489qke.399.1613533207660; Tue, 16 Feb 2021 19:40:07 -0800 (PST) Received: from sc9-mailhost1.vmware.com (c-67-185-44-206.hsd1.wa.comcast.net. [67.185.44.206]) by smtp.gmail.com with ESMTPSA id 80sm740547qkj.128.2021.02.16.19.40.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Feb 2021 19:40:07 -0800 (PST) From: William Tu To: dev@openvswitch.org Date: Tue, 16 Feb 2021 19:39:40 -0800 Message-Id: <1613533180-11511-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 Subject: [ovs-dev] [PATCH] Documentation: Fix DPDK qos example. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" RFC4115 says "The CIR and EIR are both measured in bits/s." Fix the example use case based on the decription. 64-Byte packet * 8 * 1000 pps = 512000 Fixes: e61bdffc2a98 ("netdev-dpdk: Add new DPDK RFC 4115 egress policer") Signed-off-by: William Tu --- Documentation/topics/dpdk/qos.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/topics/dpdk/qos.rst b/Documentation/topics/dpdk/qos.rst index 103495415a9c..e9a51ab3a3f0 100644 --- a/Documentation/topics/dpdk/qos.rst +++ b/Documentation/topics/dpdk/qos.rst @@ -69,22 +69,22 @@ to prioritize certain traffic over others at a port level. For example, the following configuration will limit the traffic rate at a port level to a maximum of 2000 packets a second (64 bytes IPv4 packets). -100pps as CIR (Committed Information Rate) and 1000pps as EIR (Excess +1000pps as CIR (Committed Information Rate) and 1000pps as EIR (Excess Information Rate). High priority traffic is routed to queue 10, which marks all traffic as CIR, i.e. Green. All low priority traffic, queue 20, is marked as EIR, i.e. Yellow:: $ ovs-vsctl --timeout=5 set port dpdk1 qos=@myqos -- \ --id=@myqos create qos type=trtcm-policer \ - other-config:cir=52000 other-config:cbs=2048 \ - other-config:eir=52000 other-config:ebs=2048 \ + other-config:cir=512000 other-config:cbs=2048 \ + other-config:eir=512000 other-config:ebs=2048 \ queues:10=@dpdk1Q10 queues:20=@dpdk1Q20 -- \ --id=@dpdk1Q10 create queue \ - other-config:cir=41600000 other-config:cbs=2048 \ - other-config:eir=0 other-config:ebs=0 -- \ + other-config:cir=512000 other-config:cbs=2048 \ + other-config:eir=512000 other-config:ebs=0 -- \ --id=@dpdk1Q20 create queue \ other-config:cir=0 other-config:cbs=0 \ - other-config:eir=41600000 other-config:ebs=2048 \ + other-config:eir=512000 other-config:ebs=2048 \ This configuration accomplishes that the high priority traffic has a guaranteed bandwidth egressing the ports at CIR (1000pps), but it can also