diff mbox series

[ovs-dev] ovs-bugtool: Add ethtool -l for combined channel.

Message ID 1588182342-87336-1-git-send-email-u9012063@gmail.com
State Accepted
Commit f5a36db10b1ffe243a64f650e24160eb985c8eac
Headers show
Series [ovs-dev] ovs-bugtool: Add ethtool -l for combined channel. | expand

Commit Message

William Tu April 29, 2020, 5:45 p.m. UTC
Users of netdev-afxdp has to setup the combined channel
on physical NIC. This helps debugging related issues.
Example output:
  $ ethtool -l enp3s0f0
  Channel parameters for enp3s0f0:
  Pre-set maximums:
  RX:        0
  TX:        0
  Other:     1
  Combined:  63
  Current hardware settings:
  RX:        0
  TX:        0
  Other:     1
  Combined:  1

Some previous discussion:
https://mail.openvswitch.org/pipermail/ovs-dev/2020-January/366631.html

Signed-off-by: William Tu <u9012063@gmail.com>
---
 utilities/bugtool/ovs-bugtool.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Yi-Hung Wei April 29, 2020, 6:13 p.m. UTC | #1
On Wed, Apr 29, 2020 at 10:46 AM William Tu <u9012063@gmail.com> wrote:
>
> Users of netdev-afxdp has to setup the combined channel
> on physical NIC. This helps debugging related issues.
> Example output:
>   $ ethtool -l enp3s0f0
>   Channel parameters for enp3s0f0:
>   Pre-set maximums:
>   RX:        0
>   TX:        0
>   Other:     1
>   Combined:  63
>   Current hardware settings:
>   RX:        0
>   TX:        0
>   Other:     1
>   Combined:  1
>
> Some previous discussion:
> https://mail.openvswitch.org/pipermail/ovs-dev/2020-January/366631.html
>
> Signed-off-by: William Tu <u9012063@gmail.com>

Given that each NIC has different implementation on their rx, tx,
combined queue as mentioned in
https://mail.openvswitch.org/pipermail/ovs-dev/2020-January/366631.html

I think it is a good idea to at log that in the bugtool.

Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>
diff mbox series

Patch

diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugtool/ovs-bugtool.in
index 47f3c4629f70..1a5170d8c78b 100755
--- a/utilities/bugtool/ovs-bugtool.in
+++ b/utilities/bugtool/ovs-bugtool.in
@@ -628,6 +628,7 @@  exclude those logs from the archive.
                     cmd_output(CAP_NETWORK_INFO, [ETHTOOL, '-k', p])
                     cmd_output(CAP_NETWORK_INFO, [ETHTOOL, '-i', p])
                     cmd_output(CAP_NETWORK_INFO, [ETHTOOL, '-c', p])
+                    cmd_output(CAP_NETWORK_INFO, [ETHTOOL, '-l', p])
             if int(t) == 1:
                 cmd_output(CAP_NETWORK_INFO,
                            [TC, '-s', '-d', 'class', 'show', 'dev', p])