diff mbox series

[ovs-dev,v1] tests: Fix IPv4 checksums in zone limit test.

Message ID 1557161267-61387-1-git-send-email-dlu998@gmail.com
State Accepted
Commit e2603f61dff058502d566c35986c172d18d881f4
Headers show
Series [ovs-dev,v1] tests: Fix IPv4 checksums in zone limit test. | expand

Commit Message

Darrell Ball May 6, 2019, 4:47 p.m. UTC 
Userspace conntrack cares about IPv4 checksums, so this is a
prerequisite for adding zone limit support to userspace conntrack.

Fixes: 3f1087c70cf9 ("system-traffic: Add conntrack per zone limit test case.")
CC: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Darrell Ball <dlu998@gmail.com>
---
 tests/system-traffic.at | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Yi-Hung Wei May 6, 2019, 9:24 p.m. UTC | #1 
On Mon, May 6, 2019 at 9:48 AM Darrell Ball <dlu998@gmail.com> wrote:
>
> Userspace conntrack cares about IPv4 checksums, so this is a
> prerequisite for adding zone limit support to userspace conntrack.
>
> Fixes: 3f1087c70cf9 ("system-traffic: Add conntrack per zone limit test case.")
> CC: Yi-Hung Wei <yihung.wei@gmail.com>
> Signed-off-by: Darrell Ball <dlu998@gmail.com>
> ---

Thanks for the fix.

Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>
Ben Pfaff May 7, 2019, 9:16 p.m. UTC | #2 
On Mon, May 06, 2019 at 02:24:58PM -0700, Yi-Hung Wei wrote:
> On Mon, May 6, 2019 at 9:48 AM Darrell Ball <dlu998@gmail.com> wrote:
> >
> > Userspace conntrack cares about IPv4 checksums, so this is a
> > prerequisite for adding zone limit support to userspace conntrack.
> >
> > Fixes: 3f1087c70cf9 ("system-traffic: Add conntrack per zone limit test case.")
> > CC: Yi-Hung Wei <yihung.wei@gmail.com>
> > Signed-off-by: Darrell Ball <dlu998@gmail.com>
> > ---
> 
> Thanks for the fix.
> 
> Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>

Thanks, Darrell and Yi-Hung.   I applied this to master.
diff mbox series

Patch

diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index a358744..79d12fe 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -3444,11 +3444,11 @@  udp,orig=(src=10.1.1.1,dst=10.1.1.2,sport=1,dport=6),reply=(src=10.1.1.2,dst=10.
 ])
 
 dnl Test UDP from port 2
-AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=2 packet=50540000000a50540000000908004500001c000000000011a4cd0a0101030a0101040001000200080000 actions=resubmit(,0)"])
-AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=2 packet=50540000000a50540000000908004500001c000000000011a4cd0a0101030a0101040001000300080000 actions=resubmit(,0)"])
-AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=2 packet=50540000000a50540000000908004500001c000000000011a4cd0a0101030a0101040001000400080000 actions=resubmit(,0)"])
-AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=2 packet=50540000000a50540000000908004500001c000000000011a4cd0a0101030a0101040001000500080000 actions=resubmit(,0)"])
-AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=2 packet=50540000000a50540000000908004500001c000000000011a4cd0a0101030a0101040001000600080000 actions=resubmit(,0)"])
+AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=2 packet=50540000000a50540000000908004500001c000000000011a4c90a0101030a0101040001000200080000 actions=resubmit(,0)"])
+AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=2 packet=50540000000a50540000000908004500001c000000000011a4c90a0101030a0101040001000300080000 actions=resubmit(,0)"])
+AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=2 packet=50540000000a50540000000908004500001c000000000011a4c90a0101030a0101040001000400080000 actions=resubmit(,0)"])
+AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=2 packet=50540000000a50540000000908004500001c000000000011a4c90a0101030a0101040001000500080000 actions=resubmit(,0)"])
+AT_CHECK([ovs-ofctl -O OpenFlow13 packet-out br0 "in_port=2 packet=50540000000a50540000000908004500001c000000000011a4c90a0101030a0101040001000600080000 actions=resubmit(,0)"])
 
 AT_CHECK([ovs-appctl dpctl/ct-get-limits zone=0,3], [0], [dnl
 default limit=10