diff mbox series

[ovs-dev,v1,2/3] ipf: Do not preallocate more than needed.

Message ID 1550221215-87456-2-git-send-email-dlu998@gmail.com
State Superseded
Headers show
Series [ovs-dev,v1,1/3] ipf: Misc Cleanup. | expand

Commit Message

Darrell Ball Feb. 15, 2019, 9 a.m. UTC 
ipf_reassemble_v4_frags() and ipf_reassemble_v6_frags() are
preallocating more than needed for the reassembled packet.

Signed-off-by: Darrell Ball <dlu998@gmail.com>
---
 lib/ipf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/lib/ipf.c b/lib/ipf.c
index 125a815..ec7c889 100644
--- a/lib/ipf.c
+++ b/lib/ipf.c
@@ -420,7 +420,7 @@  ipf_reassemble_v4_frags(struct ipf_list *ipf_list)
         return NULL;
     }
 
-    dp_packet_prealloc_tailroom(pkt, len + rest_len);
+    dp_packet_prealloc_tailroom(pkt, rest_len);
 
     for (int i = 1; i <= ipf_list->last_inuse_idx; i++) {
         size_t add_len = frag_list[i].end_data_byte -
@@ -463,7 +463,7 @@  ipf_reassemble_v6_frags(struct ipf_list *ipf_list)
         return NULL;
     }
 
-    dp_packet_prealloc_tailroom(pkt, pl + rest_len);
+    dp_packet_prealloc_tailroom(pkt, rest_len);
 
     for (int i = 1; i <= ipf_list->last_inuse_idx; i++) {
         size_t add_len = frag_list[i].end_data_byte -