diff mbox series

[ovs-dev,v1,2/2] ovs-vsctl: Fix segfault when attempting to del-port from parent bridge.

Message ID 1525216057-13696-3-git-send-email-flavio@flaviof.com
State Accepted
Headers show
Series ovs-vsctl segfaults on del-port of fake-bridge when parent is provided | expand

Commit Message

Flaviof May 1, 2018, 11:07 p.m. UTC 
The error message in the check for improper bridge param is de-referencing
parent from the wrong bridge. Also, the message itself had the parent and
child bridges reversed, so that got a small tweak as well.

Signed-off-by: Flavio Fernandes <flavio@flaviof.com>
---
 utilities/ovs-vsctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index c69e89e..188a390 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -1748,9 +1748,9 @@  cmd_del_port(struct ctl_context *ctx)
             if (port->bridge != bridge) {
                 if (port->bridge->parent == bridge) {
                     ctl_fatal("bridge %s does not have a port %s (although "
-                                "its parent bridge %s does)",
+                                "its child bridge %s does)",
                                 ctx->argv[1], ctx->argv[2],
-                                bridge->parent->name);
+                                port->bridge->name);
                 } else {
                     ctl_fatal("bridge %s does not have a port %s",
                                 ctx->argv[1], ctx->argv[2]);