From patchwork Thu Jul 13 13:13:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miguel Angel Ajo X-Patchwork-Id: 787727 X-Patchwork-Delegate: rbryant@redhat.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3x7brB4B7Bz9s0g for ; Thu, 13 Jul 2017 23:14:18 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 94A459EE; Thu, 13 Jul 2017 13:13:45 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id BC48B99F for ; Thu, 13 Jul 2017 13:13:44 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 955E317C for ; Thu, 13 Jul 2017 13:13:43 +0000 (UTC) Received: by mail-wm0-f47.google.com with SMTP id f67so25613387wmh.1 for ; Thu, 13 Jul 2017 06:13:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nJXHmW4w+1cZUvSbNZvzCUMDSMTesR4o5puuSHG1WN4=; b=UWCPGgRWEImrA2DNY0SYev4SadtYivVYuX1u5cwqCmy7nB5ef3p9mz2Ig6b6IaYyCO iauEvNmfCncjJkyC2xU1burXLOqFjPkD6m2pFcPL2uI42Kk0CP6tI1pEY3Ju9FxaXmRf 00flxUQVDoTJCgnMCPXRFbiEdB4xW1zxXv8tqrP9myo8xPTm/3Jb6+l7FzynG5qyz19Y Wv8Vzh8TJ2o8XXeZFADNTLXODckEnvWgJ3S/JmdjjSIubEdxFd0bDUhdZCOz9paWZ05c tgxL2VakmHveLMERanzTUuMglIYOCMU7EEdWNuG396qirtdsIyn2OatZ09cOq9W7Oeg4 u2tw== X-Gm-Message-State: AIVw111oPdGczim31ifjr7taVoe88mOrd3dJL6HaPFl6IKgSbA00/Rjr NEMkGsVaUVG1VdIAUiqaaA== X-Received: by 10.28.166.137 with SMTP id p131mr2046519wme.5.1499951622009; Thu, 13 Jul 2017 06:13:42 -0700 (PDT) Received: from ctl.localdomain (111.148.134.37.dynamic.jazztel.es. [37.134.148.111]) by smtp.gmail.com with ESMTPSA id e20sm1895404wre.54.2017.07.13.06.13.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jul 2017 06:13:40 -0700 (PDT) From: Miguel Angel Ajo To: dev@openvswitch.org Date: Thu, 13 Jul 2017 13:13:34 +0000 Message-Id: <1499951614-4125-2-git-send-email-majopela@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1499951614-4125-1-git-send-email-majopela@redhat.com> References: <1496930708-15441-1-git-send-email-majopela@redhat.com> <1499951614-4125-1-git-send-email-majopela@redhat.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Miguel Angel Ajo Subject: [ovs-dev] [PATCH v5 1/1] ovn: l3ha ensure no master bouncing when ovn-controller is restarted X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org When ovn-controller is restarted, ovn-controller removes the old Chassis entry from the SBDB and a new one is inserted. This cleared the Gateway_Chassis chassis column in the SBDB and then ovn-northd removed the empty-column Gateway_Chassis entry. Such event made the other (non-restarted and master gateway chassis) believe that he was a single (non-HA) gateway, turning off BFD and releasing the port for a tiny time frame causing unnecesary downtime. Signed-off-by: Miguel Angel Ajo --- ovn/northd/ovn-northd.c | 34 +++++++++++--------- tests/ovn.at | 82 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 102 insertions(+), 14 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 9a1e6c1..62a73f3 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -1684,11 +1684,22 @@ gateway_chassis_equal(const struct nbrec_gateway_chassis *nb_gwc, const struct sbrec_chassis *nb_gwc_c, const struct sbrec_gateway_chassis *sb_gwc) { - return !strcmp(nb_gwc->name, sb_gwc->name) - && !strcmp(nb_gwc_c->name, sb_gwc->chassis->name) - && nb_gwc->priority == sb_gwc->priority - && smap_equal(&nb_gwc->options, &sb_gwc->options) - && smap_equal(&nb_gwc->external_ids, &sb_gwc->external_ids); + bool equal = !strcmp(nb_gwc->name, sb_gwc->name) + && nb_gwc->priority == sb_gwc->priority + && smap_equal(&nb_gwc->options, &sb_gwc->options) + && smap_equal(&nb_gwc->external_ids, &sb_gwc->external_ids); + + if (!equal) { + return false; + } + + /* If everything else matched and we were unable to find the SBDB + * Chassis entry at this time, assume a match and return true. + * This happens when an ovn-controller is restarting and the Chassis + * entry is gone away momentarily */ + return !nb_gwc_c + || (sb_gwc->chassis && !strcmp(nb_gwc_c->name, + sb_gwc->chassis->name)); } static bool @@ -1723,11 +1734,10 @@ sbpb_gw_chassis_needs_update( chassis_lookup_by_name(chassis_index, lrp->gateway_chassis[n]->chassis_name); - if (chassis) { - lrp_gwc_c[lrp_n_gateway_chassis] = chassis; - lrp_gwc[lrp_n_gateway_chassis] = lrp->gateway_chassis[n]; - lrp_n_gateway_chassis++; - } else { + lrp_gwc_c[lrp_n_gateway_chassis] = chassis; + lrp_gwc[lrp_n_gateway_chassis] = lrp->gateway_chassis[n]; + lrp_n_gateway_chassis++; + if (!chassis) { static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1); VLOG_WARN_RL( &rl, "Chassis name %s referenced in NBDB via Gateway_Chassis " @@ -1807,10 +1817,6 @@ copy_gw_chassis_from_nbrp_to_sbpb( const struct sbrec_chassis *chassis = chassis_lookup_by_name(chassis_index, lrp_gwc->chassis_name); - if (!chassis) { - continue; - } - gw_chassis = xrealloc(gw_chassis, (n_gwc + 1) * sizeof *gw_chassis); struct sbrec_gateway_chassis *pb_gwc = diff --git a/tests/ovn.at b/tests/ovn.at index 5a0b761..07b822d 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -8080,3 +8080,85 @@ AT_CHECK([grep $garp hv2_br_phys_tx | sort], [0], []) OVN_CLEANUP([hv1],[hv2],[hv3]) AT_CLEANUP + +AT_SETUP([ovn -- ensure one gw controller restart in HA doesn't bounce the master]) +AT_SKIP_IF([test $HAVE_PYTHON = no]) +ovn_start + +net_add n1 + +# create two gateways with external network connectivity +for i in 1 2; do + sim_add gw$i + as gw$i + ovs-vsctl add-br br-phys + ovn_attach n1 br-phys 192.168.0.$i + ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys +done + +ovn-nbctl ls-add inside +ovn-nbctl ls-add outside + +# create one hypervisors with a vif port the internal network +sim_add hv1 +as hv1 +ovs-vsctl add-br br-phys +ovn_attach n1 br-phys 192.168.0.11 +ovs-vsctl -- add-port br-int hv1-vif1 -- \ + set interface hv1-vif1 external-ids:iface-id=inside1 \ + options:tx_pcap=hv1/vif1-tx.pcap \ + options:rxq_pcap=hv1/vif1-rx.pcap \ + ofport-request=1 + +ovn-nbctl lsp-add inside inside1 \ + -- lsp-set-addresses inside1 "f0:00:00:01:22:01 192.168.1.101" + + +ovn_populate_arp + +ovn-nbctl create Logical_Router name=R1 + +# Connect inside to R1 +ovn-nbctl lrp-add R1 inside 00:00:01:01:02:03 192.168.1.1/24 +ovn-nbctl lsp-add inside rp-inside -- set Logical_Switch_Port rp-inside \ + type=router options:router-port=inside \ + -- lsp-set-addresses rp-inside router + +# Connect outside to R1 as distributed router gateway port on gw1+gw2 +ovn-nbctl lrp-add R1 outside 00:00:02:01:02:04 192.168.0.101/24 + +ovn-nbctl --id=@gc0 create Gateway_Chassis \ + name=outside_gw1 chassis_name=gw1 priority=20 -- \ + --id=@gc1 create Gateway_Chassis \ + name=outside_gw2 chassis_name=gw2 priority=10 -- \ + set Logical_Router_Port outside 'gateway_chassis=[@gc0,@gc1]' + +ovn-nbctl lsp-add outside rp-outside -- set Logical_Switch_Port rp-outside \ + type=router options:router-port=outside \ + -- lsp-set-addresses rp-outside router + +# Create localnet port in outside +ovn-nbctl lsp-add outside ln-outside +ovn-nbctl lsp-set-addresses ln-outside unknown +ovn-nbctl lsp-set-type ln-outside localnet +ovn-nbctl lsp-set-options ln-outside network_name=phys + +# Allow some time for ovn-northd and ovn-controller to catch up. +ovn-nbctl --wait=hv sync + +# currently when ovn-controller is restarted, the old entry is deleted +# and a new one is created, which leaves the Gateway_Chassis with +# an empty chassis for a while. NOTE: restarting ovn-controller in tests +# doesn't have the same effect because "name" is conserved, and the +# Chassis entry is not replaced. + +gw2_chassis=$(ovn-sbctl --bare --columns=_uuid find Chassis name=gw2) +ovn-sbctl destroy Chassis $gw2_chassis + +sleep 2 + +AT_CHECK([grep "Releasing lport" gw1/ovn-controller.log], [1], []) + +OVN_CLEANUP([gw1],[gw2],[hv1]) + +AT_CLEANUP