From patchwork Wed May 3 15:55:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 758144 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wJ30W2YHCz9rxj for ; Thu, 4 May 2017 02:05:31 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="kYcARLWE"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 30C78B80; Wed, 3 May 2017 15:56:03 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id DEB00D05 for ; Wed, 3 May 2017 15:56:01 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id AF9021D8 for ; Wed, 3 May 2017 15:56:00 +0000 (UTC) Received: by mail-wm0-f46.google.com with SMTP id r190so63831589wme.1 for ; Wed, 03 May 2017 08:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=XspEwRUozKOIOPbBvTrrpV0YIasGuMuvwMxSlKj2ZYE=; b=kYcARLWEBHwIkbLRmyYXAuD/+E3H19yp3Q2z8EUKhR8q5c9NHca6UPwMnG0VKLp6DH 4bQlLK766nY0b10VX1keD7dqgfSgoN45voFIgIerJmFJDdpzlCfeyDJW+EuE5NRPf7fn tDpNSeIsmZuyV3OIZ9579FXHBtmdBJGmGzIeZ/R1CPvnIzsv0Q9DvqrR8LAczaQzXrsA oBMmVLdUXQS0tbPFmxxiHS7M1s5WlH7zh4Kvf4t+bcz22OE/FGNe95fvzCkQV1btvUru Nj8pN6/eIxujW9U7rTYyUzVOQgvGHfYbSoTFl+bOeC/qoLGcLtggpF/CHvzoSjwCjSbG cV8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XspEwRUozKOIOPbBvTrrpV0YIasGuMuvwMxSlKj2ZYE=; b=rXumgcmXCYyuKO3AS6MYeQ8ZYBR3sjF+3XTlxJZhCijyk8xwxVd0Ipx+5M5yN3m7Xq Cid+uNuImE2ZdBJEfvzUBSbZMwptXO7Rn7ssc5BihDq4IjyfCm20lU/gSNgmG2cWgvly uN7FWSfEThDIX0AbTSQKa+vS+9R64tDqXWydM5TvS648IKn7Jv3oiE6UcR3+GEi7hu5C r+hbtpvHyvnKl+l5I+j89dyK77wdKHkK8ruPmZy/60wAaqCVLf8YgXmN7MM126AdJ/Wu 9r+4YH6yo6te+mtA88J7owhSLlT/Oy97CraoG3I67R2Fl99PmbtLj2Lm9hHGY7W5Y4H0 q7vA== X-Gm-Message-State: AN3rC/4tbZ2ervRP9Of8Qw2wjLuJoZvWZTe3epDtZeC6eGkKQe5uXibD Byf4StxprmrJrpSpIu1MPA== X-Received: by 10.80.213.29 with SMTP id u29mr3661769edi.47.1493826959067; Wed, 03 May 2017 08:55:59 -0700 (PDT) Received: from reginn.horms.nl (52D9BC73.cm-11-1c.dynamic.ziggo.nl. [82.217.188.115]) by smtp.gmail.com with ESMTPSA id j50sm1505568eda.44.2017.05.03.08.55.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 May 2017 08:55:57 -0700 (PDT) From: Simon Horman To: dev@openvswitch.org Date: Wed, 3 May 2017 17:55:51 +0200 Message-Id: <1493826951-25412-1-git-send-email-simon.horman@netronome.com> X-Mailer: git-send-email 2.1.4 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: oss-drivers@netronome.com, Simon Horman , Dinan Gunawardena Subject: [ovs-dev] [PATCH] tests: Only run python SSL test if SSL support is configured X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Only run python SSL test, which invokes ovsdb with a --remote=pssl, if SSL support is configured. Without this change the following error appears when running the test-suite when OVS is configured with --disable-ssl. +ovsdb-server: Private key specified but Open vSwitch was built without SSL support ./ovsdb-idl.at:1215: exit code was 1, expected 0 Fixes: d90ed7d65ba8 ("python: Add SSL support to the python ovs client library") Cc: Numan Siddique Signed-off-by: Simon Horman Acked-by: Ben Pfaff --- tests/ovsdb-idl.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at index d2c1ea6f3aaa..d28dfc11e786 100644 --- a/tests/ovsdb-idl.at +++ b/tests/ovsdb-idl.at @@ -1183,6 +1183,7 @@ m4_define([OVSDB_CHECK_IDL_NOTIFY_PY], # This test uses the Python IDL implementation with ssl m4_define([OVSDB_CHECK_IDL_NOTIFY_SSL_PY], [AT_SETUP([$1 - SSL]) + AT_SKIP_IF([test "$HAVE_OPENSSL" = no]) AT_SKIP_IF([test $HAVE_PYTHON = no]) $PYTHON -m OpenSSL.SSL SSL_PRESENT=$?