| Message ID | 1493826951-25412-1-git-send-email-simon.horman@netronome.com |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, May 03, 2017 at 05:55:51PM +0200, Simon Horman wrote: > Only run python SSL test, which invokes ovsdb with a --remote=pssl, > if SSL support is configured. > > Without this change the following error appears when running > the test-suite when OVS is configured with --disable-ssl. > > +ovsdb-server: Private key specified but Open vSwitch was built without SSL support > ./ovsdb-idl.at:1215: exit code was 1, expected 0 > > Fixes: d90ed7d65ba8 ("python: Add SSL support to the python ovs client library") > Cc: Numan Siddique <nusiddiq@redhat.com> > Signed-off-by: Simon Horman <simon.horman@netronome.com> Good catch. Acked-by: Ben Pfaff <blp@ovn.org>
On Wed, May 03, 2017 at 10:56:39AM -0700, Ben Pfaff wrote: > On Wed, May 03, 2017 at 05:55:51PM +0200, Simon Horman wrote: > > Only run python SSL test, which invokes ovsdb with a --remote=pssl, > > if SSL support is configured. > > > > Without this change the following error appears when running > > the test-suite when OVS is configured with --disable-ssl. > > > > +ovsdb-server: Private key specified but Open vSwitch was built without SSL support > > ./ovsdb-idl.at:1215: exit code was 1, expected 0 > > > > Fixes: d90ed7d65ba8 ("python: Add SSL support to the python ovs client library") > > Cc: Numan Siddique <nusiddiq@redhat.com> > > Signed-off-by: Simon Horman <simon.horman@netronome.com> > > Good catch. > > Acked-by: Ben Pfaff <blp@ovn.org> Thanks, applied.
diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at index d2c1ea6f3aaa..d28dfc11e786 100644 --- a/tests/ovsdb-idl.at +++ b/tests/ovsdb-idl.at @@ -1183,6 +1183,7 @@ m4_define([OVSDB_CHECK_IDL_NOTIFY_PY], # This test uses the Python IDL implementation with ssl m4_define([OVSDB_CHECK_IDL_NOTIFY_SSL_PY], [AT_SETUP([$1 - SSL]) + AT_SKIP_IF([test "$HAVE_OPENSSL" = no]) AT_SKIP_IF([test $HAVE_PYTHON = no]) $PYTHON -m OpenSSL.SSL SSL_PRESENT=$?
Only run python SSL test, which invokes ovsdb with a --remote=pssl, if SSL support is configured. Without this change the following error appears when running the test-suite when OVS is configured with --disable-ssl. +ovsdb-server: Private key specified but Open vSwitch was built without SSL support ./ovsdb-idl.at:1215: exit code was 1, expected 0 Fixes: d90ed7d65ba8 ("python: Add SSL support to the python ovs client library") Cc: Numan Siddique <nusiddiq@redhat.com> Signed-off-by: Simon Horman <simon.horman@netronome.com> --- tests/ovsdb-idl.at | 1 + 1 file changed, 1 insertion(+)