From patchwork Tue May 2 06:10:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Qiu X-Patchwork-Id: 757397 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wH9vb2b12z9sD9 for ; Tue, 2 May 2017 16:13:15 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lkC7K9V6"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 1E991B1E; Tue, 2 May 2017 06:12:46 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id D984F978 for ; Tue, 2 May 2017 06:12:44 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 92E9210A for ; Tue, 2 May 2017 06:12:44 +0000 (UTC) Received: by mail-pg0-f66.google.com with SMTP id s62so7735070pgc.0 for ; Mon, 01 May 2017 23:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1uBir7lHuN625uryStayDKEYJqj/mjsp3RSuFkiEv5Q=; b=lkC7K9V67qQslS8np6r7Ohph8/vcocE2bhlgk807Jr+b1xjrat5+0JjRnVyuEuL1CJ vFwr4Xni86t0pIJqCK3bRLbgeem+7n2LBIdCZ9YSDBZqWs1tZUqxk5MVXUd/OhUBu74C W6SBe8BQVtX45UoOxapv8SauWGmDfOybpOvERxbvnS1wGbphmiLKQBXD/m31FW5g+tSU txFqglv4ivTTGHpzcMqks/VXyEyClVoblDh/ZqTk6qHJIM0licot/s4YZin0poM8C2Tb vTgD02BJK12o43V1nzofMiXl/unIAaqUzXLYEVTSJZqTkj9vLzE+aCglWl65extTvMF8 pqeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1uBir7lHuN625uryStayDKEYJqj/mjsp3RSuFkiEv5Q=; b=DBeToCI611BMzUyfGYyLLZbphHHxEPDbJa1uGktVqaT6LX+wbJtocKnBVg2AXJBZXv foVsY0TF5MJKupWoHDGHmo+oW7a+Hu3wxAWLVIdOTNP7nbd061FvrkwRKeFojgkhLpT7 IpDHqgmAk61y5MuXg1/JtkmovbbUVax1AitkQS3kGAJse7e1Hb21ipH9SmnJse2gH6sU SppsrLFqNbYLJtwOZdpe6jQmDMOSd2/hZYK0SctTUxA78wpNKJchkJH/igQMNJMRyb1y PejB6GOGcxTlCFrKqFCVRG4o6IXlj6U2/Xb8w22gkOHeb+3tDuWE2M3WmOrH9fDRv9CD zqvw== X-Gm-Message-State: AN3rC/5gcQcerSKfGjBaS/yJ4DbniqgPn9Lcs+aq8lc6LeLSfjzDZLcs fpfPcHJknlHjEw== X-Received: by 10.99.56.90 with SMTP id h26mr30685571pgn.43.1493705564252; Mon, 01 May 2017 23:12:44 -0700 (PDT) Received: from localhost.localdomain ([219.248.5.111]) by smtp.gmail.com with ESMTPSA id l62sm1394784pfb.91.2017.05.01.23.12.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 May 2017 23:12:43 -0700 (PDT) From: Michael Qiu To: dev@openvswitch.org Date: Tue, 2 May 2017 14:10:42 +0800 Message-Id: <1493705445-5774-3-git-send-email-qdy220091330@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1493705445-5774-1-git-send-email-qdy220091330@gmail.com> References: <1493705445-5774-1-git-send-email-qdy220091330@gmail.com> X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_HTTP, RCVD_IN_SORBS_SOCKS, RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Michael Qiu Subject: [ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Michael Qiu Currently, when doing packet copy, lots of DPDK mbuf's info will be missed, like packet type, ol_flags, etc. Those information is very important for DPDK to do packets processing. Signed-off-by: Michael Qiu --- lib/dp-packet.c | 3 +++ lib/netdev-dpdk.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/lib/dp-packet.c b/lib/dp-packet.c index 109947c..79f6e7e 100644 --- a/lib/dp-packet.c +++ b/lib/dp-packet.c @@ -176,6 +176,9 @@ dp_packet_clone_with_headroom(const struct dp_packet *buffer, size_t headroom) new_buffer->cutlen = buffer->cutlen; #ifdef DPDK_NETDEV new_buffer->mbuf.ol_flags = buffer->mbuf.ol_flags; + new_buffer->mbuf.tx_offload = buffer->mbuf.tx_offload; + new_buffer->mbuf.packet_type = buffer->mbuf.packet_type; + new_buffer->mbuf.nb_segs = buffer->mbuf.nb_segs; #else new_buffer->rss_hash_valid = buffer->rss_hash_valid; #endif diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index ddc651b..ba044a3 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1764,6 +1764,10 @@ dpdk_do_tx_copy(struct netdev *netdev, int qid, struct dp_packet_batch *batch) memcpy(rte_pktmbuf_mtod(pkts[newcnt], void *), dp_packet_data(batch->packets[i]), size); + pkts[newcnt]->nb_segs = batch->packets[i]->mbuf.nb_segs; + pkts[newcnt]->ol_flags = batch->packets[i]->mbuf.ol_flags; + pkts[newcnt]->packet_type = batch->packets[i]->mbuf.packet_type; + pkts[newcnt]->tx_offload = batch->packets[i]->mbuf.tx_offload; rte_pktmbuf_data_len(pkts[newcnt]) = size; rte_pktmbuf_pkt_len(pkts[newcnt]) = size;