diff mbox

[ovs-dev,1/2] acinclude: Allow compile with Linux 4.11.

Message ID 1492127256-124251-1-git-send-email-jarno@ovn.org
State Superseded
Headers show

Commit Message

Jarno Rajahalme April 13, 2017, 11:47 p.m. UTC
Change the Linux kernel tests in OVS configuration.

While the backports may still be a little behind, it is useful to be
able to test the OVS tree kernel module with the upstream net-next
kernel.

Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
---
 acinclude.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ben Pfaff April 15, 2017, 3:56 a.m. UTC | #1
On Thu, Apr 13, 2017 at 04:47:35PM -0700, Jarno Rajahalme wrote:
> Change the Linux kernel tests in OVS configuration.
> 
> While the backports may still be a little behind, it is useful to be
> able to test the OVS tree kernel module with the upstream net-next
> kernel.
> 
> Signed-off-by: Jarno Rajahalme <jarno@ovn.org>

Here's a review to indicate that this patch does what the commit message
says it does.  I don't have an informed position on whether this is a
good thing to do.  I'm happy to take your word on that, or you can ask
someone better informed if you like.

Acked-by: Ben Pfaff <blp@ovn.org>
Jarno Rajahalme April 17, 2017, 7:35 p.m. UTC | #2
> On Apr 14, 2017, at 8:56 PM, Ben Pfaff <blp@ovn.org> wrote:
> 
> On Thu, Apr 13, 2017 at 04:47:35PM -0700, Jarno Rajahalme wrote:
>> Change the Linux kernel tests in OVS configuration.
>> 
>> While the backports may still be a little behind, it is useful to be
>> able to test the OVS tree kernel module with the upstream net-next
>> kernel.
>> 
>> Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
> 
> Here's a review to indicate that this patch does what the commit message
> says it does.  I don't have an informed position on whether this is a
> good thing to do.  I'm happy to take your word on that, or you can ask
> someone better informed if you like.
> 
> Acked-by: Ben Pfaff <blp@ovn.org>

Thanks for the review!

At worst we need to revert this before the next release if we find that the OVS tree kernel module does not work with Linux 4.11. By enabling it in the master now we’ll get more testing for it, so I merged this to master.

  Jarno
diff mbox

Patch

diff --git a/acinclude.m4 b/acinclude.m4
index 744d8f8..914de45 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -134,10 +134,10 @@  AC_DEFUN([OVS_CHECK_LINUX], [
     AC_MSG_RESULT([$kversion])
 
     if test "$version" -ge 4; then
-       if test "$version" = 4 && test "$patchlevel" -le 10; then
+       if test "$version" = 4 && test "$patchlevel" -le 11; then
           : # Linux 4.x
        else
-          AC_ERROR([Linux kernel in $KBUILD is version $kversion, but version newer than 4.10.x is not supported (please refer to the FAQ for advice)])
+          AC_ERROR([Linux kernel in $KBUILD is version $kversion, but version newer than 4.11.x is not supported (please refer to the FAQ for advice)])
        fi
     elif test "$version" = 3 && test "$patchlevel" -ge 10; then
        : # Linux 3.x