diff mbox

[ovs-dev,v2] ofproto/bond: Drop traffic in balance-tcp mode without lacp.

Message ID 1487208738-24881-1-git-send-email-nic@opencloud.tech
State Accepted
Headers show

Commit Message

nickcooper-zhangtonghao Feb. 16, 2017, 1:32 a.m. UTC 
The balance-tcp mode requires the upstream switch to support 802.3ad
with successful LACP negotiation. When bond ports are configured to
balance-tcp mode without lacp or lacp is disabled, drop the traffic.

Signed-off-by: nickcooper-zhangtonghao <nic@opencloud.tech>
---
 ofproto/bond.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Andy Zhou Feb. 16, 2017, 8:48 p.m. UTC | #1 
On Wed, Feb 15, 2017 at 5:32 PM, nickcooper-zhangtonghao
<nic@opencloud.tech> wrote:
> The balance-tcp mode requires the upstream switch to support 802.3ad
> with successful LACP negotiation. When bond ports are configured to
> balance-tcp mode without lacp or lacp is disabled, drop the traffic.
>
> Signed-off-by: nickcooper-zhangtonghao <nic@opencloud.tech>
Applied. Thanks.
diff mbox

Patch

diff --git a/ofproto/bond.c b/ofproto/bond.c
index 2e018aa..e4caf98 100644
--- a/ofproto/bond.c
+++ b/ofproto/bond.c
@@ -786,7 +786,11 @@  bond_check_admissibility(struct bond *bond, const void *slave_,
         if (!bond->lacp_fallback_ab) {
             goto out;
         }
+        break;
     case LACP_DISABLED:
+        if (bond->balance == BM_TCP) {
+            goto out;
+        }
         break;
     }