Message ID | 1486536071-14280-1-git-send-email-u9012063@gmail.com |
---|---|
State | Superseded |
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vJBST2ymhz9s7c for <incoming@patchwork.ozlabs.org>; Wed, 8 Feb 2017 17:41:29 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dT9UdNRX"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 8134DB79; Wed, 8 Feb 2017 06:41:25 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id EF6C8A5E for <ovs-dev@openvswitch.org>; Wed, 8 Feb 2017 06:41:23 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id AA9F916A for <ovs-dev@openvswitch.org>; Wed, 8 Feb 2017 06:41:23 +0000 (UTC) Received: by mail-pf0-f193.google.com with SMTP id 19so10959679pfo.3 for <ovs-dev@openvswitch.org>; Tue, 07 Feb 2017 22:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=aTQtQwCwecStWNIdlZPn8pI5A3wn4ODZo9+Ab1jQMt8=; b=dT9UdNRXe33rMrj2dGZ2U1exhgod0+QKqNwiXt9zWkggQRT4MyZf1tGjTRIfVDRCnw NevD4XDZQ3/JS8AdmmNLSaOgjSXKKPjlzgfovYMeJCBR519kRnejx3lMtWIwRK93mQKd 3AwD4C1fdP8Dnk732t7fAcjGPZPEtySEAnWLqSl8Y8B6bNEvskR2TNSCgAY/aPTBHdo2 N1T9crPpgyJBA0DsYtNkEkfwy+ySUwGI6dI36bIdeTmbRqQsfqmDpI9vTon04oOyJ/Ws Y2fk5YGn7g8dYI3mr4JzSr0boD7G2kvmMvUF8WvN5FHD/5c6wWuR1LR13XDSSW8WLFiK BXjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=aTQtQwCwecStWNIdlZPn8pI5A3wn4ODZo9+Ab1jQMt8=; b=cjOCOJgOzPVb+6zmY/pWhmGZGjGGnH+aJYuDHTU2YfIgUdYl6D5HXWQP2D+bNM9jKZ GTaGUIH6BI2KVkCS6y08r5nsi64aMOSM8VJh7vfmhmusgIHGw4YmLtI0Ny/MMn/5Ro4B +hQv+nH9Q4bbXpWOIjum4/HJrr80KZZbXoUNCtZcaQbKUr8lnrmtjrC7BfAo0fwZWdq5 2sRu8QUpsUzKUh+W/95URb54RHNMISsFVo5d3LRQ8wJJLvNEOTH0/PWbcmLhkUyrcP3G GledJH9EyZ1iFsJiYRR3e7uN8m1gft9cajLLcHrUKSOckizpVQueW+k0X2fPZf++EkKc KfTQ== X-Gm-Message-State: AIkVDXKH95bfcPBoxP+29WVIWmcv4rD2Rg4HjLyzMgo4y5i8VBoByFhbV/h7VNEhNeAW3w== X-Received: by 10.99.123.68 with SMTP id k4mr25295426pgn.101.1486536083238; Tue, 07 Feb 2017 22:41:23 -0800 (PST) Received: from prmh-nsx-perf-server139.eng.vmware.com ([208.91.1.34]) by smtp.gmail.com with ESMTPSA id 19sm16564586pft.46.2017.02.07.22.41.22 for <ovs-dev@openvswitch.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Feb 2017 22:41:22 -0800 (PST) From: William Tu <u9012063@gmail.com> To: ovs-dev@openvswitch.org Date: Tue, 7 Feb 2017 22:41:10 -0800 Message-Id: <1486536071-14280-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 1/2] ovs-router: fix memory leak reported by valgrind. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org |
diff --git a/lib/ovs-router.c b/lib/ovs-router.c index d98de20..53fb834 100644 --- a/lib/ovs-router.c +++ b/lib/ovs-router.c @@ -280,6 +280,7 @@ rt_entry_delete(uint32_t mark, uint8_t priority, res = __rt_entry_delete(cr); ovs_mutex_unlock(&mutex); } + minimatch_destroy(CONST_CAST(struct minimatch *, &rule.match)); return res; }
Valgrind testcase 772: appctl - route/lookup6 reports the following definitely lost: xmalloc (util.c:112) miniflow_alloc (flow.c:2500) minimatch_init (match.c:1387) rt_entry_delete (ovs-router.c:274) ovs_router_del (ovs-router.c:384) process_command (unixctl.c:313) Signed-off-by: William Tu <u9012063@gmail.com> --- lib/ovs-router.c | 1 + 1 file changed, 1 insertion(+)