| Message ID | 1484571399-53860-1-git-send-email-nic@opencloud.tech |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Jan 16, 2017 at 04:56:39AM -0800, nickcooper-zhangtonghao wrote: > Signed-off-by: nickcooper-zhangtonghao <nic@opencloud.tech> > --- > lib/dpif-netdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c > index 08167b5..3901129 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -4258,7 +4258,6 @@ fast_path_processing(struct dp_netdev_pmd_thread *pmd, > ofpbuf_uninit(&actions); > ofpbuf_uninit(&put_actions); > fat_rwlock_unlock(&dp->upcall_rwlock); > - dp_netdev_count_packet(pmd, DP_STAT_LOST, lost_cnt); > } else if (OVS_UNLIKELY(any_miss)) { > for (i = 0; i < cnt; i++) { > if (OVS_UNLIKELY(!rules[i])) { Acked-by: Ben Pfaff <blp@ovn.org> I believe that this also should be tagged: CC: Daniele Di Proietto <diproiettod@vmware.com> Fixes: 8aaa125dab66 ("dpif-netdev: Share emc and fast path output batches.") Since this dates to May 2015 and DPDK isn't really my area, I'll leave this to Daniele for final application.
On 16/01/2017 09:31, "Ben Pfaff" <blp@ovn.org> wrote: >On Mon, Jan 16, 2017 at 04:56:39AM -0800, nickcooper-zhangtonghao wrote: >> Signed-off-by: nickcooper-zhangtonghao <nic@opencloud.tech> >> --- >> lib/dpif-netdev.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c >> index 08167b5..3901129 100644 >> --- a/lib/dpif-netdev.c >> +++ b/lib/dpif-netdev.c >> @@ -4258,7 +4258,6 @@ fast_path_processing(struct dp_netdev_pmd_thread *pmd, >> ofpbuf_uninit(&actions); >> ofpbuf_uninit(&put_actions); >> fat_rwlock_unlock(&dp->upcall_rwlock); >> - dp_netdev_count_packet(pmd, DP_STAT_LOST, lost_cnt); >> } else if (OVS_UNLIKELY(any_miss)) { >> for (i = 0; i < cnt; i++) { >> if (OVS_UNLIKELY(!rules[i])) { > >Acked-by: Ben Pfaff <blp@ovn.org> > >I believe that this also should be tagged: > >CC: Daniele Di Proietto <diproiettod@vmware.com> >Fixes: 8aaa125dab66 ("dpif-netdev: Share emc and fast path output batches.") > >Since this dates to May 2015 and DPDK isn't really my area, I'll leave >this to Daniele for final application. LGTM as well, I added the tags and applied this to master, branch-2.6 and branch-2.5 Thanks!
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 08167b5..3901129 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4258,7 +4258,6 @@ fast_path_processing(struct dp_netdev_pmd_thread *pmd, ofpbuf_uninit(&actions); ofpbuf_uninit(&put_actions); fat_rwlock_unlock(&dp->upcall_rwlock); - dp_netdev_count_packet(pmd, DP_STAT_LOST, lost_cnt); } else if (OVS_UNLIKELY(any_miss)) { for (i = 0; i < cnt; i++) { if (OVS_UNLIKELY(!rules[i])) {
Signed-off-by: nickcooper-zhangtonghao <nic@opencloud.tech> --- lib/dpif-netdev.c | 1 - 1 file changed, 1 deletion(-)