From patchwork Fri Sep 30 07:00:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 676890 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3slj5S3bvZz9s2G for ; Fri, 30 Sep 2016 17:01:00 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id B621910761; Fri, 30 Sep 2016 00:00:59 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id BBDFB10760 for ; Fri, 30 Sep 2016 00:00:58 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id 1FE261627EC for ; Fri, 30 Sep 2016 01:00:58 -0600 (MDT) X-ASG-Debug-ID: 1475218856-0b323776e7ad330001-byXFYA Received: from mx3-pf1.cudamail.com ([192.168.14.2]) by bar6.cudamail.com with ESMTP id WpeljeRVZBJwTlje (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 30 Sep 2016 01:00:56 -0600 (MDT) X-Barracuda-Envelope-From: i.maximets@samsung.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.2 Received: from unknown (HELO mailout4.w1.samsung.com) (210.118.77.14) by mx3-pf1.cudamail.com with ESMTPS (DHE-RSA-AES128-SHA encrypted); 30 Sep 2016 07:00:55 -0000 Received-SPF: none (mx3-pf1.cudamail.com: domain at samsung.com does not designate permitted sender hosts) X-Barracuda-Apparent-Source-IP: 210.118.77.14 X-Barracuda-RBL-IP: 210.118.77.14 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OEB00LWY25EML30@mailout4.w1.samsung.com> for dev@openvswitch.org; Fri, 30 Sep 2016 08:00:50 +0100 (BST) Received: from eusmges3.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20160930070049eucas1p238be5544af6acc88fe6b085d3a238e47~5B7pcx3LK1420314203eucas1p2r; Fri, 30 Sep 2016 07:00:49 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3.samsung.com (EUCPMTA) with SMTP id E8.F7.11330.1AD0EE75; Fri, 30 Sep 2016 08:00:49 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20160930070049eucas1p16398510273d865678cb6a4c1cc915c52~5B7ou6qGF0189801898eucas1p1T; Fri, 30 Sep 2016 07:00:49 +0000 (GMT) X-AuditID: cbfec7f2-f79556d000002c42-04-57ee0da1110d Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 70.1D.10494.67D0EE75; Fri, 30 Sep 2016 08:00:06 +0100 (BST) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OEB00AB8251WS10@eusync1.samsung.com>; Fri, 30 Sep 2016 08:00:48 +0100 (BST) X-CudaMail-Envelope-Sender: i.maximets@samsung.com From: Ilya Maximets To: dev@openvswitch.org, Daniele Di Proietto , Ben Pfaff X-CudaMail-MID: CM-V1-929000524 X-CudaMail-DTE: 093016 X-CudaMail-Originating-IP: 210.118.77.14 Date: Fri, 30 Sep 2016 10:00:34 +0300 X-ASG-Orig-Subj: [##CM-V1-929000524##][PATCH 1/2] CodingStyle.md: Clarify limit for line length. Message-id: <1475218835-7867-2-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 In-reply-to: <1475218835-7867-1-git-send-email-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsWy7djPc7oLed+FGzyfqmXxanIDo8XR03uY LV5232O3mPb5NrvFlfaf7BYrbpxitJg8W8qB3WPxnpdMHs9u/mf0eH6th8Wjb8sqRo9389+y BbBGcdmkpOZklqUW6dslcGU0zTnBXDCPs+JqzyXWBsb97F2MnBwSAiYSD/fOY4SwxSQu3FvP 1sXIxSEksJRR4tPtrUwQzmdGiRUrJsB1PLjWwQqRWMYosfXUXRYIp5lJonX+ImaQKjYBHYlT q4+AzRURSJB4cPEZWBEzSMe3aV9ZQRLCAs4Sk/uegtksAqoSs18+AWrg4OAVcJVYvMsQYpuc xM1znWAzOQXcJJ5ev8kIMkdC4D2bxJk1m9hA6iUEZCU2HWCGqHeRuLDkONQ/whKvjm+BulpG 4vLkbhYIu1pi4tY2dog5LYwSCyf+YIVI2EucunmVCcRmFuCTmLRtOjPEfF6JjjYhiBIPifV/ fjFBhB0lvq+Rg/h9JqPE99/X2CYwyixgZFjFKJJaWpybnlpsrFecmFtcmpeul5yfu4kRGMGn /x3/tIPx6wmrQ4wCHIxKPLwCym/DhVgTy4orcw8xSnAwK4nw+nO/CxfiTUmsrEotyo8vKs1J LT7EKM3BoiTOu2fBlXAhgfTEktTs1NSC1CKYLBMHp1QDozRbY1zBww0SpduXFAZ8fZj86c7e QzG/u6ybUt9o9rwIeulntsmGdctcptaqHRdUbNuYAz6LeZpfFu5azfQzq+14yEMD51ez1zmv sZF9uvgJv5x4zPPMZYIGJ1uWM3GWz2vwqfBY/Pr21R/H+Dq7Jk/6Z2DUffbAqR3MJaFhwsEb N0+SzGruVmIpzkg01GIuKk4EAKUzX47cAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsVy+t/xy7plvO/CDRZcl7N4NbmB0eLo6T3M Fi+777FbTPt8m93iSvtPdosVN04xWkyeLeXA7rF4z0smj2c3/zN6PL/Ww+LRt2UVo8e7+W/Z Alij3GwyUhNTUosUUvOS81My89JtlUJD3HQtlBTyEnNTbZUidH1DgpQUyhJzSoE8IwM04OAc 4B6spG+X4JbRNOcEc8E8zoqrPZdYGxj3s3cxcnJICJhIPLjWwQphi0lcuLeerYuRi0NIYAmj xMPODVBOK5PEjJ0vmECq2AR0JE6tPsIIYosIJEis67vFCFLELLCCUaJ3+U+wUcICzhKT+56C 2SwCqhKzXz4BKuLg4BVwlVi8yxBim5zEzXOdzCA2p4CbxNPrN8FmCgGVrFqxm2UCI+8CRoZV jCKppcW56bnFRnrFibnFpXnpesn5uZsYgcG87djPLTsYu94FH2IU4GBU4uEVUH4bLsSaWFZc mXuIUYKDWUmE15/7XbgQb0piZVVqUX58UWlOavEhRlOgmyYyS4km5wMjLa8k3tDE0NzS0MjY wsLcyEhJnHfqhyvhQgLpiSWp2ampBalFMH1MHJxSDYx+Xr1feJdW5xUUW7+ZZnj9m+ejy++P nNmwTejuHlMuEZZnMtHeN77YHN1ROetf8Za4qHClnl3B1Ts3zjw+n99wkSm/sG9+SMKDsKSu hGjnyB3aX9SZxfhWiMXZ9q18xGctmhznpJT3QnQi663OjAzBd78tzat1UlQu9O45x3XlrfU2 1dufW5VYijMSDbWYi4oTAUxnmhR8AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20160930070049eucas1p16398510273d865678cb6a4c1cc915c52 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G+yCvOyEseyghOyekBtFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20160930070049eucas1p16398510273d865678cb6a4c1cc915c52 X-RootMTR: 20160930070049eucas1p16398510273d865678cb6a4c1cc915c52 References: <1475218835-7867-1-git-send-email-i.maximets@samsung.com> X-GBUdb-Analysis: 0, 210.118.77.14, Ugly c=0 p=0 Source New X-MessageSniffer-Rules: 0-0-0-7508-c X-Barracuda-Connect: UNKNOWN[192.168.14.2] X-Barracuda-Start-Time: 1475218856 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-ASG-Whitelist: EmailCat (corporate) Cc: Ilya Maximets , Dyasly Sergey Subject: [ovs-dev] [PATCH 1/2] CodingStyle.md: Clarify limit for line length. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" People in OVS again and again tries to break log messages in parts. This breaks ability to find this lines in code while debugging. It's required to document this thing directly in CodingStyle.md to avoid such situations in the future. Text actually ported from the Linux kernel coding style. Signed-off-by: Ilya Maximets Acked-by: Mark Kavanagh --- CodingStyle.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CodingStyle.md b/CodingStyle.md index 0a441e0..a27ff31 100644 --- a/CodingStyle.md +++ b/CodingStyle.md @@ -16,7 +16,11 @@ The following GNU indent options approximate this style: ## BASICS - Limit lines to 79 characters. + Limit lines to 79 characters. Statements longer than 79 characters should +be broken into sensible chunks, unless exceeding 79 characters significantly +increases readability and does not hide information. However, never break +user-visible strings such as VLOG messages, because that breaks the ability to +grep for them. Use form feeds (control+L) to divide long source files into logical pieces. A form feed should appear as the only character on a line.