diff mbox

[ovs-dev,v2] datapath-windows: add assert in OvsHashFlow()

Message ID 1472712309-32792-1-git-send-email-nithin@vmware.com
State Accepted
Headers show

Commit Message

Nithin Raju Sept. 1, 2016, 6:45 a.m. UTC 
Signed-off-by: Nithin Raju <nithin@vmware.com>
---
 datapath-windows/ovsext/Flow.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alin Serdean Sept. 1, 2016, 11:41 a.m. UTC | #1 
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>



> -----Original Message-----

> From: dev [mailto:dev-bounces@openvswitch.org] On Behalf Of Nithin Raju

> Sent: Thursday, September 1, 2016 9:45 AM

> To: dev@openvswitch.org

> Subject: [ovs-dev] [PATCH v2] datapath-windows: add assert in

> OvsHashFlow()

> 

> Signed-off-by: Nithin Raju <nithin@vmware.com>

> ---

>  datapath-windows/ovsext/Flow.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/datapath-windows/ovsext/Flow.c b/datapath-

> windows/ovsext/Flow.c index 439fb28..2e8b42b 100644

> --- a/datapath-windows/ovsext/Flow.c

> +++ b/datapath-windows/ovsext/Flow.c

> @@ -2595,6 +2595,7 @@ OvsHashFlow(const OvsFlowKey *key)

>      UINT8 *start;

> 

>      ASSERT(key->tunKey.dst || offset == sizeof(OvsIPv4TunnelKey));

> +    ASSERT(!key->tunKey.dst || offset ==

> + OvsGetFlowL2Offset(&key->tunKey));

>      start = (UINT8 *)key + offset;

>      return OvsJhashBytes(start, size, 0);  }

> --

> 2.6.2

> 

> _______________________________________________

> dev mailing list

> dev@openvswitch.org

> http://openvswitch.org/mailman/listinfo/dev
Gurucharan Shetty Sept. 1, 2016, 8:47 p.m. UTC | #2 
On 31 August 2016 at 23:45, Nithin Raju <nithin@vmware.com> wrote:

> Signed-off-by: Nithin Raju <nithin@vmware.com>
>
Applied.


> ---
>  datapath-windows/ovsext/Flow.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/
> Flow.c
> index 439fb28..2e8b42b 100644
> --- a/datapath-windows/ovsext/Flow.c
> +++ b/datapath-windows/ovsext/Flow.c
> @@ -2595,6 +2595,7 @@ OvsHashFlow(const OvsFlowKey *key)
>      UINT8 *start;
>
>      ASSERT(key->tunKey.dst || offset == sizeof(OvsIPv4TunnelKey));
> +    ASSERT(!key->tunKey.dst || offset == OvsGetFlowL2Offset(&key->
> tunKey));
>      start = (UINT8 *)key + offset;
>      return OvsJhashBytes(start, size, 0);
>  }
> --
> 2.6.2
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
diff mbox

Patch

diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index 439fb28..2e8b42b 100644
--- a/datapath-windows/ovsext/Flow.c
+++ b/datapath-windows/ovsext/Flow.c
@@ -2595,6 +2595,7 @@  OvsHashFlow(const OvsFlowKey *key)
     UINT8 *start;
 
     ASSERT(key->tunKey.dst || offset == sizeof(OvsIPv4TunnelKey));
+    ASSERT(!key->tunKey.dst || offset == OvsGetFlowL2Offset(&key->tunKey));
     start = (UINT8 *)key + offset;
     return OvsJhashBytes(start, size, 0);
 }