| Message ID | 1472558417-2016-3-git-send-email-pboca@cloudbasesolutions.com |
|---|---|
| State | Accepted |
| Delegated to: | Guru Shetty |
| Headers | show |
On 30 August 2016 at 05:00, Paul Boca <pboca@cloudbasesolutions.com> wrote: > If the python script is killed with `kill` command, the atexit > handler doesn't gets executed on Windows. > The kill of the process is done using NtTerminateProcess which > doesn't sends a signal to the process itself, if just terminates the > process > from kernel mode. > > Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com> > Instead of skipping the test, why not just skip the line that tests for pid after the process is killed. I imagine that the test is still useful in other respects, like whether detach works fine? > --- > V2: Initial commit > --- > tests/daemon-py.at | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/daemon-py.at b/tests/daemon-py.at > index 96dea07..11833c8 100644 > --- a/tests/daemon-py.at > +++ b/tests/daemon-py.at > @@ -126,6 +126,8 @@ DAEMON_MONITOR_RESTART_PYN([Python3], > [$HAVE_PYTHON3], [$PYTHON3]) > m4_define([DAEMON_DETACH_PYN], > [AT_SETUP([daemon --detach - $1]) > AT_SKIP_IF([test $2 = no]) > + # Skip this test for Windows, the pid file not removed if the daemon > is killed > + AT_SKIP_IF([test "$IS_WIN32" = "yes"]) > AT_CAPTURE_FILE([pid]) > # Start the daemon and make sure that the pidfile exists immediately. > # We don't wait for the pidfile to get created because the daemon is > -- > 2.7.2.windows.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
diff --git a/tests/daemon-py.at b/tests/daemon-py.at index 96dea07..11833c8 100644 --- a/tests/daemon-py.at +++ b/tests/daemon-py.at @@ -126,6 +126,8 @@ DAEMON_MONITOR_RESTART_PYN([Python3], [$HAVE_PYTHON3], [$PYTHON3]) m4_define([DAEMON_DETACH_PYN], [AT_SETUP([daemon --detach - $1]) AT_SKIP_IF([test $2 = no]) + # Skip this test for Windows, the pid file not removed if the daemon is killed + AT_SKIP_IF([test "$IS_WIN32" = "yes"]) AT_CAPTURE_FILE([pid]) # Start the daemon and make sure that the pidfile exists immediately. # We don't wait for the pidfile to get created because the daemon is
If the python script is killed with `kill` command, the atexit handler doesn't gets executed on Windows. The kill of the process is done using NtTerminateProcess which doesn't sends a signal to the process itself, if just terminates the process from kernel mode. Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com> --- V2: Initial commit --- tests/daemon-py.at | 2 ++ 1 file changed, 2 insertions(+)