From patchwork Mon Aug 8 15:50:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Kavanagh X-Patchwork-Id: 656825 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3s7MMQ3K5Rz9syB for ; Tue, 9 Aug 2016 01:50:58 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 0924310922; Mon, 8 Aug 2016 08:50:33 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 5210510914 for ; Mon, 8 Aug 2016 08:50:31 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id DEE9A162611 for ; Mon, 8 Aug 2016 09:50:30 -0600 (MDT) X-ASG-Debug-ID: 1470671429-0b323721d8489b40001-byXFYA Received: from mx1-pf2.cudamail.com ([192.168.24.2]) by bar6.cudamail.com with ESMTP id 4HYBDoYx161HuWwV (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 08 Aug 2016 09:50:30 -0600 (MDT) X-Barracuda-Envelope-From: mark.b.kavanagh@intel.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.2 Received: from unknown (HELO mga03.intel.com) (134.134.136.65) by mx1-pf2.cudamail.com with SMTP; 8 Aug 2016 15:50:29 -0000 Received-SPF: pass (mx1-pf2.cudamail.com: SPF record at intel.com designates 134.134.136.65 as permitted sender) X-Barracuda-Apparent-Source-IP: 134.134.136.65 X-Barracuda-RBL-IP: 134.134.136.65 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 08 Aug 2016 08:50:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,490,1464678000"; d="scan'208";a="861734211" Received: from silpixa00380299.ir.intel.com ([10.237.222.17]) by orsmga003.jf.intel.com with ESMTP; 08 Aug 2016 08:50:28 -0700 X-CudaMail-Envelope-Sender: mark.b.kavanagh@intel.com From: Mark Kavanagh To: dev@openvswitch.org, diproiettod@vmware.com X-CudaMail-MID: CM-E2-807032207 X-CudaMail-DTE: 080816 X-CudaMail-Originating-IP: 134.134.136.65 Date: Mon, 8 Aug 2016 16:50:18 +0100 X-ASG-Orig-Subj: [##CM-E2-807032207##][ovs-dev][PATCH V4 6/7] netdev: Make netdev_set_mtu() netdev parameter non-const. Message-Id: <1470671419-178796-6-git-send-email-mark.b.kavanagh@intel.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1470671419-178796-1-git-send-email-mark.b.kavanagh@intel.com> References: <1470671419-178796-1-git-send-email-mark.b.kavanagh@intel.com> X-GBUdb-Analysis: 0, 134.134.136.65, Ugly c=0.279065 p=-0.0666667 Source Normal X-MessageSniffer-Rules: 0-0-0-7420-c X-Barracuda-Connect: UNKNOWN[192.168.24.2] X-Barracuda-Start-Time: 1470671430 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.60 X-Barracuda-Spam-Status: No, SCORE=0.60 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=BSF_SC5_MJ1963, RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.31842 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS 0.50 BSF_SC5_MJ1963 Custom Rule MJ1963 Cc: i.maximets@samsung.com Subject: [ovs-dev] [PATCH V4 6/7] netdev: Make netdev_set_mtu() netdev parameter non-const. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" From: Daniele Di Proietto Every provider silently drops the const attribute when converting the parameter to the appropriate subclass. Might as well drop the const attribute from the parameter, since this is a "set" function. Signed-off-by: Daniele Di Proietto --- lib/netdev-dummy.c | 2 +- lib/netdev-linux.c | 2 +- lib/netdev-provider.h | 2 +- lib/netdev.c | 2 +- lib/netdev.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index c8f82b7..dec1a8e 100644 --- a/lib/netdev-dummy.c +++ b/lib/netdev-dummy.c @@ -1150,7 +1150,7 @@ netdev_dummy_get_mtu(const struct netdev *netdev, int *mtup) } static int -netdev_dummy_set_mtu(const struct netdev *netdev, int mtu) +netdev_dummy_set_mtu(struct netdev *netdev, int mtu) { struct netdev_dummy *dev = netdev_dummy_cast(netdev); diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 1b5f7c1..20b5cc7 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -1382,7 +1382,7 @@ netdev_linux_get_mtu(const struct netdev *netdev_, int *mtup) * networking ioctl interface. */ static int -netdev_linux_set_mtu(const struct netdev *netdev_, int mtu) +netdev_linux_set_mtu(struct netdev *netdev_, int mtu) { struct netdev_linux *netdev = netdev_linux_cast(netdev_); struct ifreq ifr; diff --git a/lib/netdev-provider.h b/lib/netdev-provider.h index 5bcfeba..cd04ae9 100644 --- a/lib/netdev-provider.h +++ b/lib/netdev-provider.h @@ -389,7 +389,7 @@ struct netdev_class { * If 'netdev' does not have an MTU (e.g. as some tunnels do not), then * this function should return EOPNOTSUPP. This function may be set to * null if it would always return EOPNOTSUPP. */ - int (*set_mtu)(const struct netdev *netdev, int mtu); + int (*set_mtu)(struct netdev *netdev, int mtu); /* Returns the ifindex of 'netdev', if successful, as a positive number. * On failure, returns a negative errno value. diff --git a/lib/netdev.c b/lib/netdev.c index 589d37c..5cf8bbb 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -869,7 +869,7 @@ netdev_get_mtu(const struct netdev *netdev, int *mtup) * MTU (as e.g. some tunnels do not). On other failure, returns a positive * errno value. */ int -netdev_set_mtu(const struct netdev *netdev, int mtu) +netdev_set_mtu(struct netdev *netdev, int mtu) { const struct netdev_class *class = netdev->netdev_class; int error; diff --git a/lib/netdev.h b/lib/netdev.h index dc7ede8..d8ec627 100644 --- a/lib/netdev.h +++ b/lib/netdev.h @@ -132,7 +132,7 @@ const char *netdev_get_name(const struct netdev *); const char *netdev_get_type(const struct netdev *); const char *netdev_get_type_from_name(const char *); int netdev_get_mtu(const struct netdev *, int *mtup); -int netdev_set_mtu(const struct netdev *, int mtu); +int netdev_set_mtu(struct netdev *, int mtu); int netdev_get_ifindex(const struct netdev *); int netdev_set_tx_multiq(struct netdev *, unsigned int n_txq);