From patchwork Mon Aug 8 13:48:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Mestery X-Patchwork-Id: 656719 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3s7Jfb2rN7z9s9x for ; Mon, 8 Aug 2016 23:48:55 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mestery-com.20150623.gappssmtp.com header.i=@mestery-com.20150623.gappssmtp.com header.b=o8076kcA; dkim-atps=neutral Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 99F6E1069C; Mon, 8 Aug 2016 06:48:54 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id E1F0B1069B for ; Mon, 8 Aug 2016 06:48:52 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id 79140161C11 for ; Mon, 8 Aug 2016 07:48:52 -0600 (MDT) X-ASG-Debug-ID: 1470664131-0b323721d8455a00001-byXFYA Received: from mx3-pf2.cudamail.com ([192.168.14.1]) by bar6.cudamail.com with ESMTP id 4Rbujit3nskA47Nc (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 08 Aug 2016 07:48:51 -0600 (MDT) X-Barracuda-Envelope-From: mestery@mestery.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.1 Received: from unknown (HELO mail-io0-f195.google.com) (209.85.223.195) by mx3-pf2.cudamail.com with ESMTPS (AES128-SHA encrypted); 8 Aug 2016 13:48:50 -0000 Received-SPF: neutral (mx3-pf2.cudamail.com: 209.85.223.195 is neither permitted nor denied by SPF record at mestery.com) X-Barracuda-RBL-Trusted-Forwarder: 209.85.223.195 Received: by mail-io0-f195.google.com with SMTP id y34so28760256ioi.3 for ; Mon, 08 Aug 2016 06:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mestery-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=44sqzt3AoXzMY8HIv7HGGfIZPUod/coLxjzpG8BJH4A=; b=o8076kcAWCdAici8WD/tru1gwJVZkjEqF2B0aNZXBZ2pspPmxdFoE+0tLAVFZByUMH 9pM5ns78ofuGlewFQtIendsXlOBC1i7XAwz7Zo1vqJdwHgeIunBz7I0MsDc5YcimP3sP TJZcqGKBumfdYFBpxBIx2nnnYoAzOxBo9P0Yo8wgQp60OEjkAFQHrnpWSsMs/7FHwl4r bE5P978vSzhrHkU+dAxdBF/MucPCFe3gNJExM1WzAvI6QM0mroVRkVgOaktJEdwkcCH+ XtPcITIGhl62uHTkHEUwkxISKDsv4ULhd0gawzct4TYkebQLVJAaTdd6lEtb1+pYS/fq YznA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=44sqzt3AoXzMY8HIv7HGGfIZPUod/coLxjzpG8BJH4A=; b=Frur/xGh3WjlK7tIIJuuzIkAV3rS8uZome+uR1kloGDJWTQIPYMbKC0sEGYXvM/Tqs rr27MEh6rz/643qFhKTgh0RsWzJD1uGj/03q5J9VnArUrYbTSWLghN2yYNosKgYmtWpk riI9kVT0OKCPPz3tjz+iTJIK/zwP70Q/DLSYuuo/ryJs0rT8HAbAO9U9JG4WiQ2DATw0 mA7iJR8aIcB7nZhawcVWxbf6OOz6IhQoCB08bBFwk6d4faAd931AjSEmrbb1x6SoCojG lxmpk2TfftMjM/9Fle2VF/cym7YoZHjNzdiK5uTg91fxC+0qq8WfftZ1tVb9SDcZCdVM SdRg== X-Gm-Message-State: AEkoouvtjwJvHTIbvAKyDmZuHQ2VrMq04DxRwVLbPoDSqUwT2OXEkvBxicTUzCbbeu/uZQ== X-Received: by 10.107.185.133 with SMTP id j127mr94898925iof.32.1470664129895; Mon, 08 Aug 2016 06:48:49 -0700 (PDT) Received: from localhost.localdomain (c-66-41-221-47.hsd1.mn.comcast.net. [66.41.221.47]) by smtp.gmail.com with ESMTPSA id 74sm10171381itu.18.2016.08.08.06.48.48 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 08 Aug 2016 06:48:48 -0700 (PDT) X-CudaMail-Envelope-Sender: mestery@mestery.com X-Barracuda-Apparent-Source-IP: 66.41.221.47 From: Kyle Mestery To: dev@openvswitch.org X-CudaMail-MID: CM-V2-807011554 X-CudaMail-DTE: 080816 X-CudaMail-Originating-IP: 209.85.223.195 Date: Mon, 8 Aug 2016 08:48:40 -0500 X-ASG-Orig-Subj: [##CM-V2-807011554##][PATCH] ovs-vsctl: Change log level of vsctl_parent_process_info Message-Id: <1470664120-56696-1-git-send-email-mestery@mestery.com> X-Mailer: git-send-email 2.7.4 (Apple Git-66) X-GBUdb-Analysis: 0, 209.85.223.195, Ugly c=0.36638 p=-0.0857143 Source Normal X-MessageSniffer-Rules: 0-0-0-9613-c X-Barracuda-Connect: UNKNOWN[192.168.14.1] X-Barracuda-Start-Time: 1470664131 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.60 X-Barracuda-Spam-Status: No, SCORE=0.60 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=BSF_SC5_MJ1963, DKIM_SIGNED, RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.31839 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 DKIM_SIGNED Domain Keys Identified Mail: message has a signature 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS 0.50 BSF_SC5_MJ1963 Custom Rule MJ1963 Subject: [ovs-dev] [PATCH] ovs-vsctl: Change log level of vsctl_parent_process_info X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" While running the ovn-scale-test [1] port-binding tests [2], I notice a continual stream of messages such as this: 2016-08-04 13:05:28.705 547 INFO rally_ovs.plugins.ovs.scenarios.ovn [-] bind lport_0996bf_cikzNO to sandbox-172.16.200.24 on ovn-farm-node-uat-dal09-compute-325 2016-08-04 13:05:28.712 547 INFO paramiko.transport [-] Connected (version 2.0, client OpenSSH_6.6.1p1) 2016-08-04 13:05:28.805 547 INFO paramiko.transport [-] Authentication (publickey) successful! 2016-08-04T13:05:28Z|00002|vsctl|WARN|/proc/0/cmdline: open failed (No such file or directory) 2016-08-04T13:05:29Z|00002|vsctl|WARN|/proc/0/cmdline: open failed (No such file or directory) 2016-08-04 13:05:29.042 547 INFO rally_ovs.plugins.ovs.scenarios.ovn [-] bind lport_0996bf_tvovcK to sandbox-172.16.200.24 on ovn-farm-node-uat-dal09-compute-325 2016-08-04T13:05:29Z|00002|vsctl|WARN|/proc/0/cmdline: open failed (No such file or directory) 2016-08-04T13:05:29Z|00002|vsctl|WARN|/proc/0/cmdline: open failed (No such file or directory) 2016-08-04 13:05:29.285 547 INFO rally_ovs.plugins.ovs.scenarios.ovn [-] bind lport_0996bf_HwG7AK to sandbox-172.16.200.24 on ovn-farm-node-uat-dal09-compute-325 2016-08-04T13:05:29Z|00002|vsctl|WARN|/proc/0/cmdline: open failed (No such file or directory) 2016-08-04T13:05:29Z|00002|vsctl|WARN|/proc/0/cmdline: open failed (No such file or directory) 2016-08-04 13:05:29.505 547 INFO rally_ovs.plugins.ovs.scenarios.ovn [-] bind lport_0996bf_Lqbv92 to sandbox-172.16.200.24 on ovn-farm-node-uat-dal09-compute-325 2016-08-04T13:05:29Z|00002|vsctl|WARN|/proc/0/cmdline: open failed (No such file or directory) 2016-08-04T13:05:29Z|00002|vsctl|WARN|/proc/0/cmdline: open failed (No such file or directory) 2016-08-04 13:05:29.724 547 INFO rally_ovs.plugins.ovs.scenarios.ovn [-] bind lport_0996bf_6f8uQW to sandbox-172.16.200.24 on ovn-farm-node-uat-dal09-compute-325 2016-08-04T13:05:29Z|00002|vsctl|WARN|/proc/0/cmdline: open failed (No such file or directory) 2016-08-04T13:05:29Z|00002|vsctl|WARN|/proc/0/cmdline: open failed (No such file or directory) 2016-08-04 13:05:29.944 547 INFO rally_ovs.plugins.ovs.scenarios.ovn [-] bind lport_0996bf_nKl2XF to sandbox-172.16.200.24 on ovn-farm-node-uat-dal09-compute-325 Tracing these down, this is due to the check in vsctl_parent_process_info(), which is verifying if the parent process can be opened. Since ovn-scale-test runs sandboxes in containers, and these are run as root, there is no /proc/0 in the container. Thus, the check fails, and the error message is printed out. It's unclear what value this log message provides, so removing it clears up this problem and is probably the best option. [1] https://github.com/openvswitch/ovn-scale-test [2] https://github.com/openvswitch/ovn-scale-test/blob/master/rally_ovs/plugins/ovs/scenarios/ovn.py#L255 Signed-off-by: Kyle Mestery --- V1->V2 Remove log message instead of changing the level from WARN to DBG. --- utilities/ovs-vsctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index 722dcd9..4e4ad75 100644 --- a/utilities/ovs-vsctl.c +++ b/utilities/ovs-vsctl.c @@ -2483,7 +2483,6 @@ vsctl_parent_process_info(void) f = fopen(procfile, "r"); if (!f) { - VLOG_WARN("%s: open failed (%s)", procfile, ovs_strerror(errno)); free(procfile); return NULL; }