From patchwork Fri Aug 5 14:36:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Kavanagh X-Patchwork-Id: 656219 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3s5Tsg0JNBz9t0F for ; Sat, 6 Aug 2016 00:37:10 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 3BC9C10CDF; Fri, 5 Aug 2016 07:36:36 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e4.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id C5C0210CD4 for ; Fri, 5 Aug 2016 07:36:34 -0700 (PDT) Received: from bar5.cudamail.com (unknown [192.168.21.12]) by mx1e4.cudamail.com (Postfix) with ESMTPS id 57F141E062B for ; Fri, 5 Aug 2016 08:36:34 -0600 (MDT) X-ASG-Debug-ID: 1470407793-09eadd5e83130f10001-byXFYA Received: from mx1-pf1.cudamail.com ([192.168.24.1]) by bar5.cudamail.com with ESMTP id VpuhNMHw916RH5FO (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 05 Aug 2016 08:36:34 -0600 (MDT) X-Barracuda-Envelope-From: mark.b.kavanagh@intel.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.1 Received: from unknown (HELO mga09.intel.com) (134.134.136.24) by mx1-pf1.cudamail.com with SMTP; 5 Aug 2016 14:36:33 -0000 Received-SPF: pass (mx1-pf1.cudamail.com: SPF record at intel.com designates 134.134.136.24 as permitted sender) X-Barracuda-Apparent-Source-IP: 134.134.136.24 X-Barracuda-RBL-IP: 134.134.136.24 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 05 Aug 2016 07:36:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,474,1464678000"; d="scan'208";a="151178322" Received: from silpixa00380299.ir.intel.com ([10.237.222.17]) by fmsmga004.fm.intel.com with ESMTP; 05 Aug 2016 07:36:32 -0700 X-CudaMail-Envelope-Sender: mark.b.kavanagh@intel.com From: Mark Kavanagh To: dev@openvswitch.org, diproiettod@vmware.com X-CudaMail-MID: CM-E1-804023234 X-CudaMail-DTE: 080516 X-CudaMail-Originating-IP: 134.134.136.24 Date: Fri, 5 Aug 2016 15:36:23 +0100 X-ASG-Orig-Subj: [##CM-E1-804023234##][PATCH 6/7] netdev: Make netdev_set_mtu() netdev parameter non-const. Message-Id: <1470407784-158041-6-git-send-email-mark.b.kavanagh@intel.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1470407784-158041-1-git-send-email-mark.b.kavanagh@intel.com> References: <1470407784-158041-1-git-send-email-mark.b.kavanagh@intel.com> X-Barracuda-Connect: UNKNOWN[192.168.24.1] X-Barracuda-Start-Time: 1470407794 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-ASG-Whitelist: EmailCat (corporate) Cc: i.maximets@samsung.com Subject: [ovs-dev] [PATCH 6/7] netdev: Make netdev_set_mtu() netdev parameter non-const. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" From: Daniele Di Proietto Every provider silently drops the const attribute when converting the parameter to the appropriate subclass. Might as well drop the const attribute from the parameter, since this is a "set" function. Signed-off-by: Daniele Di Proietto --- v2->v1: add missing 'Signed-off-by' field in commit message. lib/netdev-dummy.c | 2 +- lib/netdev-linux.c | 2 +- lib/netdev-provider.h | 2 +- lib/netdev.c | 2 +- lib/netdev.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index c8f82b7..dec1a8e 100644 --- a/lib/netdev-dummy.c +++ b/lib/netdev-dummy.c @@ -1150,7 +1150,7 @@ netdev_dummy_get_mtu(const struct netdev *netdev, int *mtup) } static int -netdev_dummy_set_mtu(const struct netdev *netdev, int mtu) +netdev_dummy_set_mtu(struct netdev *netdev, int mtu) { struct netdev_dummy *dev = netdev_dummy_cast(netdev); diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 1b5f7c1..20b5cc7 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -1382,7 +1382,7 @@ netdev_linux_get_mtu(const struct netdev *netdev_, int *mtup) * networking ioctl interface. */ static int -netdev_linux_set_mtu(const struct netdev *netdev_, int mtu) +netdev_linux_set_mtu(struct netdev *netdev_, int mtu) { struct netdev_linux *netdev = netdev_linux_cast(netdev_); struct ifreq ifr; diff --git a/lib/netdev-provider.h b/lib/netdev-provider.h index 5bcfeba..cd04ae9 100644 --- a/lib/netdev-provider.h +++ b/lib/netdev-provider.h @@ -389,7 +389,7 @@ struct netdev_class { * If 'netdev' does not have an MTU (e.g. as some tunnels do not), then * this function should return EOPNOTSUPP. This function may be set to * null if it would always return EOPNOTSUPP. */ - int (*set_mtu)(const struct netdev *netdev, int mtu); + int (*set_mtu)(struct netdev *netdev, int mtu); /* Returns the ifindex of 'netdev', if successful, as a positive number. * On failure, returns a negative errno value. diff --git a/lib/netdev.c b/lib/netdev.c index 589d37c..5cf8bbb 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -869,7 +869,7 @@ netdev_get_mtu(const struct netdev *netdev, int *mtup) * MTU (as e.g. some tunnels do not). On other failure, returns a positive * errno value. */ int -netdev_set_mtu(const struct netdev *netdev, int mtu) +netdev_set_mtu(struct netdev *netdev, int mtu) { const struct netdev_class *class = netdev->netdev_class; int error; diff --git a/lib/netdev.h b/lib/netdev.h index dc7ede8..d8ec627 100644 --- a/lib/netdev.h +++ b/lib/netdev.h @@ -132,7 +132,7 @@ const char *netdev_get_name(const struct netdev *); const char *netdev_get_type(const struct netdev *); const char *netdev_get_type_from_name(const char *); int netdev_get_mtu(const struct netdev *, int *mtup); -int netdev_set_mtu(const struct netdev *, int mtu); +int netdev_set_mtu(struct netdev *, int mtu); int netdev_get_ifindex(const struct netdev *); int netdev_set_tx_multiq(struct netdev *, unsigned int n_txq);