From patchwork Fri Jun 17 19:33:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thadeu Lima de Souza Cascardo X-Patchwork-Id: 637275 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3rWVml63fdz9t26 for ; Sat, 18 Jun 2016 05:33:59 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id E7B9B10AEB; Fri, 17 Jun 2016 12:33:57 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id CCB5E10AEA for ; Fri, 17 Jun 2016 12:33:56 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id 09A87161819 for ; Fri, 17 Jun 2016 13:33:56 -0600 (MDT) X-ASG-Debug-ID: 1466192035-0b323731fc50d10001-byXFYA Received: from mx3-pf1.cudamail.com ([192.168.14.2]) by bar6.cudamail.com with ESMTP id Q4gJR7e1nk0l58tW (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 17 Jun 2016 13:33:55 -0600 (MDT) X-Barracuda-Envelope-From: cascardo@redhat.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.2 Received: from unknown (HELO mx1.redhat.com) (209.132.183.28) by mx3-pf1.cudamail.com with ESMTPS (DHE-RSA-AES256-SHA encrypted); 17 Jun 2016 19:33:54 -0000 Received-SPF: pass (mx3-pf1.cudamail.com: SPF record at _spf1.redhat.com designates 209.132.183.28 as permitted sender) X-Barracuda-Apparent-Source-IP: 209.132.183.28 X-Barracuda-RBL-IP: 209.132.183.28 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F21CA46200 for ; Fri, 17 Jun 2016 19:33:53 +0000 (UTC) Received: from indiana.gru.redhat.com (ovpn-116-66.phx2.redhat.com [10.3.116.66]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5HJXqDK001321; Fri, 17 Jun 2016 15:33:53 -0400 X-CudaMail-Envelope-Sender: cascardo@redhat.com From: Thadeu Lima de Souza Cascardo To: dev@openvswitch.org X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V1-616036656 X-CudaMail-DTE: 061716 X-CudaMail-Originating-IP: 209.132.183.28 Date: Fri, 17 Jun 2016 16:33:23 -0300 X-ASG-Orig-Subj: [##CM-V1-616036656##][PATCH] netlink-notifier: change message to a less scary one Message-Id: <1466192003-23620-1-git-send-email-cascardo@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 17 Jun 2016 19:33:54 +0000 (UTC) X-Barracuda-Connect: UNKNOWN[192.168.14.2] X-Barracuda-Start-Time: 1466192035 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Subject: [ovs-dev] [PATCH] netlink-notifier: change message to a less scary one X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" "received bad netlink message" may be interpreted as a corrupt netlink message. However, the parse functions may return failure when the message contains unexpected attributes or misses non optional attributes. Indicating the message contained "unexpected contents" will avoid some interpretation that there may be some netlink message corruption. Signed-off-by: Thadeu Lima de Souza Cascardo Cc: Aaron Conole --- lib/netlink-notifier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netlink-notifier.c b/lib/netlink-notifier.c index f6d1e4d..0867952 100644 --- a/lib/netlink-notifier.c +++ b/lib/netlink-notifier.c @@ -194,7 +194,7 @@ nln_run(struct nln *nln) if (group != 0) { nln_report(nln, nln->change, group); } else { - VLOG_WARN_RL(&rl, "received bad netlink message"); + VLOG_WARN_RL(&rl, "unexpected netlink message contents"); nln_report(nln, NULL, 0); } ofpbuf_uninit(&buf);