| Message ID | 1464294903-26719-2-git-send-email-cascardo@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, May 26, 2016 at 05:34:58PM -0300, Thadeu Lima de Souza Cascardo wrote: > Do not return failure to parse a route if device has been removed before we are > able to parse the route. That prevents "received bad netlink message" warnings > on the log. > > This can be reproduced by simply removing interfaces. > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> Thanks, applied to master and branch-2.5.
diff --git a/lib/route-table.c b/lib/route-table.c index 2d095dc..d837d98 100644 --- a/lib/route-table.c +++ b/lib/route-table.c @@ -252,7 +252,11 @@ route_table_parse(struct ofpbuf *buf, struct route_table_msg *change) VLOG_DBG_RL(&rl, "Could not find interface name[%u]: %s", rta_oif, ovs_strerror(error)); - return false; + if (error == ENXIO) { + change->relevant = false; + } else { + return false; + } } }
Do not return failure to parse a route if device has been removed before we are able to parse the route. That prevents "received bad netlink message" warnings on the log. This can be reproduced by simply removing interfaces. Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> --- lib/route-table.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)