| Message ID | 1462410066-41547-2-git-send-email-joe@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
Thanks for figuring this out, Joe! Acked-by: Jarno Rajahalme <jarno@ovn.org> > On May 4, 2016, at 6:01 PM, Joe Stringer <joe@ovn.org> wrote: > > Automatic helper assignment in conntrack can trigger an upstream bug > where namespace deletion followed by immediate unload of conntrack > helper modules may cause kernel crashes. Disable automatic helper > assignment within created namespaces to avoid this issue. > > Signed-off-by: Joe Stringer <joe@ovn.org> > --- > tests/system-common-macros.at | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at > index 2c8e2a90cc6d..52ab7ff5652f 100644 > --- a/tests/system-common-macros.at > +++ b/tests/system-common-macros.at > @@ -17,6 +17,7 @@ m4_define([ADD_NAMESPACES], > [DEL_NAMESPACES(ns) > AT_CHECK([ip netns add ns || return 77]) > on_exit 'DEL_NAMESPACES(ns)' > + ip netns exec ns sysctl -w net.netfilter.nf_conntrack_helper=0 > ]) > ] > ) > -- > 2.1.4 >
On 5 May 2016 at 12:54, Jarno Rajahalme <jarno@ovn.org> wrote: > Thanks for figuring this out, Joe! > > Acked-by: Jarno Rajahalme <jarno@ovn.org> No problem, thanks for looking the series over. I applied this to master.
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 2c8e2a90cc6d..52ab7ff5652f 100644 --- a/tests/system-common-macros.at +++ b/tests/system-common-macros.at @@ -17,6 +17,7 @@ m4_define([ADD_NAMESPACES], [DEL_NAMESPACES(ns) AT_CHECK([ip netns add ns || return 77]) on_exit 'DEL_NAMESPACES(ns)' + ip netns exec ns sysctl -w net.netfilter.nf_conntrack_helper=0 ]) ] )
Automatic helper assignment in conntrack can trigger an upstream bug where namespace deletion followed by immediate unload of conntrack helper modules may cause kernel crashes. Disable automatic helper assignment within created namespaces to avoid this issue. Signed-off-by: Joe Stringer <joe@ovn.org> --- tests/system-common-macros.at | 1 + 1 file changed, 1 insertion(+)