| Message ID | 1458825199-2595-3-git-send-email-mchandras@suse.de |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Markos, Currently DPDK 2.2.0 is required to build OVS master, DPDK 2.2.0 still requires setting the CONFIG_RTE_BUILD_COMBINE_LIBS option. I think we need to wait until we move to a new DPDK version to change the documentation. Mauricio V, On Thu, Mar 24, 2016 at 2:13 PM, Markos Chandras <mchandras@suse.de> wrote: > The CONFIG_RTE_BUILD_COMBINE_LIBS has been removed in the DPDK commit > 948fd64befc37 ("mk: replace the combined library with a linker script"). > Moreover, add missing step for creating a configuration file prior to > building the sources. > > Signed-off-by: Markos Chandras <mchandras@suse.de> > --- > INSTALL.DPDK.md | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md > index 9ec8bf6..541278c 100644 > --- a/INSTALL.DPDK.md > +++ b/INSTALL.DPDK.md > @@ -28,12 +28,11 @@ on Debian/Ubuntu) > cd $DPDK_DIR > ``` > > - 2. Update `config/common_linuxapp` so that DPDK generate single lib > file. > - (modification also required for IVSHMEM build) > + 2. Create a suitable configuration. For example: > > - `CONFIG_RTE_BUILD_COMBINE_LIBS=y` > + `make config T=x86_64-native-linuxapp-gcc` > > - Then run `make install` to build and install the library. > + 3. Run `make install` to build and install the library. > For default install without IVSHMEM: > > `make install T=x86_64-native-linuxapp-gcc DESTDIR=install` > -- > 2.7.3 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
On 03/24/2016 02:32 PM, Mauricio Vásquez wrote: > Hi Markos, > > Currently DPDK 2.2.0 is required to build OVS master, DPDK 2.2.0 still > requires setting the CONFIG_RTE_BUILD_COMBINE_LIBS option. > > I think we need to wait until we move to a new DPDK version to change > the documentation. > > Mauricio V, Hi Mauricio, The current master of OVS builds fine with the master branch of DPDK so I thought these two should match. But if that's not the case then I suppose this patch should be rejected or applied later on. Thank you
I am not sure if it is a good idea to match both master branches. What would happen if an OvS version is released before a DPDK one?, we can get in a situation that an OvS version would require an exact point in the tree of DPDK instead of a stable version. On Thu, Mar 24, 2016 at 4:24 PM, Markos Chandras <mchandras@suse.de> wrote: > On 03/24/2016 02:32 PM, Mauricio Vásquez wrote: > > Hi Markos, > > > > Currently DPDK 2.2.0 is required to build OVS master, DPDK 2.2.0 still > > requires setting the CONFIG_RTE_BUILD_COMBINE_LIBS option. > > > > I think we need to wait until we move to a new DPDK version to change > > the documentation. > > > > Mauricio V, > > Hi Mauricio, > > The current master of OVS builds fine with the master branch of DPDK so > I thought these two should match. But if that's not the case then I > suppose this patch should be rejected or applied later on. Thank you > > -- > markos >
diff --git a/INSTALL.DPDK.md b/INSTALL.DPDK.md index 9ec8bf6..541278c 100644 --- a/INSTALL.DPDK.md +++ b/INSTALL.DPDK.md @@ -28,12 +28,11 @@ on Debian/Ubuntu) cd $DPDK_DIR ``` - 2. Update `config/common_linuxapp` so that DPDK generate single lib file. - (modification also required for IVSHMEM build) + 2. Create a suitable configuration. For example: - `CONFIG_RTE_BUILD_COMBINE_LIBS=y` + `make config T=x86_64-native-linuxapp-gcc` - Then run `make install` to build and install the library. + 3. Run `make install` to build and install the library. For default install without IVSHMEM: `make install T=x86_64-native-linuxapp-gcc DESTDIR=install`
The CONFIG_RTE_BUILD_COMBINE_LIBS has been removed in the DPDK commit 948fd64befc37 ("mk: replace the combined library with a linker script"). Moreover, add missing step for creating a configuration file prior to building the sources. Signed-off-by: Markos Chandras <mchandras@suse.de> --- INSTALL.DPDK.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)