| Message ID | 1452810674-32788-1-git-send-email-jesse@kernel.org |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Jan 14, 2016 at 02:31:14PM -0800, Jesse Gross wrote: > The most recent version of the Geneve draft included an option > class assignment for OVN: > https://tools.ietf.org/html/draft-ietf-nvo3-geneve-01 > > As a result, we can stop using the experimental class and switch to > the allocated one (0x0102). > > Signed-off-by: Jesse Gross <jesse@kernel.org> > --- > I plan on applying this to branch-2.5 as well to avoid having a > shipping version of OVN using an unassigned class. Thanks Jesse. Acked-by: Ben Pfaff <blp@ovn.org>
On Thu, Jan 14, 2016 at 2:35 PM, Ben Pfaff <blp@ovn.org> wrote: > On Thu, Jan 14, 2016 at 02:31:14PM -0800, Jesse Gross wrote: >> The most recent version of the Geneve draft included an option >> class assignment for OVN: >> https://tools.ietf.org/html/draft-ietf-nvo3-geneve-01 >> >> As a result, we can stop using the experimental class and switch to >> the allocated one (0x0102). >> >> Signed-off-by: Jesse Gross <jesse@kernel.org> >> --- >> I plan on applying this to branch-2.5 as well to avoid having a >> shipping version of OVN using an unassigned class. > > Thanks Jesse. > > Acked-by: Ben Pfaff <blp@ovn.org> Thanks, applied to master and branch-2.5.
diff --git a/ovn/controller/physical.h b/ovn/controller/physical.h index a06f759..2906937 100644 --- a/ovn/controller/physical.h +++ b/ovn/controller/physical.h @@ -35,10 +35,8 @@ struct simap; /* OVN Geneve option information. * - * These are placeholders until OVS is assigned a Geneve option class. - * * Keep these in sync with the documentation in ovn-architecture(7). */ -#define OVN_GENEVE_CLASS 0xffff /* Geneve experimental class. */ +#define OVN_GENEVE_CLASS 0x0102 /* Assigned Geneve class for OVN. */ #define OVN_GENEVE_TYPE 0 #define OVN_GENEVE_LEN 4 diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml index 318555b..c437b0d 100644 --- a/ovn/ovn-architecture.7.xml +++ b/ovn/ovn-architecture.7.xml @@ -1017,7 +1017,7 @@ <!-- Keep the following in sync with ovn/controller/physical.h. --> OVN transmits the logical ingress and logical egress ports in a TLV with - class 0xffff, type 0, and a 32-bit value encoded as follows, from MSB to + class 0x0102, type 0, and a 32-bit value encoded as follows, from MSB to LSB: </p>
The most recent version of the Geneve draft included an option class assignment for OVN: https://tools.ietf.org/html/draft-ietf-nvo3-geneve-01 As a result, we can stop using the experimental class and switch to the allocated one (0x0102). Signed-off-by: Jesse Gross <jesse@kernel.org> --- I plan on applying this to branch-2.5 as well to avoid having a shipping version of OVN using an unassigned class. --- ovn/controller/physical.h | 4 +--- ovn/ovn-architecture.7.xml | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-)