| Message ID | 1452106178-55876-4-git-send-email-u9012063@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Jan 06, 2016 at 10:49:38AM -0800, William Tu wrote: > Test case 1205: generate and apply diff -- set -- size (ovsdb-data.at:827) > Call stack: > ovsdb_error_valist (ovsdb-error.c:40) > ovsdb_error (ovsdb-error.c:55) > do_diff_data (test-ovsdb.c:427) > ovs_cmdl_run_command (command-line.c:121) > main (test-ovsdb.c:72) > Fix by calling ovsdb_error_destroy() before ovs_fatal() > > Signed-off-by: William Tu <u9012063@gmail.com> Applied, thanks!
diff --git a/tests/test-ovsdb.c b/tests/test-ovsdb.c index 0ce8f9d..dbd51f2 100644 --- a/tests/test-ovsdb.c +++ b/tests/test-ovsdb.c @@ -426,7 +426,9 @@ do_diff_data(struct ovs_cmdl_context *ctx) /* Apply diff to 'old' to create'reincarnation'. */ error = ovsdb_datum_apply_diff(&reincarnation, &old, &diff, &type); if (error) { - ovs_fatal(0, "%s", ovsdb_error_to_string(error)); + char *string = ovsdb_error_to_string(error); + ovsdb_error_destroy(error); + ovs_fatal(0, "%s", string); } /* Test to make sure 'new' equals 'reincarnation'. */
Test case 1205: generate and apply diff -- set -- size (ovsdb-data.at:827) Call stack: ovsdb_error_valist (ovsdb-error.c:40) ovsdb_error (ovsdb-error.c:55) do_diff_data (test-ovsdb.c:427) ovs_cmdl_run_command (command-line.c:121) main (test-ovsdb.c:72) Fix by calling ovsdb_error_destroy() before ovs_fatal() Signed-off-by: William Tu <u9012063@gmail.com> --- tests/test-ovsdb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)