From patchwork Mon Dec 14 23:08:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Zhou X-Patchwork-Id: 556728 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (li376-54.members.linode.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 5A976140180 for ; Tue, 15 Dec 2015 10:08:27 +1100 (AEDT) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 9F471106AD; Mon, 14 Dec 2015 15:08:26 -0800 (PST) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 576A4106A5 for ; Mon, 14 Dec 2015 15:08:25 -0800 (PST) Received: from bar4.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id DA33F16111A for ; Mon, 14 Dec 2015 16:08:24 -0700 (MST) X-ASG-Debug-ID: 1450134504-03dc213161198d90001-byXFYA Received: from mx3-pf3.cudamail.com ([192.168.14.3]) by bar4.cudamail.com with ESMTP id 4YEKw4ra24HfAZDV (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 14 Dec 2015 16:08:24 -0700 (MST) X-Barracuda-Envelope-From: azhou.ovn@gmail.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.3 Received: from unknown (HELO mail-pa0-f51.google.com) (209.85.220.51) by mx3-pf3.cudamail.com with ESMTPS (RC4-SHA encrypted); 14 Dec 2015 23:20:41 -0000 Received-SPF: pass (mx3-pf3.cudamail.com: SPF record at _netblocks.google.com designates 209.85.220.51 as permitted sender) X-Barracuda-RBL-Trusted-Forwarder: 209.85.220.51 Received: by padhk6 with SMTP id hk6so71258247pad.2 for ; Mon, 14 Dec 2015 15:08:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id; bh=XpihNayzy+TyQxLBciYyMZOmxq/FMrYgv3Eh3wilcow=; b=BfrZwrfqoErDQM9910vpTyF9fkSMV8UZGOhmt+pc/9ZqqY5inoTYeH2V6PumR6oMk2 1J+zMEPec5hdwyz0SLTXjN/4vX8cZ9R5HpE8lotxAUaRnsQ9Z2HYetYGCvZTrPDu/sdl jwdAjYfCcXfHY89kUeCRh7CmEJ4EtLRgN58YDeUU7uugh8u6fqypdHZ0P+wqqYSmsucu aN0Zus0pjlDJz5z10KuRv9MluEPsEK18yR+wcGpfXFU6ygptGYth5dwz/Vva0WJyl4P4 w1waDLAcy6rnavct118BjodJfcCg3+qpZba77RUVqVN1w7snBPHSqM13wh+/B/aquQak Y/ug== X-Received: by 10.66.248.74 with SMTP id yk10mr49360969pac.17.1450134503974; Mon, 14 Dec 2015 15:08:23 -0800 (PST) Received: from localhost.localdomain ([208.91.2.3]) by smtp.gmail.com with ESMTPSA id 87sm44561172pfj.23.2015.12.14.15.08.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Dec 2015 15:08:22 -0800 (PST) X-CudaMail-Envelope-Sender: azhou.ovn@gmail.com X-Barracuda-Apparent-Source-IP: 208.91.2.3 From: Andy Zhou To: dev@openvswitch.org X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V3-1213063546 X-CudaMail-DTE: 121415 X-CudaMail-Originating-IP: 209.85.220.51 Date: Mon, 14 Dec 2015 15:08:15 -0800 X-ASG-Orig-Subj: [##CM-V3-1213063546##][PATCH] lib: fix sparse warnings Message-Id: <1450134495-27560-1-git-send-email-azhou@ovn.org> X-Mailer: git-send-email 1.9.1 X-Barracuda-Connect: UNKNOWN[192.168.14.3] X-Barracuda-Start-Time: 1450134504 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Subject: [ovs-dev] [PATCH] lib: fix sparse warnings X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" Fixes the following sparse warning messages: lib/ovsdb-idl.c:146:12: error: symbol 'table_updates_names' was not declared. Should it be static? lib/ovsdb-idl.c:147:12: error: symbol 'table_update_names' was not declared. Should it be static? lib/ovsdb-idl.c:148:12: error: symbol 'row_update_names' was not declared. Should it be static? Reported-by: Joe Perches See: https://travis-ci.org/openvswitch/ovs/jobs/96737772#L870 Signed-off-by: Andy Zhou Acked-by: Ben Pfaff Acked-by: Joe Stringer --- lib/ovsdb-idl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 0d02ae8..6086935 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -143,9 +143,9 @@ enum ovsdb_update_version { }; /* Name arrays indexed by 'enum ovsdb_update_version'. */ -const char *table_updates_names[] = {"table_updates", "table_updates2"}; -const char *table_update_names[] = {"table_update", "table_update2"}; -const char *row_update_names[] = {"row_update", "row_update2"}; +static const char *table_updates_names[] = {"table_updates", "table_updates2"}; +static const char *table_update_names[] = {"table_update", "table_update2"}; +static const char *row_update_names[] = {"row_update", "row_update2"}; static struct vlog_rate_limit syntax_rl = VLOG_RATE_LIMIT_INIT(1, 5); static struct vlog_rate_limit semantic_rl = VLOG_RATE_LIMIT_INIT(1, 5);