From patchwork Thu Nov 26 09:41:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Yamamoto X-Patchwork-Id: 548979 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (unknown [IPv6:2600:3c00::f03c:91ff:fe6e:bdf7]) by ozlabs.org (Postfix) with ESMTP id 8C2351402D2 for ; Thu, 26 Nov 2015 20:41:47 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=midokura-com.20150623.gappssmtp.com header.i=@midokura-com.20150623.gappssmtp.com header.b=McWrG43v; dkim-atps=neutral Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 7C30E10CAE; Thu, 26 Nov 2015 01:41:46 -0800 (PST) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e3.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id A1CF610CAD for ; Thu, 26 Nov 2015 01:41:44 -0800 (PST) Received: from bar2.cudamail.com (localhost [127.0.0.1]) by mx1e3.cudamail.com (Postfix) with ESMTPS id 2991F42004A for ; Thu, 26 Nov 2015 02:41:44 -0700 (MST) X-ASG-Debug-ID: 1448530902-03dc5332c61e5f70001-byXFYA Received: from mx1-pf2.cudamail.com ([192.168.24.2]) by bar2.cudamail.com with ESMTP id O7SeoiYANW2qObbg (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 26 Nov 2015 02:41:42 -0700 (MST) X-Barracuda-Envelope-From: yamamoto@midokura.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.2 Received: from unknown (HELO mail-io0-f181.google.com) (209.85.223.181) by mx1-pf2.cudamail.com with ESMTPS (RC4-SHA encrypted); 26 Nov 2015 09:41:42 -0000 Received-SPF: neutral (mx1-pf2.cudamail.com: 209.85.223.181 is neither permitted nor denied by SPF record at spf.mandrillapp.com) X-Barracuda-RBL-Trusted-Forwarder: 209.85.223.181 Received: by ioir85 with SMTP id r85so82687994ioi.1 for ; Thu, 26 Nov 2015 01:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=midokura-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=CsjycWSLc1/ig1XBOSllGocDgEF9NM6dSQmdf1eTz4A=; b=McWrG43vhKTc2da5OWX6vJHsAHXxsB8s6LJdmMw4b+v0bcIVw57bgrYeEGopYlP9BU bfGxjPmsptbtdQ5Ff7C1TZ0oQ3kGzzDiyZFrt/fplIa9vEkh6jfib1CMEes3Xmt0Buz/ r1i6L/OwmVbD9tqylBoSD+0SZwtWcfX/2haU2JzcjKdkJHIT+3XUJk2H9540NV9aSqxc Lih8sL8ADw4WA/Z+McAdcF+owCPaSziob4T0Hmj8mW28AgebgmR+Ej2oQhMh1xCHI601 RfDpzFOmDIAFxFZT20hgxrQmEQVKQf22vwMJV/0OR2yPmJ4b8u/Pk2tjKQbeZ5HXDFOD V+qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CsjycWSLc1/ig1XBOSllGocDgEF9NM6dSQmdf1eTz4A=; b=aQeLaItt/1hOn/Hp9qPWFCZdPa+jTbKLlNV/WGTiIdp5kPiKWH4DpxG7HUI0M3GHGJ g2SvXS8BxhfC1pdV+obQarIgTphb1wm83aOZhkJ9JUYdPuVsxk3wsqWhvSyKPXUSU2ER Xxedi1RUZTWg7lCYKnpU83fyYRrcMBU4qjUVv4iWRfn9ruIgoLBusxIQ8a2a4ZrUe108 s9ZQ+8zLSZQNBudNJC8H1k7oDw7ARtZ+RX7Nj4L7nJWl9BfwWNROlNf3Ub9lymjGBwPl DzilSBuhw0CYss0DmIGbXdJNILXQrARj8//6eqWTKr9ohRKvhmF6wdxARinhJhWZznra TYLw== X-Gm-Message-State: ALoCoQl80v8TipluyxZFVRB/yteKwebNUjA+ba+KbVrGzUApwgbzIA4A9tC2ZyCc651ofuSUYvAn X-Received: by 10.98.74.129 with SMTP id c1mr38023911pfj.124.1448530899967; Thu, 26 Nov 2015 01:41:39 -0800 (PST) Received: from giraffe.local.net (p10241-ipngn1601marunouchi.tokyo.ocn.ne.jp. [180.0.103.241]) by smtp.gmail.com with ESMTPSA id t73sm26209455pfi.83.2015.11.26.01.41.38 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Nov 2015 01:41:39 -0800 (PST) X-CudaMail-Envelope-Sender: yamamoto@midokura.com From: YAMAMOTO Takashi To: dev@openvswitch.org X-CudaMail-MID: CM-E2-1125007395 X-CudaMail-DTE: 112615 X-CudaMail-Originating-IP: 209.85.223.181 Date: Thu, 26 Nov 2015 18:41:30 +0900 X-ASG-Orig-Subj: [##CM-E2-1125007395##][PATCH 1/3] ovn.at: Use {} to make this less ambiguous Message-Id: <1448530892-4893-1-git-send-email-yamamoto@midokura.com> X-Mailer: git-send-email 2.4.9 (Apple Git-60) X-GBUdb-Analysis: 0, 209.85.223.181, Ugly c=0.548538 p=-0.619512 Source Normal X-MessageSniffer-Rules: 0-0-0-4538-c X-Barracuda-Connect: UNKNOWN[192.168.24.2] X-Barracuda-Start-Time: 1448530902 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.60 X-Barracuda-Spam-Status: No, SCORE=0.60 using per-user scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=BSF_SC5_MJ1963, DKIM_SIGNED, RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.24739 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 DKIM_SIGNED Domain Keys Identified Mail: message has a signature 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS 0.50 BSF_SC5_MJ1963 Custom Rule MJ1963 Cc: YAMAMOTO Takashi Subject: [ovs-dev] [PATCH 1/3] ovn.at: Use {} to make this less ambiguous X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" While (surprisingly to me) bash interprets $10 as ${1}0, many other shells, including NetBSD's /bin/sh, interpret it as ${10}. Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn.at b/tests/ovn.at index 68fcc9a..de0a830 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -964,7 +964,7 @@ done test_ip() { # This packet has bad checksums but logical L3 routing doesn't check. local inport=$1 src_mac=$2 dst_mac=$3 src_ip=$4 dst_ip=$5 - local packet=$3$208004500001c0000000040110000$4$50035111100080000 + local packet=${dst_mac}${src_mac}08004500001c0000000040110000${src_ip}${dst_ip}0035111100080000 shift; shift; shift; shift; shift hv=hv`vif_to_hv $inport` as $hv ovs-appctl netdev-dummy/receive vif$inport $packet