| Message ID | 1448481765-46588-1-git-send-email-nithin@vmware.com |
|---|---|
| State | Superseded |
| Headers | show |
On 11/25/2015 03:02 PM, Nithin Raju wrote: > Signed-off-by: Nithin Raju <nithin@vmware.com> > --- > datapath-windows/ovsext/Util.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/datapath-windows/ovsext/Util.h b/datapath-windows/ovsext/Util.h > index 0bbc52b..e5ba72b 100644 > --- a/datapath-windows/ovsext/Util.h > +++ b/datapath-windows/ovsext/Util.h > @@ -66,7 +66,7 @@ VOID OvsFreeAlignedMemory(VOID *ptr); > VOID OvsAppendList(PLIST_ENTRY dst, PLIST_ENTRY src); > > > -#define MIN(_a, _b) (_a) > (_b) ? (_b) : (_a) > +#define MIN(_a, _b) ((_a) > (_b) ? (_b) : (_a)) > #define ARRAY_SIZE(_x) ((sizeof(_x))/sizeof (_x)[0]) > #define OVS_SWITCH_PORT_ID_INVALID (NDIS_SWITCH_PORT_ID)(-1) > > Acked-by: Russell Bryant <russell@ovn.org> I think the commit message could be a bit better though. It doesn't say anything about what was wrong, though the patch is obvious and trivial enough.
-----Original Message----- From: Russell Bryant <russell@ovn.org> Date: Wednesday, November 25, 2015 at 12:07 PM To: Nithin Raju <nithin@vmware.com>, "dev@openvswitch.org" <dev@openvswitch.org> Subject: Re: [ovs-dev] [PATCH] datapath-windows: fix MIN() macro >On 11/25/2015 03:02 PM, Nithin Raju wrote: >> Signed-off-by: Nithin Raju <nithin@vmware.com> >> --- >> datapath-windows/ovsext/Util.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/datapath-windows/ovsext/Util.h >>b/datapath-windows/ovsext/Util.h >> index 0bbc52b..e5ba72b 100644 >> --- a/datapath-windows/ovsext/Util.h >> +++ b/datapath-windows/ovsext/Util.h >> @@ -66,7 +66,7 @@ VOID OvsFreeAlignedMemory(VOID *ptr); >> VOID OvsAppendList(PLIST_ENTRY dst, PLIST_ENTRY src); >> >> >> -#define MIN(_a, _b) (_a) > (_b) ? (_b) : (_a) >> +#define MIN(_a, _b) ((_a) > (_b) ? (_b) : (_a)) >> #define ARRAY_SIZE(_x) ((sizeof(_x))/sizeof (_x)[0]) >> #define OVS_SWITCH_PORT_ID_INVALID (NDIS_SWITCH_PORT_ID)(-1) >> >> > >Acked-by: Russell Bryant <russell@ovn.org> > >I think the commit message could be a bit better though. It doesn't say >anything about what was wrong, though the patch is obvious and trivial >enough. Thanks for the review. Send out a v2. -- Nithin
diff --git a/datapath-windows/ovsext/Util.h b/datapath-windows/ovsext/Util.h index 0bbc52b..e5ba72b 100644 --- a/datapath-windows/ovsext/Util.h +++ b/datapath-windows/ovsext/Util.h @@ -66,7 +66,7 @@ VOID OvsFreeAlignedMemory(VOID *ptr); VOID OvsAppendList(PLIST_ENTRY dst, PLIST_ENTRY src); -#define MIN(_a, _b) (_a) > (_b) ? (_b) : (_a) +#define MIN(_a, _b) ((_a) > (_b) ? (_b) : (_a)) #define ARRAY_SIZE(_x) ((sizeof(_x))/sizeof (_x)[0]) #define OVS_SWITCH_PORT_ID_INVALID (NDIS_SWITCH_PORT_ID)(-1)
Signed-off-by: Nithin Raju <nithin@vmware.com> --- datapath-windows/ovsext/Util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)