| Message ID | 1448295901-32560-1-git-send-email-russell@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Nov 23, 2015 at 10:25 AM, Russell Bryant <russell@ovn.org> wrote: > Update the BFD todo item to clarify where we might use BFD as it > previously seemed to imply we wanted to enable it for all > hypervisor-to-hypervisor tunnels. > > Signed-off-by: Russell Bryant <russell@ovn.org> > --- > > > This patch attemptes to update the TODO item based on our ML discussion. > Alternatively, we could just remove the TODO item since it's more > speculative > at this point. > > ovn/TODO | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > > diff --git a/ovn/TODO b/ovn/TODO > index 1f2a73f..22d6bd8 100644 > --- a/ovn/TODO > +++ b/ovn/TODO > @@ -306,11 +306,18 @@ think it does everything else. > the Multicast_Group table entry in ovn-sb database into > Mcast_Macs_Remote table configuration in VTEP database. > > -* Use BFD as tunnel monitor. > +* Consider the use BFD as tunnel monitor. > > This reads odd to me. Maybe something like this: "Consider the use of BDF as tunnel monitor." With that change: Acked-By: Kyle Mestery <mestery@mestery.com> > - Both ovn-controller and ovn-contorller-vtep should use BFD to > - monitor the tunnel liveness. Both ovs-vswitchd schema and > - VTEP schema supports BFD. > + The use of BFD for hypervisor-to-hypervisor tunnels is probably not > worth it, > + since there's no alternative to switch to if a tunnel goes down. It > could > + make sense at a slow rate if someone does OVN monitoring system > integration, > + but not otherwise. > + > + When OVN gets to supporting HA for gateways (see ovn/OVN-GW-HA.md), BFD > is > + likely needed as a part of that solution. > + > + There's more commentary in this ML post: > + http://openvswitch.org/pipermail/dev/2015-November/062385.html > > * ACL > > -- > 2.5.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
On Mon, Nov 23, 2015 at 11:25:01AM -0500, Russell Bryant wrote: > Update the BFD todo item to clarify where we might use BFD as it > previously seemed to imply we wanted to enable it for all > hypervisor-to-hypervisor tunnels. > > Signed-off-by: Russell Bryant <russell@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
On 11/23/2015 11:36 AM, Kyle Mestery wrote: > On Mon, Nov 23, 2015 at 10:25 AM, Russell Bryant <russell@ovn.org > <mailto:russell@ovn.org>> wrote: > > Update the BFD todo item to clarify where we might use BFD as it > previously seemed to imply we wanted to enable it for all > hypervisor-to-hypervisor tunnels. > > Signed-off-by: Russell Bryant <russell@ovn.org <mailto:russell@ovn.org>> > --- > > > This patch attemptes to update the TODO item based on our ML discussion. > Alternatively, we could just remove the TODO item since it's more > speculative > at this point. > > ovn/TODO | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > > diff --git a/ovn/TODO b/ovn/TODO > index 1f2a73f..22d6bd8 100644 > --- a/ovn/TODO > +++ b/ovn/TODO > @@ -306,11 +306,18 @@ think it does everything else. > the Multicast_Group table entry in ovn-sb database into > Mcast_Macs_Remote table configuration in VTEP database. > > -* Use BFD as tunnel monitor. > +* Consider the use BFD as tunnel monitor. > > This reads odd to me. Maybe something like this: > > "Consider the use of BDF as tunnel monitor." > > With that change: > > Acked-By: Kyle Mestery <mestery@mestery.com <mailto:mestery@mestery.com>> Did you mean to change it further? The only change I see is from "BFD" to "BDF", which I don't think was intentional. :-)
> On Nov 23, 2015, at 10:27 AM, Russell Bryant <russell@ovn.org> wrote: > > On 11/23/2015 11:36 AM, Kyle Mestery wrote: >> On Mon, Nov 23, 2015 at 10:25 AM, Russell Bryant <russell@ovn.org >> <mailto:russell@ovn.org>> wrote: >> >> Update the BFD todo item to clarify where we might use BFD as it >> previously seemed to imply we wanted to enable it for all >> hypervisor-to-hypervisor tunnels. >> >> Signed-off-by: Russell Bryant <russell@ovn.org <mailto:russell@ovn.org>> >> --- >> >> >> This patch attemptes to update the TODO item based on our ML discussion. >> Alternatively, we could just remove the TODO item since it's more >> speculative >> at this point. >> >> ovn/TODO | 15 +++++++++++---- >> 1 file changed, 11 insertions(+), 4 deletions(-) >> >> >> diff --git a/ovn/TODO b/ovn/TODO >> index 1f2a73f..22d6bd8 100644 >> --- a/ovn/TODO >> +++ b/ovn/TODO >> @@ -306,11 +306,18 @@ think it does everything else. >> the Multicast_Group table entry in ovn-sb database into >> Mcast_Macs_Remote table configuration in VTEP database. >> >> -* Use BFD as tunnel monitor. >> +* Consider the use BFD as tunnel monitor. >> >> This reads odd to me. Maybe something like this: >> >> "Consider the use of BDF as tunnel monitor." >> >> With that change: >> >> Acked-By: Kyle Mestery <mestery@mestery.com <mailto:mestery@mestery.com>> > > Did you mean to change it further? The only change I see is from "BFD" > to "BDF", which I don't think was intentional. :-) I suspect it was the "of", not the "BDF". :-) --Justin
On Mon, Nov 23, 2015 at 1:46 PM, Justin Pettit <jpettit@ovn.org> wrote: > > > On Nov 23, 2015, at 10:27 AM, Russell Bryant <russell@ovn.org> wrote: > > > > On 11/23/2015 11:36 AM, Kyle Mestery wrote: > >> On Mon, Nov 23, 2015 at 10:25 AM, Russell Bryant <russell@ovn.org > >> <mailto:russell@ovn.org>> wrote: > >> > >> Update the BFD todo item to clarify where we might use BFD as it > >> previously seemed to imply we wanted to enable it for all > >> hypervisor-to-hypervisor tunnels. > >> > >> Signed-off-by: Russell Bryant <russell@ovn.org <mailto: > russell@ovn.org>> > >> --- > >> > >> > >> This patch attemptes to update the TODO item based on our ML > discussion. > >> Alternatively, we could just remove the TODO item since it's more > >> speculative > >> at this point. > >> > >> ovn/TODO | 15 +++++++++++---- > >> 1 file changed, 11 insertions(+), 4 deletions(-) > >> > >> > >> diff --git a/ovn/TODO b/ovn/TODO > >> index 1f2a73f..22d6bd8 100644 > >> --- a/ovn/TODO > >> +++ b/ovn/TODO > >> @@ -306,11 +306,18 @@ think it does everything else. > >> the Multicast_Group table entry in ovn-sb database into > >> Mcast_Macs_Remote table configuration in VTEP database. > >> > >> -* Use BFD as tunnel monitor. > >> +* Consider the use BFD as tunnel monitor. > >> > >> This reads odd to me. Maybe something like this: > >> > >> "Consider the use of BDF as tunnel monitor." > >> > >> With that change: > >> > >> Acked-By: Kyle Mestery <mestery@mestery.com <mailto:mestery@mestery.com > >> > > > > Did you mean to change it further? The only change I see is from "BFD" > > to "BDF", which I don't think was intentional. :-) > > I suspect it was the "of", not the "BDF". :-) > Ah ha! That's the change I was looking for but couldn't spot. :-)
On Mon, Nov 23, 2015 at 12:52 PM, Russell Bryant <russell@ovn.org> wrote: > > > On Mon, Nov 23, 2015 at 1:46 PM, Justin Pettit <jpettit@ovn.org> wrote: > >> >> > On Nov 23, 2015, at 10:27 AM, Russell Bryant <russell@ovn.org> wrote: >> > >> > On 11/23/2015 11:36 AM, Kyle Mestery wrote: >> >> On Mon, Nov 23, 2015 at 10:25 AM, Russell Bryant <russell@ovn.org >> >> <mailto:russell@ovn.org>> wrote: >> >> >> >> Update the BFD todo item to clarify where we might use BFD as it >> >> previously seemed to imply we wanted to enable it for all >> >> hypervisor-to-hypervisor tunnels. >> >> >> >> Signed-off-by: Russell Bryant <russell@ovn.org <mailto: >> russell@ovn.org>> >> >> --- >> >> >> >> >> >> This patch attemptes to update the TODO item based on our ML >> discussion. >> >> Alternatively, we could just remove the TODO item since it's more >> >> speculative >> >> at this point. >> >> >> >> ovn/TODO | 15 +++++++++++---- >> >> 1 file changed, 11 insertions(+), 4 deletions(-) >> >> >> >> >> >> diff --git a/ovn/TODO b/ovn/TODO >> >> index 1f2a73f..22d6bd8 100644 >> >> --- a/ovn/TODO >> >> +++ b/ovn/TODO >> >> @@ -306,11 +306,18 @@ think it does everything else. >> >> the Multicast_Group table entry in ovn-sb database into >> >> Mcast_Macs_Remote table configuration in VTEP database. >> >> >> >> -* Use BFD as tunnel monitor. >> >> +* Consider the use BFD as tunnel monitor. >> >> >> >> This reads odd to me. Maybe something like this: >> >> >> >> "Consider the use of BDF as tunnel monitor." >> >> >> >> With that change: >> >> >> >> Acked-By: Kyle Mestery <mestery@mestery.com <mailto: >> mestery@mestery.com>> >> > >> > Did you mean to change it further? The only change I see is from "BFD" >> > to "BDF", which I don't think was intentional. :-) >> >> I suspect it was the "of", not the "BDF". :-) >> > > Ah ha! That's the change I was looking for but couldn't spot. :-) > > Sorry for being pedantic, but Justin called it, it was the "of." :) > -- > Russell Bryant >
> On Nov 23, 2015, at 11:36 AM, Kyle Mestery <mestery@mestery.com> wrote: > >> On Mon, Nov 23, 2015 at 12:52 PM, Russell Bryant <russell@ovn.org> wrote: >> >> >> Ah ha! That's the change I was looking for but couldn't spot. :-) > > Sorry for being pedantic, but Justin called it, it was the "of." :) YES!! Finally all those years of playing "Check...And Doublecheck" in Highlights has paid off. --Justin
On 11/23/2015 02:42 PM, Justin Pettit wrote: > >> On Nov 23, 2015, at 11:36 AM, Kyle Mestery <mestery@mestery.com> wrote: >> >>> On Mon, Nov 23, 2015 at 12:52 PM, Russell Bryant <russell@ovn.org> wrote: >>> >>> >>> Ah ha! That's the change I was looking for but couldn't spot. :-) >> >> Sorry for being pedantic, but Justin called it, it was the "of." :) > > YES!! Finally all those years of playing "Check...And Doublecheck" in Highlights has paid off. Oh, that must be advanced. I'm still reading the "Hello" series for ages 0-2.
On 11/23/2015 12:38 PM, Ben Pfaff wrote: > On Mon, Nov 23, 2015 at 11:25:01AM -0500, Russell Bryant wrote: >> Update the BFD todo item to clarify where we might use BFD as it >> previously seemed to imply we wanted to enable it for all >> hypervisor-to-hypervisor tunnels. >> >> Signed-off-by: Russell Bryant <russell@ovn.org> > > Acked-by: Ben Pfaff <blp@ovn.org> > Thanks. I pushed this to master with acks from you and Kyle.
diff --git a/ovn/TODO b/ovn/TODO index 1f2a73f..22d6bd8 100644 --- a/ovn/TODO +++ b/ovn/TODO @@ -306,11 +306,18 @@ think it does everything else. the Multicast_Group table entry in ovn-sb database into Mcast_Macs_Remote table configuration in VTEP database. -* Use BFD as tunnel monitor. +* Consider the use BFD as tunnel monitor. - Both ovn-controller and ovn-contorller-vtep should use BFD to - monitor the tunnel liveness. Both ovs-vswitchd schema and - VTEP schema supports BFD. + The use of BFD for hypervisor-to-hypervisor tunnels is probably not worth it, + since there's no alternative to switch to if a tunnel goes down. It could + make sense at a slow rate if someone does OVN monitoring system integration, + but not otherwise. + + When OVN gets to supporting HA for gateways (see ovn/OVN-GW-HA.md), BFD is + likely needed as a part of that solution. + + There's more commentary in this ML post: + http://openvswitch.org/pipermail/dev/2015-November/062385.html * ACL
Update the BFD todo item to clarify where we might use BFD as it previously seemed to imply we wanted to enable it for all hypervisor-to-hypervisor tunnels. Signed-off-by: Russell Bryant <russell@ovn.org> --- This patch attemptes to update the TODO item based on our ML discussion. Alternatively, we could just remove the TODO item since it's more speculative at this point. ovn/TODO | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)