mbox series

[ovs-dev,v3,0/8] Coverity fixes.

Message ID cover.1716979680.git.echaudro@redhat.com
Headers show
Series Coverity fixes. | expand

Message

Eelco Chaudron May 29, 2024, 10:53 a.m. UTC
This series addresses several high-priority Coverity issues.

Delta from v2 -> v3:
- Cleaned up error message on patch 8.

Delta from v1 -> v2:
- Add cover letter.
- Split first patch and update commit subject.
- Added ds_destroy() to context_done().
- Changed invalid gso_type handling by returning an error + log message.
- Changed sFlowRcvrTimeout to be using uint32_t to avoid TIME_T_MAKE.

Eelco Chaudron (8):
  netdev-linux: Fix possible int overflow in tc_add_matchall_policer().
  cfm: Fix possible integer overflow in tc_add_matchall_policer().
  sflow: Replace libc's random() function with the OVS's random_range().
  sflow: Use uint32_t instead of time_t for tick handling in the poller.
  sflow: Fix check for disabled receive time.
  ofproto-dpif: Define age as time_t in ofproto_unixctl_fdb_add().
  db-ctl-base: Initialize the output variable in the ctx structure.
  netdev-linux: Fix uninitialized gso_type case.

 lib/cfm.c                    |  2 +-
 lib/db-ctl-base.c            |  2 ++
 lib/netdev-linux.c           |  8 ++++++--
 lib/sflow_api.h              | 10 +++++-----
 lib/sflow_poller.c           |  3 ++-
 lib/sflow_receiver.c         |  7 ++++---
 ofproto/ofproto-dpif-sflow.c |  2 +-
 ofproto/ofproto-dpif.c       |  2 +-
 8 files changed, 22 insertions(+), 14 deletions(-)

Comments

Eelco Chaudron June 3, 2024, 12:47 p.m. UTC | #1
On 29 May 2024, at 12:53, Eelco Chaudron wrote:

> This series addresses several high-priority Coverity issues.
>
> Delta from v2 -> v3:
> - Cleaned up error message on patch 8.
>
> Delta from v1 -> v2:
> - Add cover letter.
> - Split first patch and update commit subject.
> - Added ds_destroy() to context_done().
> - Changed invalid gso_type handling by returning an error + log message.
> - Changed sFlowRcvrTimeout to be using uint32_t to avoid TIME_T_MAKE.
>
> Eelco Chaudron (8):
>   netdev-linux: Fix possible int overflow in tc_add_matchall_policer().
>   cfm: Fix possible integer overflow in tc_add_matchall_policer().
>   sflow: Replace libc's random() function with the OVS's random_range().
>   sflow: Use uint32_t instead of time_t for tick handling in the poller.
>   sflow: Fix check for disabled receive time.
>   ofproto-dpif: Define age as time_t in ofproto_unixctl_fdb_add().
>   db-ctl-base: Initialize the output variable in the ctx structure.
>   netdev-linux: Fix uninitialized gso_type case.
>
>  lib/cfm.c                    |  2 +-
>  lib/db-ctl-base.c            |  2 ++
>  lib/netdev-linux.c           |  8 ++++++--
>  lib/sflow_api.h              | 10 +++++-----
>  lib/sflow_poller.c           |  3 ++-
>  lib/sflow_receiver.c         |  7 ++++---
>  ofproto/ofproto-dpif-sflow.c |  2 +-
>  ofproto/ofproto-dpif.c       |  2 +-
>  8 files changed, 22 insertions(+), 14 deletions(-)

Series applied to main. Thank Ilya, Paolo, and Mike for the reviews.

Cheers,

Eelco