mbox series

[ovs-dev,v3,0/8] Address clang analyze warnings.

Message ID 20240909045505.236657-1-mkp@redhat.com
Headers show
Series Address clang analyze warnings. | expand

Message

Mike Pattrick Sept. 9, 2024, 4:54 a.m. UTC 
This series addresses some warnings produced by clang analyze, and reduces the
total number of warnings down from 51 to 30. Asside from the theme of reducing
clang analyze warnings, the individual patches aren't directly related to each
other.

Mike Pattrick (8):
  ovsdb-error: Annotate non-null functions.
  dpif-netdev: Remove undefined integer division.
  jsonrpc: Don't access ovs_list members directly.
  netlink-socket: Initialize socket family.
  classifier: Store n_indices between usage.
  vconn: Always properly free flow stats reply.
  mcast-snooping: Properly check group_get_lru return code.
  mcast-snooping: Don't access ovs_list members directly.

 lib/classifier.c     | 12 ++++++++----
 lib/dpif-netdev.c    | 12 +++++++-----
 lib/jsonrpc.c        |  5 +++--
 lib/mcast-snooping.c |  8 +++++---
 lib/netlink-socket.c |  1 +
 lib/ovsdb-error.h    | 15 ++++++++++-----
 lib/vconn.c          |  6 +++++-
 7 files changed, 39 insertions(+), 20 deletions(-)

Comments

Eelco Chaudron Sept. 11, 2024, 3:07 p.m. UTC | #1 
On 9 Sep 2024, at 6:54, Mike Pattrick wrote:

> This series addresses some warnings produced by clang analyze, and reduces the
> total number of warnings down from 51 to 30. Asside from the theme of reducing
> clang analyze warnings, the individual patches aren't directly related to each
> other.

Thanks Mike for the series. Applied to main, and will backport fixes to older branches later this week.

//Eelco