From patchwork Fri Oct 13 09:07:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakob Meng X-Patchwork-Id: 1848154 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ckj3jReR; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4S6LJv3Y08z1yqZ for ; Fri, 13 Oct 2023 20:08:31 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6B0B541E45; Fri, 13 Oct 2023 09:08:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6B0B541E45 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ckj3jReR X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TlXHRrVTZ6wY; Fri, 13 Oct 2023 09:08:28 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 89ED641E46; Fri, 13 Oct 2023 09:08:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 89ED641E46 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 61E65C0071; Fri, 13 Oct 2023 09:08:27 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id AC79CC0032 for ; Fri, 13 Oct 2023 09:08:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 79D2A41F65 for ; Fri, 13 Oct 2023 09:08:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 79D2A41F65 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vrGNeZIMil_7 for ; Fri, 13 Oct 2023 09:08:25 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id B047B41F34 for ; Fri, 13 Oct 2023 09:08:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B047B41F34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697188104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9Titxs228lzGO+9i/6hyz1VHCyIk4EkJ/NFOJZ2xuFM=; b=ckj3jReR0kI8Bel1yR7EMFGdUfNkfELBOT01+t3TeBcZv4F9Qkb9+TAyhO6FWHt/8Qv5dd ZWstdHiIRA1WeW0cv+o9u+gcy7wFIWHHVlJbUjM+oSJnPIRceipoztJczRj/GtQ44JoZ0I qbN2h6F6dBKi8CoFD18q8KuE9i1hr/E= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-m2GR2GAqMNio-UjY2XtdLA-1; Fri, 13 Oct 2023 05:08:22 -0400 X-MC-Unique: m2GR2GAqMNio-UjY2XtdLA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-327b5f2235aso1304136f8f.1 for ; Fri, 13 Oct 2023 02:08:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697188101; x=1697792901; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9Titxs228lzGO+9i/6hyz1VHCyIk4EkJ/NFOJZ2xuFM=; b=OsqrrAQFj6VwEhJnukhZH6qb508ts9+Xk/RtaZ6L8xTg1dI8WfobhqNNCqCV+sVG6r NEp41iUzLBfnfTFyV9XW9ePUWw9/sZm2/ac9h8adLElWrBEOdcQ9ntuJe6WiMCiI+YZO 4Pls/b1x9VOLefKe5xchh+7WnIqUCJfqyUXp4MCF/WlONoq1dy+OPp5jKOqu3oWqWtAF kn0W0y5Qd/p0cjuldeNAwmQx7RWUzwzTcjjIZQ9s8FKJjoBt6q6nHUM5nVkP7Q82Xdqg P79NSuzYnk1IrJ1JvgJ1NbC26cnUrlHLwkLyUVoFP5qNQ8b+VEIYZJjuZuKz7c2B5hLH KhfQ== X-Gm-Message-State: AOJu0YxuR2her/vWfjHXusQru/9jb+b7YZotcIA7ua6hRASSuniWuR06 86WtXqKyrSPXYuy+entJo8R2LVlnbyuu3KCHT84IFEZ9g2jk/af4zNS3X3fF0GpICdix14OOLzQ YTYRSOR72HK9ArXwnm0+UTqcCY2dTfYJw0g21mP8oVVrhMBMXyXeayB6rD46WilJh210= X-Received: by 2002:a5d:4086:0:b0:31f:fab1:c3c3 with SMTP id o6-20020a5d4086000000b0031ffab1c3c3mr22390500wrp.35.1697188101044; Fri, 13 Oct 2023 02:08:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUuK/uWTw4EhYXoHG6mOhNOarVc+54CxGZMnpONXb7xhOGniL2rIxWEINH4Wgxa5m9Y6myrQ== X-Received: by 2002:a5d:4086:0:b0:31f:fab1:c3c3 with SMTP id o6-20020a5d4086000000b0031ffab1c3c3mr22390482wrp.35.1697188100609; Fri, 13 Oct 2023 02:08:20 -0700 (PDT) Received: from positronik4lide.redhat.com ([87.122.56.148]) by smtp.gmail.com with ESMTPSA id k7-20020a5d66c7000000b0031fd849e797sm20258580wrw.105.2023.10.13.02.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 02:08:20 -0700 (PDT) From: jmeng@redhat.com To: dev@openvswitch.org Date: Fri, 13 Oct 2023 11:07:56 +0200 Message-Id: <20231013090759.709191-1-jmeng@redhat.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH v6 0/3] netdev: Sync and clean {get, set}_config() callbacks. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Jakob Meng For better usability, the function pairs get_config() and set_config() for netdevs should be symmetric: Options which are accepted by set_config() should be returned by get_config() and the latter should output valid options for set_config() only. This patch series moves key-value pairs which are no valid options from get_config() to the get_status() callback. The documentation in vswitchd/vswitch.xml for status columns as well as tests have been updated accordingly. Compared to v4, the patch has been split into a series. Change requests from Kevin Traynor have been incorporated, e.g. n_{r,t}xq will be reported in dpkvhostclient status and tx-steering in the dpdk status will be "unsupported" if the hw does not support steering traffic to additional rxq. The netdev dpdk classes no longer share a common get_config callback, instead both the dpdk_class and the dpdk_vhost_client_class defines their own callbacks. For dpdk_vhost_client_class both config options vhost-server-path and tx-retries-max are returned which were missed in the previous patch version. Jakob Meng (3): netdev-dpdk: Sync and clean {get,set}_config() callbacks. netdev-dummy: Sync and clean {get,set}_config() callbacks. netdev-afxdp: Sync and clean {get,set}_config() callbacks. Documentation/intro/install/afxdp.rst | 12 +-- Documentation/topics/dpdk/phy.rst | 4 +- lib/netdev-afxdp.c | 21 +++++- lib/netdev-afxdp.h | 1 + lib/netdev-dpdk.c | 104 ++++++++++++++++++-------- lib/netdev-dummy.c | 19 ++++- lib/netdev-linux-private.h | 1 + lib/netdev-linux.c | 4 +- tests/pmd.at | 26 +++---- tests/system-dpdk.at | 64 ++++++++++------ vswitchd/vswitch.xml | 25 ++++++- 11 files changed, 193 insertions(+), 88 deletions(-) --- 2.39.2