From patchwork Tue Jun 14 11:49:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Finn, Emma" X-Patchwork-Id: 1643247 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=EDNpDjU0; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LMmvx54H0z9sG2 for ; Tue, 14 Jun 2022 21:50:21 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id B3F3482CCB; Tue, 14 Jun 2022 11:50:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9A_ZLbJieJLa; Tue, 14 Jun 2022 11:50:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id CA69082444; Tue, 14 Jun 2022 11:50:17 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9C288C0032; Tue, 14 Jun 2022 11:50:17 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id E23CBC002D for ; Tue, 14 Jun 2022 11:50:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CFCC060864 for ; Tue, 14 Jun 2022 11:50:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WRoYy2y0lqpL for ; Tue, 14 Jun 2022 11:50:12 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by smtp3.osuosl.org (Postfix) with ESMTPS id A279E607D1 for ; Tue, 14 Jun 2022 11:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655207412; x=1686743412; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/UcFnC7oP2VsIIWLCfGAEvOeYM7Cy5R/R4AgA7gq7og=; b=EDNpDjU04prH65XQeootB3nRfJiM8hziTjV6BZd9iGmdrINF3d+b2PY8 VwzgfkdvyFUkSWGlkpPhkM9s/vGfhBUcmmPpQuZiTR/ek5n66DcXMspUi AB2BUlkaT+YneUGEdb3KgojUQU2rHad5ON2klszrdiZAgfu8txRKa/zOD ItFjfMIRlg3Owb2N2IUt9Af/gfoxSEhAcAkJ0wkvV0xyIYUwvtCLrIgPr ao+/ket1y144NMiGQlcjOSrIGEyIXBenDRmcg/3x1QQCsCplUnSktQ6Cx EQMGzihllXFaBEzgebAEq6RfukohWtfyaGGYts27KLOIQa7wOHryFCoFT A==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="278633393" X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="278633393" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 04:50:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="588425049" Received: from silpixa00401384.ir.intel.com ([10.243.23.50]) by fmsmga007.fm.intel.com with ESMTP; 14 Jun 2022 04:50:10 -0700 From: Emma Finn To: =ian.stokes@intel.com, echaudro@redhat.com, harry.van.haaren@intel.com, dev@openvswitch.org Date: Tue, 14 Jun 2022 11:49:38 +0000 Message-Id: <20220614114949.1143097-1-emma.finn@intel.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220510142202.1087967-1-emma.finn@intel.com> References: <20220510142202.1087967-1-emma.finn@intel.com> MIME-Version: 1.0 Subject: [ovs-dev] [PATCH v7 00/11] Actions Infrastructure + Optimizations X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This patchset introduces actions infrastructure changes which allows the user to choose between different action implementations based on CPU ISA by using different commands. The infrastructure also provides a way to check the correctness of the ISA optimized action version against the scalar version. This series also introduces optimized versions of the following actions: - push_vlan - pop_vlan - set_masked eth - set_masked ipv4 Below is a table indicating the relative performance benefits for these actions. +-----------------------------------------------+-------------------+-----------------+ | Actions | Salar with series |AVX with series | +-----------------------------------------------+-------------------+-----------------+ | mod_dl_dst | 1.04x |1.15x | +-----------------------------------------------+-------------------+-----------------+ | push_vlan | 1.10x |1.23x | +-----------------------------------------------+-------------------+-----------------+ | strip_vlan | 1.05x |1.14x | +-----------------------------------------------+-------------------+-----------------+ | mod_ipv4 1 x field | 1.04x |1.04x | +-----------------------------------------------+-------------------+-----------------+ | mod_ipv4 4 x fields | 1.04x |1.23x | +-----------------------------------------------+-------------------+-----------------+ | strip_vlan + mod_dl_dst + mod_ipv4 4 x fields | 1.06x |1.36x | +-----------------------------------------------+-------------------+-----------------+ --- v7: - Fix review comments from Eelco. --- v6: - Rebase to master - Add ISA implementation of set_masked eth and ipv4 actions - Fix incorrect checksums in input packets for ofproto-dpif unit tests --- v5: - Rebase to master - Minor change to variable names - Added Tags from Harry. --- v4: - Rebase to master - Add ISA implementation of push_vlan action --- v3: - Refactored to fix unit test failures - Removed some sign-off on commits --- v2: - Fix the CI build issues --- Emma Finn (10): ofproto-dpif: Fix incorrect checksums in input packets odp-execute: Add function pointers to odp-execute for different action implementations. odp-execute: Add function pointer for pop_vlan action. odp-execute: Add auto validation function for actions. odp-execute: Add command to switch action implementation. odp-execute: Add ISA implementation of actions. odp-execute: Add ISA implementation of pop_vlan action. odp-execute: Add ISA implementation of push_vlan action. odp-execute: Add ISA implementation of set_masked ETH odp-execute: Add ISA implementation of set_masked IPv4 action Kumar Amber (1): dpif-netdev: Add configure option to enable actions autovalidator at build time. Documentation/ref/ovs-actions.7.rst | 26 ++ Documentation/topics/testing.rst | 24 +- NEWS | 11 + acinclude.m4 | 21 ++ configure.ac | 1 + lib/automake.mk | 8 +- lib/cpu.c | 1 + lib/cpu.h | 1 + lib/dp-packet.c | 23 ++ lib/dp-packet.h | 4 + lib/dpif-netdev-unixctl.man | 8 + lib/dpif-netdev.c | 42 +++ lib/odp-execute-avx512.c | 463 ++++++++++++++++++++++++++++ lib/odp-execute-private.c | 266 ++++++++++++++++ lib/odp-execute-private.h | 99 ++++++ lib/odp-execute.c | 183 ++++++++--- lib/odp-execute.h | 14 + tests/ofproto-dpif.at | 10 +- tests/pmd.at | 30 ++ 19 files changed, 1183 insertions(+), 52 deletions(-) create mode 100644 lib/odp-execute-avx512.c create mode 100644 lib/odp-execute-private.c create mode 100644 lib/odp-execute-private.h