| Message ID | 20210826004742.879909-1-numans@ovn.org |
|---|---|
| Headers | show |
| Series | ovsdb-idl: Address missing table and column issues. | expand |
On 8/26/21 2:47 AM, numans@ovn.org wrote: > From: Numan Siddique <nusiddiq@redhat.com> > > This patch series addresses the transaction issues seen when > the C IDL client is running compiled with newer schema and ovsdb-server > is still running with older schema. > > Patch 1: Adds the API to query for table and column names. > Patch 2: Addresses the transaction issues. > > v4 -> v5 > ----- > * Addressed the review comments from Ilya for v4 patch 1. > * patch 2 is unchanged. > > v3 -> v4 > ------ > * Addressed the review comment from Ilya for patch 2. > ovsdb_idl_txn_insert() will not return NULL for missing tables. > > v2 -> v3 > ------ > * Patch 2 is added in v3. > * Patch 1 implementation in v2 was wrong. This patch fixes it and > enhances the test cases. > > v1 -> v2 > ------ > * Added the test cases. > > > Numan Siddique (2): > ovsdb-idl : Add APIs to query if a table and a column is present or > not. > ovsdb-idl: Exclude missing tables and columns in the transaction. > > lib/ovsdb-idl-provider.h | 4 ++ > lib/ovsdb-idl.c | 51 ++++++++++++++++ > lib/ovsdb-idl.h | 4 +- > tests/idltest.ovsschema | 9 +++ > tests/idltest2.ovsschema | 7 +++ > tests/ovsdb-idl.at | 77 ++++++++++++++++++++++++ > tests/test-ovsdb.c | 125 +++++++++++++++++++++++++++++++++++++++ > 7 files changed, 276 insertions(+), 1 deletion(-) > Hi, Numan. Sorry, I didn't see v5 and added some more comments to v4. Please, take a look. Best regards, Ilya Maximets.
From: Numan Siddique <nusiddiq@redhat.com> This patch series addresses the transaction issues seen when the C IDL client is running compiled with newer schema and ovsdb-server is still running with older schema. Patch 1: Adds the API to query for table and column names. Patch 2: Addresses the transaction issues. v4 -> v5 ----- * Addressed the review comments from Ilya for v4 patch 1. * patch 2 is unchanged. v3 -> v4 ------ * Addressed the review comment from Ilya for patch 2. ovsdb_idl_txn_insert() will not return NULL for missing tables. v2 -> v3 ------ * Patch 2 is added in v3. * Patch 1 implementation in v2 was wrong. This patch fixes it and enhances the test cases. v1 -> v2 ------ * Added the test cases. Numan Siddique (2): ovsdb-idl : Add APIs to query if a table and a column is present or not. ovsdb-idl: Exclude missing tables and columns in the transaction. lib/ovsdb-idl-provider.h | 4 ++ lib/ovsdb-idl.c | 51 ++++++++++++++++ lib/ovsdb-idl.h | 4 +- tests/idltest.ovsschema | 9 +++ tests/idltest2.ovsschema | 7 +++ tests/ovsdb-idl.at | 77 ++++++++++++++++++++++++ tests/test-ovsdb.c | 125 +++++++++++++++++++++++++++++++++++++++ 7 files changed, 276 insertions(+), 1 deletion(-)