mbox series

[ovs-dev,v2,0/3] flake8 fixes

Message ID 20190110232347.6574-1-blp@ovn.org
Headers show
Series flake8 fixes | expand

Message

Ben Pfaff Jan. 10, 2019, 11:23 p.m. UTC
This is needed to make OVS work with flake8 3.6.

v1->v2:
   - Added a few more fixes to patch 1.
   - Patch 3 is new.

Ben Pfaff (3):
  python: Fix invalid escape sequences.
  python: Disable flake8 warning W504 "line break after binary
    operator".
  python: Avoid flake8 warning for unused variables.

 Makefile.am                    |  3 ++-
 python/build/nroff.py          |  4 ++--
 python/ovs/db/schema.py        |  2 +-
 python/ovs/json.py             |  4 ++--
 python/ovs/socket_util.py      |  2 +-
 python/ovs/stream.py           |  2 +-
 python/ovs/unixctl/__init__.py |  2 +-
 python/ovs/util.py             |  2 +-
 python/ovs/vlog.py             |  2 +-
 tests/test-ovsdb.py            |  2 +-
 utilities/checkpatch.py        | 24 ++++++++++++------------
 utilities/ovs-dev.py           |  2 +-
 12 files changed, 26 insertions(+), 25 deletions(-)

Comments

Numan Siddique Jan. 11, 2019, 10:18 a.m. UTC | #1
On Fri, Jan 11, 2019 at 4:54 AM Ben Pfaff <blp@ovn.org> wrote:

> This is needed to make OVS work with flake8 3.6.
>
>
Tested all the patches in this series on fedora 29 with flake8 3.7 and it
fixes all
the flake8 issues.

Ack for the whole series.

Acked-by: Numan Siddique <nusiddiq@redhat.com>
Tested-by: Numan Siddique <nusiddiq@redhat.com>

Thanks
Numan


> v1->v2:
>    - Added a few more fixes to patch 1.
>    - Patch 3 is new.
>
> Ben Pfaff (3):
>   python: Fix invalid escape sequences.
>   python: Disable flake8 warning W504 "line break after binary
>     operator".
>   python: Avoid flake8 warning for unused variables.
>
>  Makefile.am                    |  3 ++-
>  python/build/nroff.py          |  4 ++--
>  python/ovs/db/schema.py        |  2 +-
>  python/ovs/json.py             |  4 ++--
>  python/ovs/socket_util.py      |  2 +-
>  python/ovs/stream.py           |  2 +-
>  python/ovs/unixctl/__init__.py |  2 +-
>  python/ovs/util.py             |  2 +-
>  python/ovs/vlog.py             |  2 +-
>  tests/test-ovsdb.py            |  2 +-
>  utilities/checkpatch.py        | 24 ++++++++++++------------
>  utilities/ovs-dev.py           |  2 +-
>  12 files changed, 26 insertions(+), 25 deletions(-)
>
> --
> 2.16.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Ben Pfaff Jan. 11, 2019, 4:46 p.m. UTC | #2
On Fri, Jan 11, 2019 at 03:48:44PM +0530, Numan Siddique wrote:
> On Fri, Jan 11, 2019 at 4:54 AM Ben Pfaff <blp@ovn.org> wrote:
> 
> > This is needed to make OVS work with flake8 3.6.
> >
> >
> Tested all the patches in this series on fedora 29 with flake8 3.7 and it
> fixes all
> the flake8 issues.
> 
> Ack for the whole series.
> 
> Acked-by: Numan Siddique <nusiddiq@redhat.com>
> Tested-by: Numan Siddique <nusiddiq@redhat.com>

Thanks!  I applied this series to master.