| Message ID | 20180301225942.13348-1-e@erig.me |
|---|---|
| Headers | show |
| Series | ofproto-dpif-xlate: translate action_set in clone action | expand |
On Thu, Mar 01, 2018 at 05:59:40PM -0500, Eric Garver wrote: > write_actions() defined inside of a clone() were being ignored. Notably this > affected patch ports between bridges. More details in patch 1. > > travis-ci: https://travis-ci.org/erig0/ovs/builds/347988851 > > Note: Travis failures (1201 and 1227) seem unrelated to this series. They also > pass on my local test machine, debian-9 kernel 4.9.65-3+deb9u2. > > Eric Garver (2): > ofproto-dpif-xlate: translate action_set in clone action > tests/ofproto-dpif: New test for action_set after traversing patch > port > > ofproto/ofproto-dpif-xlate.c | 9 +++++++++ > tests/ofproto-dpif.at | 25 +++++++++++++++++++++++++ > 2 files changed, 34 insertions(+) > Hi ovs-dev, Sorry to bump, but can someone please review this series? downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1544892 Thanks. Eric.
On Thu, Mar 01, 2018 at 05:59:40PM -0500, Eric Garver wrote: > write_actions() defined inside of a clone() were being ignored. Notably this > affected patch ports between bridges. More details in patch 1. > > travis-ci: https://travis-ci.org/erig0/ovs/builds/347988851 > > Note: Travis failures (1201 and 1227) seem unrelated to this series. They also > pass on my local test machine, debian-9 kernel 4.9.65-3+deb9u2. Applied to master, thank you for the fixes (and especially for the new test)! Do you want these backported? Thanks, Ben.
On Thu, Mar 08, 2018 at 10:51:54AM -0800, Ben Pfaff wrote: > On Thu, Mar 01, 2018 at 05:59:40PM -0500, Eric Garver wrote: > > write_actions() defined inside of a clone() were being ignored. Notably this > > affected patch ports between bridges. More details in patch 1. > > > > travis-ci: https://travis-ci.org/erig0/ovs/builds/347988851 > > > > Note: Travis failures (1201 and 1227) seem unrelated to this series. They also > > pass on my local test machine, debian-9 kernel 4.9.65-3+deb9u2. > > Applied to master, thank you for the fixes (and especially for the new > test)! > > Do you want these backported? It would be great if it could also go to branch-2.9. Thanks! Eric.
On Thu, Mar 08, 2018 at 02:48:00PM -0500, Eric Garver wrote: > On Thu, Mar 08, 2018 at 10:51:54AM -0800, Ben Pfaff wrote: > > On Thu, Mar 01, 2018 at 05:59:40PM -0500, Eric Garver wrote: > > > write_actions() defined inside of a clone() were being ignored. Notably this > > > affected patch ports between bridges. More details in patch 1. > > > > > > travis-ci: https://travis-ci.org/erig0/ovs/builds/347988851 > > > > > > Note: Travis failures (1201 and 1227) seem unrelated to this series. They also > > > pass on my local test machine, debian-9 kernel 4.9.65-3+deb9u2. > > > > Applied to master, thank you for the fixes (and especially for the new > > test)! > > > > Do you want these backported? > > It would be great if it could also go to branch-2.9. Done!
write_actions() defined inside of a clone() were being ignored. Notably this affected patch ports between bridges. More details in patch 1. travis-ci: https://travis-ci.org/erig0/ovs/builds/347988851 Note: Travis failures (1201 and 1227) seem unrelated to this series. They also pass on my local test machine, debian-9 kernel 4.9.65-3+deb9u2. Eric Garver (2): ofproto-dpif-xlate: translate action_set in clone action tests/ofproto-dpif: New test for action_set after traversing patch port ofproto/ofproto-dpif-xlate.c | 9 +++++++++ tests/ofproto-dpif.at | 25 +++++++++++++++++++++++++ 2 files changed, 34 insertions(+)