mbox series

[ovs-dev,v3,0/3] Add dpif support for ct_clear action

Message ID 20171119004146.2438-1-e@erig.me
Headers show
Series Add dpif support for ct_clear action | expand

Message

Eric Garver Nov. 19, 2017, 12:41 a.m. UTC
This series adds dpif support for OVS_ACTION_ATTR_CT_CLEAR. Previously the
ct_clear action was a userspace only operation, but it has use cases in the
dpif as well. Namely changing a packet's tuple after a ct() lookup has
occurred.

Kernel support has already be accepted upstream:
  b8226962b1c4 ("openvswitch: add ct_clear action").

travis-ci: https://travis-ci.org/erig0/ovs/builds/290487503

v3:
    - add NEWS item
    - add comment describing OVS_ACTION_ATTR_CT_CLEAR
    - update parse_odp_action() and add ct_clear to odp test case
v2:
    - Specify port for nc in test (patch 3)

Eric Garver (3):
  dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR
  system-common-macros: Check for ct_clear action in datapath
  system-traffic: Add conntrack floating IP test

 NEWS                                              |  3 +
 datapath/linux/compat/include/linux/openvswitch.h |  2 +
 lib/conntrack.c                                   | 10 ++++
 lib/conntrack.h                                   |  1 +
 lib/dpif-netdev.c                                 |  1 +
 lib/dpif.c                                        |  1 +
 lib/odp-execute.c                                 |  7 +++
 lib/odp-util.c                                    | 11 ++++
 lib/ofp-actions.c                                 |  1 +
 ofproto/ofproto-dpif-ipfix.c                      |  1 +
 ofproto/ofproto-dpif-sflow.c                      |  1 +
 ofproto/ofproto-dpif-xlate.c                      | 14 ++++-
 ofproto/ofproto-dpif.c                            | 32 ++++++++++
 ofproto/ofproto-dpif.h                            |  5 +-
 tests/odp.at                                      |  1 +
 tests/system-common-macros.at                     |  4 ++
 tests/system-traffic.at                           | 73 +++++++++++++++++++++++
 17 files changed, 166 insertions(+), 2 deletions(-)

Comments

Eric Garver Jan. 16, 2018, 5:10 p.m. UTC | #1
On Sat, Nov 18, 2017 at 07:41:43PM -0500, Eric Garver wrote:
> This series adds dpif support for OVS_ACTION_ATTR_CT_CLEAR. Previously the
> ct_clear action was a userspace only operation, but it has use cases in the
> dpif as well. Namely changing a packet's tuple after a ct() lookup has
> occurred.
> 
> Kernel support has already be accepted upstream:
>   b8226962b1c4 ("openvswitch: add ct_clear action").
> 
> travis-ci: https://travis-ci.org/erig0/ovs/builds/290487503
> 
> v3:
>     - add NEWS item
>     - add comment describing OVS_ACTION_ATTR_CT_CLEAR
>     - update parse_odp_action() and add ct_clear to odp test case
> v2:
>     - Specify port for nc in test (patch 3)
> 
> Eric Garver (3):
>   dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR
>   system-common-macros: Check for ct_clear action in datapath
>   system-traffic: Add conntrack floating IP test
> 
>  NEWS                                              |  3 +
>  datapath/linux/compat/include/linux/openvswitch.h |  2 +
>  lib/conntrack.c                                   | 10 ++++
>  lib/conntrack.h                                   |  1 +
>  lib/dpif-netdev.c                                 |  1 +
>  lib/dpif.c                                        |  1 +
>  lib/odp-execute.c                                 |  7 +++
>  lib/odp-util.c                                    | 11 ++++
>  lib/ofp-actions.c                                 |  1 +
>  ofproto/ofproto-dpif-ipfix.c                      |  1 +
>  ofproto/ofproto-dpif-sflow.c                      |  1 +
>  ofproto/ofproto-dpif-xlate.c                      | 14 ++++-
>  ofproto/ofproto-dpif.c                            | 32 ++++++++++
>  ofproto/ofproto-dpif.h                            |  5 +-
>  tests/odp.at                                      |  1 +
>  tests/system-common-macros.at                     |  4 ++
>  tests/system-traffic.at                           | 73 +++++++++++++++++++++++
>  17 files changed, 166 insertions(+), 2 deletions(-)
> 
> -- 
> 2.12.0

Hi Ben, Justin,

This series has been ACKd for awhile. Can it be applied?
I can quickly rebase if needed.

Thanks.
Eric.
Justin Pettit Jan. 19, 2018, 2:03 a.m. UTC | #2
> On Jan 16, 2018, at 9:10 AM, Eric Garver <e@erig.me> wrote:
> 
> Hi Ben, Justin,
> 
> This series has been ACKd for awhile. Can it be applied?
> I can quickly rebase if needed.

Sorry for the delay.  I did a brief skim of the patch, and it definitely looks reasonable.  If you would rebase it, that would be great.

Thanks,

--Justin