From patchwork Thu Aug 29 19:46:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Holland X-Patchwork-Id: 1978605 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Si/+hv+h; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=XRoPb5hz; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WvsHH5Wnwz1yfn for ; Fri, 30 Aug 2024 05:46:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=X6f+aytfhxKDge3lQ4S8I9vCmLEUO/7bYhtR1Kx7WCM=; b=Si/+hv+h40mDmR gy2HPAu5WCZ+9XN80sh9c2GFTMxpEbLO1Y8ngifRbuyBtY+rKueNQN7x67W5MYZbCNJo6GIWrfmVE MgDByGYpCYABFWbSbqgnNWfbW6HE/LdybaBtqG7QwHAMLsLlx1PZYd+jhuxXu+h4tbIgNdWBKsAP1 InFXd9GUgdSX+HH/yZ5zzo5iXOJWWBsDl+Z+Lui25XCebDVRaE7rB1UjPYU/13p9B/7LNFm1+fTmJ fo6LN7MOfc9U63UqUVZdxC/YQsOFvEfVMWIBZaanzaIIkAutnRrz2xC5cYJ1WOin0DTppsalC37v/ TxIzgk+K1X5c/Oxjry3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjl6O-00000003Pzv-3p9G; Thu, 29 Aug 2024 19:46:40 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjl6L-00000003PxV-3Vz7 for opensbi@lists.infradead.org; Thu, 29 Aug 2024 19:46:39 +0000 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-7cf5e179b68so683550a12.1 for ; Thu, 29 Aug 2024 12:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1724960796; x=1725565596; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pNXyoZI/fvnnZ1pUIFnC8rx0FChUY2PlBYIhvAmBQ0g=; b=XRoPb5hz69SwANhQ9Ip3hd/pUIkNi3iAWBQI5SgiZabrmNdtrv8XEPQ2KeMJPvDpnx p80ZllsXU8pk+bm4rqu8Zvf5vdYpY4CKuhE17XwPga8tdVep566p8b6jfgidWVCxryWQ IAL6lm+/DCRuYNprn1DdLGYwGqOqixIm5s/hp4zmvY6jgvj32vDkT9ZagA5+rFX3cGkq h8owyk7tH5bVPyBuYMTLzdqMFi26KBB3rdp9BZnTNaNtYYK3fdBK0eJ5Pojb61c3FToE eUjuq17/Dt4kWd4TkTtYcj6tRyh6KX12lSLORjPefy3yV5dNv8SKn3M97kW29j5dQpGX 22gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724960796; x=1725565596; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pNXyoZI/fvnnZ1pUIFnC8rx0FChUY2PlBYIhvAmBQ0g=; b=AGnkhoNyjuHI9Va/Yi31GbdMONfG1Kz7VIvmX67zaL1uPJBqrzot6CtOadlhYifaSQ LUYoxESaVnVue5tpkldjeXL28Q1uniA1a8OdSPaQysfSU4drsZDasCqNADsY25OSbyZY FAvbyekmbzexHVZRBs8LpCBukVwaOu9zVJV7x0S8bFc/v5fsXQBMvfnERjJegYvbQKyw wTXNA/u/4JYaNLxH6649atANS5/HJjDZDOs56l0pIo5dOLF360F/tRKOTCQFfMrE9P7s YnjUkwPpxBCp2ui+qasz8TeH/tgkAFSF61IU7tLaR9mhp0mvjRN1MlglWPP0Mf9dctq4 T5Tw== X-Gm-Message-State: AOJu0Yxkj5FD04QuBPut26pRF3jelnpEhEteEZKtL88x1AjSOBZD7Y9H tCQshHTkUNzbr01XUmwcxgOXPQf9FasOam1zjGkF1YoZF+Y1E4wsVIlGiBn5CBfagqFXX/ImH4J ens8YdhqXhRKs3q9gRu9KeKhE5J7/EF8D0tiDeeNsy2TpgH0S821AgSfcN5EEqSST2Lh1T45Axe 09y1T72+mqeAoz6sijg/uuC+OA73IotAVPiDr/cGjlbcD4iQks+yg= X-Google-Smtp-Source: AGHT+IEcg1434aT1OQjLm5deuRT/oMuOzyOzj//bn1wQGvuX1EJAiaTw9V+juUudh/2IrXTwH4fkog== X-Received: by 2002:a17:90a:c913:b0:2cf:fd50:a2d8 with SMTP id 98e67ed59e1d1-2d85c54600emr4667074a91.7.1724960795670; Thu, 29 Aug 2024 12:46:35 -0700 (PDT) Received: from sw06.internal.sifive.com ([4.53.31.132]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d85b39d051sm2086356a91.40.2024.08.29.12.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 12:46:35 -0700 (PDT) From: Samuel Holland To: opensbi@lists.infradead.org Subject: [PATCH 1/2] include: sbi_domain: Fix incorrect comments Date: Thu, 29 Aug 2024 12:46:23 -0700 Message-ID: <20240829194634.3644683-1-samuel.holland@sifive.com> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_124637_914951_D9895768 X-CRM114-Status: UNSURE ( 9.65 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: These comments are inaccurate as of commit db56341dfa1f ("lib: sbi: Allow platforms to provide root domain memory regions"), which modified root domain registration to go through sbi_domain_register() [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:52e listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org These comments are inaccurate as of commit db56341dfa1f ("lib: sbi: Allow platforms to provide root domain memory regions"), which modified root domain registration to go through sbi_domain_register() like other domains. Fixes: db56341dfa1f ("lib: sbi: Allow platforms to provide root domain memory regions") Signed-off-by: Samuel Holland Reviewed-by: Anup Patel --- include/sbi/sbi_domain.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h index a6e99c63..34ebd39d 100644 --- a/include/sbi/sbi_domain.h +++ b/include/sbi/sbi_domain.h @@ -163,16 +163,9 @@ struct sbi_domain_memregion { /** Representation of OpenSBI domain */ struct sbi_domain { - /** - * Logical index of this domain - * Note: This set by sbi_domain_finalize() in the coldboot path - */ + /** Logical index of this domain */ u32 index; - /** - * HARTs assigned to this domain - * Note: This set by sbi_domain_init() and sbi_domain_finalize() - * in the coldboot path - */ + /** HARTs assigned to this domain */ struct sbi_hartmask assigned_harts; /** Spinlock for accessing assigned_harts */ spinlock_t assigned_harts_lock;