[14/16] lib: utils/reset: Pass the FDT to fdt_reset_init()

Message ID	20240731045931.2446799-15-samuel.holland@sifive.com
State	Accepted
Headers	show Return-Path: <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Samuel Holland <samuel.holland@sifive.com> To: opensbi@lists.infradead.org Subject: [PATCH 14/16] lib: utils/reset: Pass the FDT to fdt_reset_init() Date: Tue, 30 Jul 2024 21:58:55 -0700 Message-ID: <20240731045931.2446799-15-samuel.holland@sifive.com> In-Reply-To: <20240731045931.2446799-1-samuel.holland@sifive.com> References: <20240731045931.2446799-1-samuel.holland@sifive.com> MIME-Version: 1.0 preview: Indicate that this function does not modify the FDT blob, and deduplicate the call to fdt_get_address(). Signed-off-by: Samuel Holland <samuel.holland@sifive.com> --- include/sbi_utils/reset/fdt_reset.h \| 4 ++-- lib/utils/reset/fdt_reset.c \| 3 +-- platform/generic/platform.c \| 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:629 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "opensbi" <opensbi-bounces@lists.infradead.org> Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	Improve FDT blob lifecycle self-documentation \| expand [00/16] Improve FDT blob lifecycle self-documentation [01/16] lib: utils/fdt: Fix fdt_add_cpu_idle_states() prototype [02/16] lib: utils/regmap: Fix typo in comment [03/16] lib: utils/fdt: Constify FDT parsing functions [04/16] lib: utils/gpio: Constify FDT pointers in parsing functions [05/16] lib: utils/i2c: Constify FDT pointers in parsing functions [06/16] lib: utils/ipi: Constify FDT pointers in parsing functions [07/16] lib: utils/irqchip: Constify FDT pointers in parsing functions [08/16] lib: utils/regmap: Constify FDT pointers in parsing functions [09/16] lib: utils/reset: Constify FDT pointers in parsing functions [10/16] lib: utils/serial: Constify FDT pointers in parsing functions [11/16] lib: utils/timer: Constify FDT pointers in parsing functions [12/16] platform: generic: Constify FDT pointers in fw_platform_init() [13/16] platform: generic: Pass FDT to early/final_init overrides [14/16] lib: utils/reset: Pass the FDT to fdt_reset_init() [15/16] lib: utils/serial: Pass the FDT to fdt_serial_init() [16/16] lib: utils/fdt: Add fdt_get_address_rw() helper

Message ID

20240731045931.2446799-15-samuel.holland@sifive.com

State

Accepted

Headers

From: Samuel Holland <samuel.holland@sifive.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 14/16] lib: utils/reset: Pass the FDT to fdt_reset_init()
Date: Tue, 30 Jul 2024 21:58:55 -0700
Message-ID: <20240731045931.2446799-15-samuel.holland@sifive.com>
In-Reply-To: <20240731045931.2446799-1-samuel.holland@sifive.com>
References: <20240731045931.2446799-1-samuel.holland@sifive.com>
MIME-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "opensbi" <opensbi-bounces@lists.infradead.org>
Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

Improve FDT blob lifecycle self-documentation | expand

Commit Message

Samuel Holland July 31, 2024, 4:58 a.m. UTC

Indicate that this function does not modify the FDT blob, and
deduplicate the call to fdt_get_address().

Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
---

 include/sbi_utils/reset/fdt_reset.h | 4 ++--
 lib/utils/reset/fdt_reset.c         | 3 +--
 platform/generic/platform.c         | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/include/sbi_utils/reset/fdt_reset.h b/include/sbi_utils/reset/fdt_reset.h
index 80179873..f126fd33 100644
--- a/include/sbi_utils/reset/fdt_reset.h
+++ b/include/sbi_utils/reset/fdt_reset.h
@@ -29,7 +29,7 @@  int fdt_reset_driver_init(const void *fdt, struct fdt_reset *drv);
  *
  * This function shall be invoked in final init.
  */
-void fdt_reset_init(void);
+void fdt_reset_init(const void *fdt);
 
 #else
 
@@ -37,7 +37,7 @@  static inline int fdt_reset_driver_init(const void *fdt, struct fdt_reset *drv)
 {
 	return 0;
 }
-static inline void fdt_reset_init(void) { }
+static inline void fdt_reset_init(const void *fdt) { }
 
 #endif
 
diff --git a/lib/utils/reset/fdt_reset.c b/lib/utils/reset/fdt_reset.c
index 960c08d0..05deb75e 100644
--- a/lib/utils/reset/fdt_reset.c
+++ b/lib/utils/reset/fdt_reset.c
@@ -42,10 +42,9 @@  int fdt_reset_driver_init(const void *fdt, struct fdt_reset *drv)
 	return cnt > 0 ? 0 : SBI_ENODEV;
 }
 
-void fdt_reset_init(void)
+void fdt_reset_init(const void *fdt)
 {
 	int pos;
-	const void *fdt = fdt_get_address();
 
 	for (pos = 0; pos < fdt_reset_drivers_size; pos++)
 		fdt_reset_driver_init(fdt, fdt_reset_drivers[pos]);
diff --git a/platform/generic/platform.c b/platform/generic/platform.c
index 6f9fb4db..2850d55d 100644
--- a/platform/generic/platform.c
+++ b/platform/generic/platform.c
@@ -225,7 +225,7 @@  static int generic_early_init(bool cold_boot)
 	int rc;
 
 	if (cold_boot) {
-		fdt_reset_init();
+		fdt_reset_init(fdt);
 
 		if (semihosting_enabled())
 			rc = semihosting_init();

[14/16] lib: utils/reset: Pass the FDT to fdt_reset_init()

Commit Message

Patch