| Message ID | 20240624141903.2305676-3-wxjstz@126.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | print befor sbi_console_init | expand |
On Mon, Jun 24, 2024 at 10:18:58PM +0800, Xiang W wrote: > When opensbi crashes, try to initialize the console in order to > output error messages. > > Signed-off-by: Xiang W <wxjstz@126.com> > --- > lib/sbi/sbi_hart.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c > index c366701..48ec97c 100644 > --- a/lib/sbi/sbi_hart.c > +++ b/lib/sbi/sbi_hart.c > @@ -1010,6 +1010,10 @@ int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot) > > void __attribute__((noreturn)) sbi_hart_hang(void) > { > + /* Try to initialize the console to output some error messages */ > + if (sbi_console_get_device() == NULL) > + sbi_console_init(sbi_scratch_thishart_ptr()); > + Patch 2 and 3 must be in reverse order, i.e. Patch 2 should be 3 and 3 should be 2. Otherwise, look good to me. Please send the revision with correct order. Regards Himanshu > while (1) > wfi(); > __builtin_unreachable(); > -- > 2.43.0 > > > -- > opensbi mailing list > opensbi@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/opensbi
On Mon, Jun 24, 2024 at 10:18:58PM GMT, Xiang W wrote: > When opensbi crashes, try to initialize the console in order to > output error messages. > > Signed-off-by: Xiang W <wxjstz@126.com> > --- > lib/sbi/sbi_hart.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c > index c366701..48ec97c 100644 > --- a/lib/sbi/sbi_hart.c > +++ b/lib/sbi/sbi_hart.c > @@ -1010,6 +1010,10 @@ int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot) > > void __attribute__((noreturn)) sbi_hart_hang(void) > { > + /* Try to initialize the console to output some error messages */ > + if (sbi_console_get_device() == NULL) > + sbi_console_init(sbi_scratch_thishart_ptr()); > + > while (1) > wfi(); > __builtin_unreachable(); > -- > 2.43.0 > Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
On Mon, Jun 24, 2024 at 7:49 PM Xiang W <wxjstz@126.com> wrote: > > When opensbi crashes, try to initialize the console in order to > output error messages. > > Signed-off-by: Xiang W <wxjstz@126.com> > --- > lib/sbi/sbi_hart.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c > index c366701..48ec97c 100644 > --- a/lib/sbi/sbi_hart.c > +++ b/lib/sbi/sbi_hart.c > @@ -1010,6 +1010,10 @@ int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot) > > void __attribute__((noreturn)) sbi_hart_hang(void) > { > + /* Try to initialize the console to output some error messages */ > + if (sbi_console_get_device() == NULL) > + sbi_console_init(sbi_scratch_thishart_ptr()); > + If a crash happened early then this will again change the order in which platform console_init() is called as compared to other functions in init_coldboot(). > while (1) > wfi(); > __builtin_unreachable(); > -- > 2.43.0 > Regards, Anup
diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c index c366701..48ec97c 100644 --- a/lib/sbi/sbi_hart.c +++ b/lib/sbi/sbi_hart.c @@ -1010,6 +1010,10 @@ int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot) void __attribute__((noreturn)) sbi_hart_hang(void) { + /* Try to initialize the console to output some error messages */ + if (sbi_console_get_device() == NULL) + sbi_console_init(sbi_scratch_thishart_ptr()); + while (1) wfi(); __builtin_unreachable();
When opensbi crashes, try to initialize the console in order to output error messages. Signed-off-by: Xiang W <wxjstz@126.com> --- lib/sbi/sbi_hart.c | 4 ++++ 1 file changed, 4 insertions(+)