Message ID | 20240606091723.896477-2-wxjstz@126.com |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=B+YivzaH; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=ChByTVAf; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VvzJN6Nm0z20Q8 for <incoming@patchwork.ozlabs.org>; Thu, 6 Jun 2024 19:17:56 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PMOCCaFKtaAJcsjgTSNEKhSBuecRYFmFDPUG74p5ilQ=; b=B+YivzaH3Eapj8 +jNwJ+E2u+o9e4XpA+GzafTchZ8U7ci5mqLGYv3GfBH756YACc8200FCEHqpVDy49z54vqAtImrkw xrJCyGngfqjpd8HOl/s8iCRLoi6yOFyk7ejpatUO4cpBVXWTMDzvF1t9epqjEpDYZOT7yOQurpWZi BFboEvkCbp6GwftGOEZzqoC181WneyOJSFzRQikNHu+zRGkXxSYSmXEsqjm+vZRDhOtEgo5L2RILF uIa6MEhxV+FOZcJ7mrzmJ7+VfWuKFAFEFtg9HIybPBkCHf2IioaH4id1hoLbOMNRQy0r5vMcV3DIE TwpYrDG8YglQWoLLGZIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sF9Fh-000000095IL-3Yda; Thu, 06 Jun 2024 09:17:45 +0000 Received: from m16.mail.126.com ([220.197.31.9]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sF9Fd-000000095E7-3hLP for opensbi@lists.infradead.org; Thu, 06 Jun 2024 09:17:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=o8v1b aw2UjkvobpA2VlWIRtSiyj4fJWyRsZeTl7LOEs=; b=ChByTVAflCi67wS92vnsb K+ME0F3GhG00J/10KJeDO1OOeRaM81kIgiwbj8YCfzApeLlrmPeIcWWTLJVREZjv BcvWoSAuiVmwncGWzzxk/H5UkRJUkNV7fwSLsf1b97SyCTS3cWtQCHkNDVCRBbxh X/xly1dgb0K/2VYKLMaDGo= Received: from T490.lan (unknown [112.83.182.153]) by gzga-smtp-mta-g0-5 (Coremail) with SMTP id _____wDXX8KnfmFmYexZBA--.59331S3; Thu, 06 Jun 2024 17:17:31 +0800 (CST) From: Xiang W <wxjstz@126.com> To: opensbi@lists.infradead.org Cc: Xiang W <wxjstz@126.com>, anup@brainfault.org Subject: [PATCH 1/4] include: sbi_utils: fixup fdt_get_address Date: Thu, 6 Jun 2024 17:17:13 +0800 Message-ID: <20240606091723.896477-2-wxjstz@126.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240606091723.896477-1-wxjstz@126.com> References: <20240606091723.896477-1-wxjstz@126.com> MIME-Version: 1.0 X-CM-TRANSID: _____wDXX8KnfmFmYexZBA--.59331S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrZF13tryruFWxtF4DKrWDtwb_yoW3tFgEv3 Z7Ca1jgrsrursF93WxKw1DtrsagrWrAF18WrySga9rAr4UGFyUuwsrArn3Zrs8Kw10kry7 ursxXryxJay8WjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRM0PfJUUUUU== X-Originating-IP: [112.83.182.153] X-CM-SenderInfo: pz0m23b26rjloofrz/1tbiFw71OmW-PqUonAABsi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240606_021742_323735_3F85478C X-CRM114-Status: UNSURE ( 7.88 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: root.next_arg1 will be NULL before sbi_domain_init, which will cause fdt address to be NULL before sbi_domain is initialized. This patch fixes this. Signed-off-by: Xiang W --- include/sbi_utils/fdt/fdt_helper.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [220.197.31.9 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [wxjstz(at)126.com] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <opensbi.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/opensbi>, <mailto:opensbi-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/opensbi/> List-Post: <mailto:opensbi@lists.infradead.org> List-Help: <mailto:opensbi-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/opensbi>, <mailto:opensbi-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "opensbi" <opensbi-bounces@lists.infradead.org> Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series | Initialize the console as early as possible | expand |
diff --git a/include/sbi_utils/fdt/fdt_helper.h b/include/sbi_utils/fdt/fdt_helper.h index ab4a80f..67e6dc7 100644 --- a/include/sbi_utils/fdt/fdt_helper.h +++ b/include/sbi_utils/fdt/fdt_helper.h @@ -116,7 +116,9 @@ int fdt_parse_compat_addr(void *fdt, uint64_t *addr, static inline void *fdt_get_address(void) { - return (void *)root.next_arg1; + if (root.next_arg1) + return (void *)root.next_arg1; + return sbi_scratch_thishart_arg1_ptr(); } #endif /* __FDT_HELPER_H__ */
root.next_arg1 will be NULL before sbi_domain_init, which will cause fdt address to be NULL before sbi_domain is initialized. This patch fixes this. Signed-off-by: Xiang W <wxjstz@126.com> --- include/sbi_utils/fdt/fdt_helper.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)