From patchwork Tue Apr 23 14:57:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiang W X-Patchwork-Id: 1926622 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=NOxEFTwk; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=bpjAs78f; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VP4xf0z1Xz1yZP for ; Wed, 24 Apr 2024 00:58:30 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pg1TsDFRrG6q3mxfY/UAm0EaoHK3rQS/VzQEcijDs4I=; b=NOxEFTwkEYsbDY vQLzwlDt/8Mle8RbiW45NdySUZjVWOxmYCKutynao+dD2nn2xbdE3BMsmn1ZmoHiku3ls+IB6MGw8 7OxP7Q/BqVOK+70z1fi39T/6yz+ERK5RjsBTl6zKzXGF7dpxZcMy1nFrNulRmWq13unXbAuOwdQMP PnWkV8E8TQwqdL5U9T9RCQkoRDRQnrz6U8P2QYiI7I62tobBMtHIX+EA02i1ItE0qd8wbsHbWMAOT 8XTgjTXIlB6K+Iik4ZnmGHmV/w+2p/ytFLJXAEpLoFkS1rRHH3q4E3jv2NlH6VADGItfhE8MYdKgM 4WdzTwCPJ/Y8hhSVOw1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzHbC-00000000OAn-2rwQ; Tue, 23 Apr 2024 14:58:23 +0000 Received: from m16.mail.126.com ([117.135.210.8]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzHak-00000000O1a-1JPE for opensbi@lists.infradead.org; Tue, 23 Apr 2024 14:57:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=q38cD maayBv/XxD5D3Y2NYzjYUA6xmxd90kUAGhFXso=; b=bpjAs78fvWY/Y+quvDzXJ ARcwQrf1SVkwf9nZr94gVS50lIULPy/r+N25/1I+FBYrDqxvHoedbqJVaqJBdv3h rr6aPbZvmVUDn904bsbYycgBRjCadDGMXvwCbDQMpkZQo8/Y/VZv/8wvEQ5auLgS atYJKyIMDgIdwnHL/TIFJc= Received: from T490.lan (unknown [112.83.183.156]) by gzga-smtp-mta-g0-2 (Coremail) with SMTP id _____wDXT7lpzCdmN00xAg--.23722S5; Tue, 23 Apr 2024 22:57:46 +0800 (CST) From: Xiang W To: opensbi@lists.infradead.org Cc: Xiang W , hchauhan@ventanamicro.com, anup@brainfault.org Subject: [PATCH v2 3/5] lib: sbi: Removal unnecessary check dbtr_thishart_state_ptr Date: Tue, 23 Apr 2024 22:57:39 +0800 Message-ID: <20240423145743.392718-4-wxjstz@126.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240423145743.392718-1-wxjstz@126.com> References: <20240423145743.392718-1-wxjstz@126.com> MIME-Version: 1.0 X-CM-TRANSID: _____wDXT7lpzCdmN00xAg--.23722S5 X-Coremail-Antispam: 1Uf129KBjvdXoWrJr1DKF18Zr4xXFW3ZF18Xwb_yoWxXrc_A3 y8ZF1vgan0qrsrur4q9wsFqr90yr12gr47X3Z3A39rZr43tr4UWF98Jwn8KFW5Zr4jgFn2 9rsrWr93CFy5ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRK_M3tUUUUU== X-Originating-IP: [112.83.183.156] X-CM-SenderInfo: pz0m23b26rjloofrz/xtbBdAzJOmSdL4hRaAADsv X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_075756_255492_5A2AFDF6 X-CRM114-Status: UNSURE ( 4.57 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: After getting hart_shmem_base, dbtr_thishart_state_ptr cannot be empty. So remove check code. Signed-off-by: Xiang W --- lib/sbi/sbi_dbtr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/sbi/sbi_dbtr.c b/lib/sbi/sbi_dbtr.c index ceff185..4093a82 100644 --- a/lib/sbi/sbi_dbtr.c +++ b/lib/sbi/sbi_dbtr.c @@ -683,8 +683,6 @@ int sbi_dbtr_update_trig(unsigned long smode, r [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [wxjstz(at)126.com] X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org After getting hart_shmem_base, dbtr_thishart_state_ptr cannot be empty. So remove check code. Signed-off-by: Xiang W Reviewed-by: Himanshu Chauhan --- lib/sbi/sbi_dbtr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/sbi/sbi_dbtr.c b/lib/sbi/sbi_dbtr.c index ceff185..4093a82 100644 --- a/lib/sbi/sbi_dbtr.c +++ b/lib/sbi/sbi_dbtr.c @@ -683,8 +683,6 @@ int sbi_dbtr_update_trig(unsigned long smode, return SBI_ERR_NO_SHMEM; hs = dbtr_thishart_state_ptr(); - if (!hs) - return SBI_ERR_FAILED; for_each_set_bit_from(idx, &trig_mask, hs->total_trigs) { trig = INDEX_TO_TRIGGER(idx);