| Message ID | 20240302074235.12643-7-wxjstz@126.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Improvements to fw_base.S | expand |
On Sat, Mar 2, 2024 at 1:13 PM Xiang W <wxjstz@126.com> wrote: > > a3 and a4 cannot be reset because used in fw_platform_init. > > Signed-off-by: Xiang W <wxjstz@126.com> LGTM. Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup > --- > firmware/fw_base.S | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/firmware/fw_base.S b/firmware/fw_base.S > index 6f40d82..a798545 100644 > --- a/firmware/fw_base.S > +++ b/firmware/fw_base.S > @@ -77,7 +77,7 @@ _relocate_done: > > /* At this point we are running from link address */ > > - /* Reset all registers except ra, a0, a1 and a2 for boot HART */ > + /* Reset all registers except ra, a0, a1, a2, a3 and a4 for boot HART */ > li ra, 0 > call _reset_regs > > @@ -304,7 +304,7 @@ _wait_for_boot_hart: > bne t0, t1, _wait_for_boot_hart > > _start_warm: > - /* Reset all registers except ra, a0, a1 and a2 for non-boot HARTs */ > + /* Reset all registers except ra, a0, a1, a2, a3 and a4 for non-boot HART */ > li ra, 0 > call _reset_regs > > @@ -655,7 +655,7 @@ _reset_regs: > > /* flush the instruction cache */ > fence.i > - /* Reset all registers except ra, a0, a1 and a2 */ > + /* Reset all registers except ra, a0, a1, a2, a3 and a4 */ > li sp, 0 > li gp, 0 > li tp, 0 > @@ -664,8 +664,6 @@ _reset_regs: > li t2, 0 > li s0, 0 > li s1, 0 > - li a3, 0 > - li a4, 0 > li a5, 0 > li a6, 0 > li a7, 0 > -- > 2.43.0 >
diff --git a/firmware/fw_base.S b/firmware/fw_base.S index 6f40d82..a798545 100644 --- a/firmware/fw_base.S +++ b/firmware/fw_base.S @@ -77,7 +77,7 @@ _relocate_done: /* At this point we are running from link address */ - /* Reset all registers except ra, a0, a1 and a2 for boot HART */ + /* Reset all registers except ra, a0, a1, a2, a3 and a4 for boot HART */ li ra, 0 call _reset_regs @@ -304,7 +304,7 @@ _wait_for_boot_hart: bne t0, t1, _wait_for_boot_hart _start_warm: - /* Reset all registers except ra, a0, a1 and a2 for non-boot HARTs */ + /* Reset all registers except ra, a0, a1, a2, a3 and a4 for non-boot HART */ li ra, 0 call _reset_regs @@ -655,7 +655,7 @@ _reset_regs: /* flush the instruction cache */ fence.i - /* Reset all registers except ra, a0, a1 and a2 */ + /* Reset all registers except ra, a0, a1, a2, a3 and a4 */ li sp, 0 li gp, 0 li tp, 0 @@ -664,8 +664,6 @@ _reset_regs: li t2, 0 li s0, 0 li s1, 0 - li a3, 0 - li a4, 0 li a5, 0 li a6, 0 li a7, 0
a3 and a4 cannot be reset because used in fw_platform_init. Signed-off-by: Xiang W <wxjstz@126.com> --- firmware/fw_base.S | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)