Message ID | 20240302074235.12643-5-wxjstz@126.com |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ZGkEmJC2; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=hcUTOkjF; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Tmxlb1gC0z23pN for <incoming@patchwork.ozlabs.org>; Sat, 2 Mar 2024 18:43:23 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g4ALKiScGEcaqo3Zq2G483qdlRT77+M5+nQ61EnwtL0=; b=ZGkEmJC2/IHErD XforlcJHuOTkolPgbyw2ZCs8HF4vvOOycZG2ilqrZv767nD6ym9INCUI9pTG3SzOo35NDZCKQWS5i g6UEz5qNgQ+nV3Q8vzrc7FccBhB1OBzMuNY11lBtxby6QHZ8xUZT8+zAPxOxtgjlTfJJwnrvMrAKz WWWOcqWK2QXikqmLpClm+0S8efzsdDIvOD3SyZxzTfyFc0fwz7cF+XoHM71n1Y48xqIphkoq0gP+A 8KLadUamP2Gx7PQLeRW3J/mQNeJIGIS1wVNhmlhaoDWpglljWHk/WNw8I6DXght3s9UZRvAfogzwr Jq9B1ba0z/CtxkqVJ6Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgK1c-000000033HE-1O8A; Sat, 02 Mar 2024 07:43:16 +0000 Received: from m16.mail.126.com ([117.135.210.7]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgK1Y-000000033Bv-3Xlp for opensbi@lists.infradead.org; Sat, 02 Mar 2024 07:43:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=sZHWa psaM2AZosz4o9OgWfrec+EioHB4imdxRCoCOYw=; b=hcUTOkjFxp0fMXe1IoX/K 0ikCeOp2r10zXXHJge980QOJbm0lPYa3V8U8JQ2sRQzv6NDRAPKaYs265HdKH9UW FTgp5zw/8+jD6iS9QTM6ARmexWl65h5lbw/6Xa0X/RL6rGa2Zx1waf0izR2RLCCh 34n6MxIK1W4+Gn99EI2wc4= Received: from T490.lan (unknown [36.153.54.93]) by gzga-smtp-mta-g1-2 (Coremail) with SMTP id _____wD3X3N+2OJlaFAABQ--.21504S6; Sat, 02 Mar 2024 15:42:59 +0800 (CST) From: Xiang W <wxjstz@126.com> To: opensbi@lists.infradead.org Cc: Xiang W <wxjstz@126.com>, anup@brainfault.org Subject: [PATCH v5 4/8] firmware: fw_dynamic.S: Remove _bad_dynamic_info Date: Sat, 2 Mar 2024 15:42:23 +0800 Message-ID: <20240302074235.12643-5-wxjstz@126.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240302074235.12643-1-wxjstz@126.com> References: <20240302074235.12643-1-wxjstz@126.com> MIME-Version: 1.0 X-CM-TRANSID: _____wD3X3N+2OJlaFAABQ--.21504S6 X-Coremail-Antispam: 1Uf129KBjvdXoWrZw17uw1rJF1Dur1ruryrCrg_yoWDCrc_AF y3uFnxCr4FvrWrta109r1rCw1xZF97ua1qg3WxCw4UXr13J343Xrn5CFW2qr4v9a10kr45 AF17CrnIyFn7ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRAMa07UUUUU== X-Originating-IP: [36.153.54.93] X-CM-SenderInfo: pz0m23b26rjloofrz/xtbBdQeVOmSdLzVvKgABs6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_234313_675794_E0814FCC X-CRM114-Status: UNSURE ( 5.44 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: _bad_dynamic_info is same as _start_hang, so remove it. Signed-off-by: Xiang W Reviewed-by: Anup Patel --- firmware/fw_dynamic.S | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/firmware/fw_dynamic.S b/firmware/fw_dynamic.S index 7ff1c6a..5ee2883 100644 --- a/firmware/fw_dynamic.S +++ b/firmware/fw_dynamic.S @@ -11,12 +11,6 @@ Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [wxjstz(at)126.com] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <opensbi.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/opensbi>, <mailto:opensbi-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/opensbi/> List-Post: <mailto:opensbi@lists.infradead.org> List-Help: <mailto:opensbi-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/opensbi>, <mailto:opensbi-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "opensbi" <opensbi-bounces@lists.infradead.org> Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
Improvements to fw_base.S
|
expand
|
diff --git a/firmware/fw_dynamic.S b/firmware/fw_dynamic.S index 7ff1c6a..5ee2883 100644 --- a/firmware/fw_dynamic.S +++ b/firmware/fw_dynamic.S @@ -11,12 +11,6 @@ #include "fw_base.S" - .section .entry, "ax", %progbits - .align 3 -_bad_dynamic_info: - wfi - j _bad_dynamic_info - .section .entry, "ax", %progbits .align 3 .global fw_boot_hart @@ -30,10 +24,10 @@ fw_boot_hart: /* Sanity checks */ li a1, FW_DYNAMIC_INFO_MAGIC_VALUE REG_L a0, FW_DYNAMIC_INFO_MAGIC_OFFSET(a2) - bne a0, a1, _bad_dynamic_info + bne a0, a1, _start_hang li a1, FW_DYNAMIC_INFO_VERSION_MAX REG_L a0, FW_DYNAMIC_INFO_VERSION_OFFSET(a2) - bgt a0, a1, _bad_dynamic_info + bgt a0, a1, _start_hang /* Read boot HART id */ li a1, FW_DYNAMIC_INFO_VERSION_2