| Message ID | 20231210152511.1146592-1-wxjstz@126.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] lib: sbi: skip wait_for_coldboot when coolboot done | expand |
On Sun, Dec 10, 2023 at 8:55 PM Xiang W <wxjstz@126.com> wrote: > > When warmboot via HSM, coolboot has been completed and > wait_for_coldboot can be skipped to speed up. > > Signed-off-by: Xiang W <wxjstz@126.com> Looks good to me. Reviewed-by: Anup Patel <anup@brainfault.org> Thanks, Anup > --- > v2 changes: move coolboot_done check to wait_for_coldboot > > lib/sbi/sbi_init.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c > index e723553..e88c3b1 100644 > --- a/lib/sbi/sbi_init.c > +++ b/lib/sbi/sbi_init.c > @@ -195,6 +195,9 @@ static void wait_for_coldboot(struct sbi_scratch *scratch, u32 hartid) > { > unsigned long saved_mie, cmip; > > + if (__smp_load_acquire(&coldboot_done)) > + return; > + > /* Save MIE CSR */ > saved_mie = csr_read(CSR_MIE); > > -- > 2.42.0 > > > -- > opensbi mailing list > opensbi@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/opensbi
On Mon, Dec 11, 2023 at 9:52 AM Anup Patel <anup@brainfault.org> wrote: > > On Sun, Dec 10, 2023 at 8:55 PM Xiang W <wxjstz@126.com> wrote: > > > > When warmboot via HSM, coolboot has been completed and > > wait_for_coldboot can be skipped to speed up. > > > > Signed-off-by: Xiang W <wxjstz@126.com> > > Looks good to me. > > Reviewed-by: Anup Patel <anup@brainfault.org> Also, applied it to the riscv/opensbi repo. Regards, Anup > > Thanks, > Anup > > > --- > > v2 changes: move coolboot_done check to wait_for_coldboot > > > > lib/sbi/sbi_init.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c > > index e723553..e88c3b1 100644 > > --- a/lib/sbi/sbi_init.c > > +++ b/lib/sbi/sbi_init.c > > @@ -195,6 +195,9 @@ static void wait_for_coldboot(struct sbi_scratch *scratch, u32 hartid) > > { > > unsigned long saved_mie, cmip; > > > > + if (__smp_load_acquire(&coldboot_done)) > > + return; > > + > > /* Save MIE CSR */ > > saved_mie = csr_read(CSR_MIE); > > > > -- > > 2.42.0 > > > > > > -- > > opensbi mailing list > > opensbi@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/opensbi
diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c index e723553..e88c3b1 100644 --- a/lib/sbi/sbi_init.c +++ b/lib/sbi/sbi_init.c @@ -195,6 +195,9 @@ static void wait_for_coldboot(struct sbi_scratch *scratch, u32 hartid) { unsigned long saved_mie, cmip; + if (__smp_load_acquire(&coldboot_done)) + return; + /* Save MIE CSR */ saved_mie = csr_read(CSR_MIE);
When warmboot via HSM, coolboot has been completed and wait_for_coldboot can be skipped to speed up. Signed-off-by: Xiang W <wxjstz@126.com> --- v2 changes: move coolboot_done check to wait_for_coldboot lib/sbi/sbi_init.c | 3 +++ 1 file changed, 3 insertions(+)