[v5,01/14] lib: sbi: Fix missing contine in print

Message ID	20230609033430.84471-2-wxjstz@126.com
State	Superseded
Headers	show Return-Path: <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Xiang W <wxjstz@126.com> To: opensbi@lists.infradead.org Cc: Xiang W <wxjstz@126.com>, anup@brainfault.org, jrtc27@jrtc27.com Subject: [PATCH v5 01/14] lib: sbi: Fix missing contine in print Date: Fri, 9 Jun 2023 11:34:17 +0800 Message-Id: <20230609033430.84471-2-wxjstz@126.com> In-Reply-To: <20230609033430.84471-1-wxjstz@126.com> References: <20230609033430.84471-1-wxjstz@126.com> MIME-Version: 1.0 preview: Missing continue after print %lu %ld %lx ... Signed-off-by: Xiang W --- lib/sbi/sbi_console.c \| 1 + 1 file changed, 1 insertion(+) diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c index 168dffd..1f0727c 100644 --- a/lib/sbi/sbi_console.c +++ b/lib/sbi/sbi_console.c @@ -370,6 +370,7 @@ static int print(char *out, u32 o [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [wxjstz[at]126.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "opensbi" <opensbi-bounces@lists.infradead.org> Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	Improve sbi_console \| expand [v5,00/14] Improve sbi_console [v5,01/14] lib: sbi: Fix missing contine in print [v5,02/14] lib: sbi: Fix how print gets flags [v5,03/14] lib: sbi: print not fill '0' when left-aligned [v5,04/14] lib: sbi: Add '+' flags for print [v5,05/14] lib: sbi: Add ' ' '\'' flags for print [v5,06/14] lib: sbi: implifying the parameters of printi [v5,07/14] lib: sbi: print add 'o' type [v5,08/14] lib: sbi: Fix printi [v5,09/14] lib: sbi: Simplify prints [v5,10/14] lib: sbi: sbi_console.c code re-layout [v5,11/14] lib: sbi: Add print_info for sbi_console.c [v5,12/14] lib: sbi: Fix timing of clearing tbuf [v5,13/14] lib: sbi: Fix missing '\0' when buffer szie equal 1 [v5,14/14] lib: sbi: Fix invalid directive print

Message ID

20230609033430.84471-2-wxjstz@126.com

State

Superseded

Headers

From: Xiang W <wxjstz@126.com>
To: opensbi@lists.infradead.org
Cc: Xiang W <wxjstz@126.com>,
	anup@brainfault.org,
	jrtc27@jrtc27.com
Subject: [PATCH v5 01/14] lib: sbi: Fix missing contine in print
Date: Fri,  9 Jun 2023 11:34:17 +0800
Message-Id: <20230609033430.84471-2-wxjstz@126.com>
In-Reply-To: <20230609033430.84471-1-wxjstz@126.com>
References: <20230609033430.84471-1-wxjstz@126.com>
MIME-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "opensbi" <opensbi-bounces@lists.infradead.org>
Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

Improve sbi_console | expand

Comments

Jessica Clarke June 9, 2023, 4:16 a.m. UTC | #1

On 9 Jun 2023, at 04:34, Xiang W <wxjstz@126.com> wrote:
> 
> Missing continue after print %lu %ld %lx ...

What kind of commit message is this? What’s the exact bug?

Jess

> Signed-off-by: Xiang W <wxjstz@126.com>
> ---
> lib/sbi/sbi_console.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
> index 168dffd..1f0727c 100644
> --- a/lib/sbi/sbi_console.c
> +++ b/lib/sbi/sbi_console.c
> @@ -370,6 +370,7 @@ static int print(char **out, u32 *out_len, const char *format, va_list args)
>     va_arg(args, long), 10, 1,
>     width, flags, '0');
> }
> + continue;
> }
> if (*format == 'c') {
> /* char are converted to int then pushed on the stack */
> -- 
> 2.39.2
>

Xiang W June 9, 2023, 6:29 a.m. UTC | #2

在 2023-06-09星期五的 05:16 +0100，Jessica Clarke写道：
> On 9 Jun 2023, at 04:34, Xiang W <wxjstz@126.com> wrote:
> > 
> > Missing continue after print %lu %ld %lx ...
> 
> What kind of commit message is this? What’s the exact bug?
Thanks! There are no bugs here, just a different style of code
than the rest. I will drop this.

Xiang
> 
> Jess
> 
> > Signed-off-by: Xiang W <wxjstz@126.com>
> > ---
> > lib/sbi/sbi_console.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
> > index 168dffd..1f0727c 100644
> > --- a/lib/sbi/sbi_console.c
> > +++ b/lib/sbi/sbi_console.c
> > @@ -370,6 +370,7 @@ static int print(char **out, u32 *out_len, const char *format, va_list args)
> >     va_arg(args, long), 10, 1,
> >     width, flags, '0');
> > }
> > + continue;
> > }
> > if (*format == 'c') {
> > /* char are converted to int then pushed on the stack */
> > -- 
> > 2.39.2
> >

diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
index 168dffd..1f0727c 100644
--- a/lib/sbi/sbi_console.c
+++ b/lib/sbi/sbi_console.c
@@ -370,6 +370,7 @@  static int print(char **out, u32 *out_len, const char *format, va_list args)
 						     va_arg(args, long), 10, 1,
 						     width, flags, '0');
 				}
+				continue;
 			}
 			if (*format == 'c') {
 				/* char are converted to int then pushed on the stack */

[v5,01/14] lib: sbi: Fix missing contine in print

Commit Message

Comments

Patch