From patchwork Mon May 15 09:34:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 1781222 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=arF7ZPLa; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=MZz+ox6V; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QKZ3W27sJz20KF for ; Mon, 15 May 2023 19:35:19 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dvkqcydXc+E72Fx3aFS+fkOhwISK1OThXmehL+kCB4A=; b=arF7ZPLa+EP/mg OtqKNatz7FjpupUyOheqEWKgYj8oomRUqiSWd6wgoqIMgXRUiyy/RvPoo5YXPe0NV4NcsqWGSF/pE u0qTqe7M9VoDP/I8f8wxlTyKtdZfZRm7dFV/ISnv47CGHfKV10L7diBPY9H4l1aUX5hk4gOa8KcEu 8vBe71/FEqihNG2F6qBXlmqWYy6eUT2VmZxa0GqPc9CMUnp+0XWB5U7IZlbY1cxcgS/6jcuLOy26M oEnOTJhpY/FdF5xihNE4/+MYhNFEcWf6Tt8LeNCFjJB6ZN5/EKz6PcO7n4jUb4bWkd0EXroEfdjIj OcmPvurOmxpsVbpPLmdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyUbg-001ZN3-1A; Mon, 15 May 2023 09:35:04 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyUbc-001ZHk-1a for opensbi@lists.infradead.org; Mon, 15 May 2023 09:35:03 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-306f2b42a86so8158538f8f.3 for ; Mon, 15 May 2023 02:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1684143298; x=1686735298; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tzHCDMaacNPuuBM/3DU+z/rXdOA317R3T6eVlgx/0bc=; b=MZz+ox6VZkhB20ulflnAJmYLHJDAUErjFtw737pR9mkK+lRgc/eKLXVS5c0meQF8q3 MM7ILIXYkp2sWjIkPnjkpJxS9AF92wdzOJLdqkFZtDU0iyCfGqyTE8MlW/AVWbJ56rnS YswkbWxcv/7dLu/ezGLaunBOY7nScUfMAbR1f9WbIMWXGpw0YCaTc7RBM/PNwkDdmQ9I IH60mcHwUVjAkfd/YRWV/l79sOlS6tTD+ipMhtRqy3qnlySaficZhnAVj/FgnL60kxR9 7ohE/yru95nWD9IlV58d6awi7Bizt4EH9CD8C5k8644+LkaiYl45oLKSAoNx6Vjqrmxt JkFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684143298; x=1686735298; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tzHCDMaacNPuuBM/3DU+z/rXdOA317R3T6eVlgx/0bc=; b=kgizjRtSunTT0n5asQajl2P17+gSfuUgEfDTS8LPxxT4vhFtUSy0c0uEGpl9ykgoAx BcWv+yLxMeJf65Q2DYqlXSt3qO5mp4bNz+TU9b5SlNo3djRCZp7CyuhTzJT+pq6TCG58 G4KdH40NwmJraxlXw1xt6Alm0nL8o63GXclPemKkKAuVdns0Hpg1Ptk2VNx1K7tE8WHH 82KQQSA+pvNCzHRLQtI8R6Yfa4GBxEm5XADlA3V/LWlrZ2TkSQgrnIdpkhrZD64OrNuX OJsTbIIhOqAdxbye2pgYMLpHIWMkwiVmI/2xy2TC63AATS/w30/Bus36g51pTw6oTal5 LxrA== X-Gm-Message-State: AC+VfDxwPMIN1C3V0WKxrb8Zdt1XU6l+HwbWnNmrwu0lhHKJB8LSs3s4 q+MEE36ZcXClXEuSFMe61y1lKguLiTmsAbmQYE4= X-Google-Smtp-Source: ACHHUZ4V8mgwIr5l4NxJY1OZfHAAOUua/DKhs9Sz90KibTEzmpSXr+JLFW8ncmRuHh00Q45Br4xVEQ== X-Received: by 2002:adf:fcc5:0:b0:307:820a:490c with SMTP id f5-20020adffcc5000000b00307820a490cmr23654693wrs.13.1684143298158; Mon, 15 May 2023 02:34:58 -0700 (PDT) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id f5-20020adff985000000b002fda1b12a0bsm32217033wrr.2.2023.05.15.02.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 02:34:57 -0700 (PDT) From: Andrew Jones To: opensbi@lists.infradead.org Cc: Xiang W , Anup Patel Subject: [PATCH v5 3/7] lib: sbi: pmu: Remove unnecessary probe function Date: Mon, 15 May 2023 11:34:42 +0200 Message-Id: <20230515093446.73123-4-ajones@ventanamicro.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230515093446.73123-1-ajones@ventanamicro.com> References: <20230515093446.73123-1-ajones@ventanamicro.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230515_023500_542663_53D73214 X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The absence of a probe implementation means that the extension is always available. Remove the implementation for the PMU extension, which does no checking, and indeed even has a comment saying it's a [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:434 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The absence of a probe implementation means that the extension is always available. Remove the implementation for the PMU extension, which does no checking, and indeed even has a comment saying it's always available. Signed-off-by: Andrew Jones Reviewed-by: Anup Patel --- lib/sbi/sbi_ecall_pmu.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/lib/sbi/sbi_ecall_pmu.c b/lib/sbi/sbi_ecall_pmu.c index b0589d0ecfa1..1d5d512eeed7 100644 --- a/lib/sbi/sbi_ecall_pmu.c +++ b/lib/sbi/sbi_ecall_pmu.c @@ -81,13 +81,6 @@ static int sbi_ecall_pmu_handler(unsigned long extid, unsigned long funcid, return ret; } -static int sbi_ecall_pmu_probe(unsigned long extid, unsigned long *out_val) -{ - /* PMU extension is always enabled */ - *out_val = 1; - return 0; -} - struct sbi_ecall_extension ecall_pmu; static int sbi_ecall_pmu_register_extensions(void) @@ -99,6 +92,5 @@ struct sbi_ecall_extension ecall_pmu = { .extid_start = SBI_EXT_PMU, .extid_end = SBI_EXT_PMU, .register_extensions = sbi_ecall_pmu_register_extensions, - .probe = sbi_ecall_pmu_probe, .handle = sbi_ecall_pmu_handler, };