diff mbox series

lib: serial: Cadence: Enable compatibility for cdns,uart-r1p8

Message ID 20230301143800.1418232-1-mchitale@ventanamicro.com
State Accepted
Headers show
Series lib: serial: Cadence: Enable compatibility for cdns,uart-r1p8 | expand

Commit Message

Mayuresh Chitale March 1, 2023, 2:38 p.m. UTC
The Cadence driver does not use the RX byte status feature and hence can
be advertised to be compatible with cdns,uart-r1p8 as well.

Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
---
 lib/utils/serial/fdt_serial_cadence.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Anup Patel March 3, 2023, 12:27 p.m. UTC | #1
On Wed, Mar 1, 2023 at 8:08 PM Mayuresh Chitale
<mchitale@ventanamicro.com> wrote:
>
> The Cadence driver does not use the RX byte status feature and hence can
> be advertised to be compatible with cdns,uart-r1p8 as well.
>
> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>

Looks good to me.

Reviewed-by: Anup Patel <anup@brainfault.org>

Regards,
Anup

> ---
>  lib/utils/serial/fdt_serial_cadence.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/utils/serial/fdt_serial_cadence.c b/lib/utils/serial/fdt_serial_cadence.c
> index 946e533..ae59e4c 100644
> --- a/lib/utils/serial/fdt_serial_cadence.c
> +++ b/lib/utils/serial/fdt_serial_cadence.c
> @@ -24,6 +24,7 @@ static int serial_cadence_init(void *fdt, int nodeoff,
>  }
>
>  static const struct fdt_match serial_cadence_match[] = {
> +       { .compatible = "cdns,uart-r1p8", },
>         { .compatible = "cdns,uart-r1p12" },
>         { .compatible = "starfive,jh8100-uart" },
>         { },
> --
> 2.34.1
>
>
> --
> opensbi mailing list
> opensbi@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi
Anup Patel March 9, 2023, 3:48 p.m. UTC | #2
On Wed, Mar 1, 2023 at 8:08 PM Mayuresh Chitale
<mchitale@ventanamicro.com> wrote:
>
> The Cadence driver does not use the RX byte status feature and hence can
> be advertised to be compatible with cdns,uart-r1p8 as well.
>
> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>  lib/utils/serial/fdt_serial_cadence.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/utils/serial/fdt_serial_cadence.c b/lib/utils/serial/fdt_serial_cadence.c
> index 946e533..ae59e4c 100644
> --- a/lib/utils/serial/fdt_serial_cadence.c
> +++ b/lib/utils/serial/fdt_serial_cadence.c
> @@ -24,6 +24,7 @@ static int serial_cadence_init(void *fdt, int nodeoff,
>  }
>
>  static const struct fdt_match serial_cadence_match[] = {
> +       { .compatible = "cdns,uart-r1p8", },
>         { .compatible = "cdns,uart-r1p12" },
>         { .compatible = "starfive,jh8100-uart" },
>         { },
> --
> 2.34.1
>
>
> --
> opensbi mailing list
> opensbi@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi
diff mbox series

Patch

diff --git a/lib/utils/serial/fdt_serial_cadence.c b/lib/utils/serial/fdt_serial_cadence.c
index 946e533..ae59e4c 100644
--- a/lib/utils/serial/fdt_serial_cadence.c
+++ b/lib/utils/serial/fdt_serial_cadence.c
@@ -24,6 +24,7 @@  static int serial_cadence_init(void *fdt, int nodeoff,
 }
 
 static const struct fdt_match serial_cadence_match[] = {
+	{ .compatible = "cdns,uart-r1p8", },
 	{ .compatible = "cdns,uart-r1p12" },
 	{ .compatible = "starfive,jh8100-uart" },
 	{ },